[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user
Follow-up Comment #2, bug #20556 (project freeciv): I don't think this is sufficient. If you connect a second client to the server, it will get hack access. Why not using a server option (from command line) like --hack? I would expect that client get hack access on its spawn one, but not if running the server separatly. Maybe a second option for client side should be welcome to prevent to spawn the server with --hack? ___ Reply to this item at: http://gna.org/bugs/?20556 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user
Follow-up Comment #3, bug #20556 (project freeciv): If you connect a second client to the server, it will get hack access. Um... no? Server is not spawned by that client either. Unless you mean compiling second client without --disable-client-hack, but one would do that quite intentionally. Remember that this is not a security feature, but debug/testing feature. It's actually a valid use-case to test combination of hack and non-hack clients together. Why not using a server option (from command line) like --hack? How spawned server could then tell the spawning client apart from others? Or, assuming test involving both hack and non-hack clients, how does it know should-allow-hack clients in general? That's why I think it should be in client side. ___ Reply to this item at: http://gna.org/bugs/?20556 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22111] 'non-pact diplstate in handle_player_cancel_pact' error in endless loop
URL:
http://gna.org/bugs/?22111
Summary: 'non-pact diplstate in handle_player_cancel_pact'
error in endless loop
Project: Freeciv
Submitted by: None
Submitted on: Fri 30 May 2014 06:51:00 AM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email: maecmp...@mail.ru
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: Microsoft Windows
Planned Release:
___
Details:
Hello,
I'm getting 'non-pact diplstate in handle_player_cancel_pact' error in endless
loop (last message repeated 2097152 times (total 4194304 repeats)) when I
click end turn. Save attached.
This could possibly happen in pact switch logic:
switch(old_type) {
case DS_NO_CONTACT: /* possible if someone declares war on our ally */
case DS_ARMISTICE:
case DS_CEASEFIRE:
case DS_PEACE:
new_type = DS_WAR;
break;
case DS_ALLIANCE:
new_type = DS_ARMISTICE;
break;
default:
log_error(non-pact diplstate in handle_player_cancel_pact);
return;
}
Setting new_type = DS_WAR; in default instead of log_error can possibly solve
error.
___
File Attachments:
---
Date: Fri 30 May 2014 06:51:00 AM UTC Name:
freeciv-T0039-Y-2050-manual.sav.bz2 Size: 82kB By: None
http://gna.org/bugs/download.php?file_id=20862
___
Reply to this item at:
http://gna.org/bugs/?22111
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4741] Correct client options file path in README.packaging
URL: http://gna.org/patch/?4741 Summary: Correct client options file path in README.packaging Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 06:38:58 PM EEST Category: docs Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: ___ File Attachments: --- Date: Fri 30 May 2014 06:38:58 PM EEST Name: PackagingClientFilePath.patch Size: 673B By: cazfi http://gna.org/patch/download.php?file_id=20863 ___ Reply to this item at: http://gna.org/patch/?4741 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4742] Handle pickable nations changes in sdl-clients
URL: http://gna.org/patch/?4742 Summary: Handle pickable nations changes in sdl-clients Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 07:06:55 PM EEST Category: client-sdl Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0 ___ Details: Do full refresh for nation selection dialog when server changes set of pickable nations. ___ File Attachments: --- Date: Fri 30 May 2014 07:06:55 PM EEST Name: SdlPickableUpdate.patch Size: 3kB By: cazfi http://gna.org/patch/download.php?file_id=20864 --- Date: Fri 30 May 2014 07:06:55 PM EEST Name: SdlPickableUpdate-S2_5.patch Size: 928B By: cazfi http://gna.org/patch/download.php?file_id=20865 ___ Reply to this item at: http://gna.org/patch/?4742 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4743] Don't allow removal of advances in use
URL: http://gna.org/patch/?4743 Summary: Don't allow removal of advances in use Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 08:23:52 PM EEST Category: freeciv-ruledit Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Do not remove advances that are requirement for something else in the ruleset. Effects are not yet checked. ___ File Attachments: --- Date: Fri 30 May 2014 08:23:52 PM EEST Name: RemovalValidity.patch Size: 10kB By: cazfi http://gna.org/patch/download.php?file_id=20866 ___ Reply to this item at: http://gna.org/patch/?4743 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7804] Branch S2_6
URL: http://gna.org/task/?7804 Summary: Branch S2_6 Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 08:38:03 PM EEST Should Start On: Fri 02 Jan 2015 12:00:00 AM EET Should be Finished on: Fri 02 Jan 2015 12:00:00 AM EET Category: None Priority: 5 - Normal Status: None Privacy: Public Percent Complete: 0% Assigned to: cazfi Open/Closed: Open Discussion Lock: Any Effort: 0.00 Planned Release: ___ Details: Start tracking all the bits and pieces that should be handled by the time S2_6 is branched to give good start for both the stable branch and 3.0 development. We don't know branching date yet. I just set it to the beginning of the next year, 20 months after S2_5 branching, as I can't see it happening *earlier*. ___ Reply to this item at: http://gna.org/task/?7804 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4744] Save version table (comment) from savegame2.c to savecompat.c
URL: http://gna.org/patch/?4744 Summary: Save version table (comment) from savegame2.c to savecompat.c Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 09:04:20 PM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Move comment describing different save version numbers to savecompat.c. ___ File Attachments: --- Date: Fri 30 May 2014 09:04:20 PM EEST Name: SaveCompatTableComment.patch Size: 4kB By: cazfi http://gna.org/patch/download.php?file_id=20867 ___ Reply to this item at: http://gna.org/patch/?4744 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4745] Configure check for libxml2
URL: http://gna.org/patch/?4745 Summary: Configure check for libxml2 Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 09:36:29 PM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Last time I worked on xml version of the registry code all the patches eventually got lost. Now I'm submitting this immediately. Add configure option --enable-xml-registry that does check for libxml2 and sets results to UTILITY_CFLAGS and UTILITY_LIBS. No code uses libxml2 yet. ___ File Attachments: --- Date: Fri 30 May 2014 09:36:29 PM EEST Name: XmlCheck.patch Size: 950B By: cazfi http://gna.org/patch/download.php?file_id=20868 ___ Reply to this item at: http://gna.org/patch/?4745 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20556] No way to disable hack access of new clients of local server with same user
Follow-up Comment #4, bug #20556 (project freeciv): I have probably missed something when reading your patch, sorry. ___ Reply to this item at: http://gna.org/bugs/?20556 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21492] luasql mysql backend compile error with clang
Update of bug #21492 (project freeciv): Category:None = general Status:None = Ready For Test Planned Release: = 2.5.0, 2.6.0 ___ Follow-up Comment #1: Fix (file #20869) ___ Additional Item Attachment: File name: AlignLuasqlMysql.patch Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?21492 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4717] Add Quickening revolution length type
Update of patch #4717 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4717 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22113] Player traits not allocated when loading saved game
URL: http://gna.org/bugs/?22113 Summary: Player traits not allocated when loading saved game Project: Freeciv Submitted by: cazfi Submitted on: Fri 30 May 2014 11:07:00 PM EEST Category: ai Severity: 3 - Normal Priority: 9 - Immediate Status: Ready For Test Assigned to: cazfi Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.6.0 ___ Details: Starting game from savegame leads to crash as soon as AI tries to do something. Fix attached. Will commit (almost) immediately. ___ File Attachments: --- Date: Fri 30 May 2014 11:07:00 PM EEST Name: SavegameTraitInit.patch Size: 1kB By: cazfi http://gna.org/bugs/download.php?file_id=20870 ___ Reply to this item at: http://gna.org/bugs/?22113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22113] Player traits not allocated when loading saved game
Update of bug #22113 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?22113 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4747] Make client settings code to understand that 2.6 is followed by 3.0
URL: http://gna.org/patch/?4747 Summary: Make client settings code to understand that 2.6 is followed by 3.0 Project: Freeciv Submitted by: cazfi Submitted on: Sat 31 May 2014 01:10:45 AM EEST Category: client Priority: 5 - Normal Status: None Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: ___ Details: Currently when version number is bumped to 2.6.99 (development version of 3.0), client assumes options file name with 2.7 in it. It should switch to 3.0. The other side of the story is that freeciv-3.0 should know that previous freeciv version (and options file) was 2.6. ___ Reply to this item at: http://gna.org/patch/?4747 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [task #7804] Branch S2_6
Update of task #7804 (project freeciv): Depends on: = patch #4747 ___ Reply to this item at: http://gna.org/task/?7804 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4748] TRUNK windows followtag to win32-S2_6
URL: http://gna.org/patch/?4748 Summary: TRUNK windows followtag to win32-S2_6 Project: Freeciv Submitted by: cazfi Submitted on: Sat 31 May 2014 01:31:38 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: In S2_5 branch we changed followtag for windows builds to win32-S2_5 for the duration of beta releases. We left TRUNK to stable tag win32 with an idea that it will again be changed back and forth in future stable branches. But for anything build from TRUNK stable tag makes even less sense than for early releases from stable branch. So instead of changing tag from win32 to win32-branch in branch after branching, we could have future branch tag in TRUNK already, and change it from win32-branch to win32-next branch after branching. Attached patch makes tag in current TRUNK win32-S2_6. ___ File Attachments: --- Date: Sat 31 May 2014 01:31:38 AM EEST Name: Win32S2_6.patch Size: 961B By: cazfi http://gna.org/patch/download.php?file_id=20872 ___ Reply to this item at: http://gna.org/patch/?4748 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22050] Recursive transport problems
Follow-up Comment #5, bug #22050 (project freeciv): New version of the patch: could_unit_load() also prevents recursive transport depth doesn't increase over GAME_TRANSPORT_MAX_RECURSIVE. (file #20873) ___ Additional Item Attachment: File name: recursive_transport2.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?22050 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4749] Calendar module
URL: http://gna.org/patch/?4749 Summary: Calendar module Project: Freeciv Submitted by: cazfi Submitted on: Sat 31 May 2014 02:09:47 AM EEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Move calendar related functions from game.c to new calendar.[ch] module. ___ File Attachments: --- Date: Sat 31 May 2014 02:09:47 AM EEST Name: CalendarModule.patch Size: 12kB By: cazfi http://gna.org/patch/download.php?file_id=20874 ___ Reply to this item at: http://gna.org/patch/?4749 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4749] Calendar module
Follow-up Comment #1, patch #4749 (project freeciv): - All clients compile (file #20875) ___ Additional Item Attachment: File name: CalendarModule-2.patch Size:13 KB ___ Reply to this item at: http://gna.org/patch/?4749 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4750] Gfx tag for specialist entertainer
URL: http://gna.org/patch/?4750 Summary: Gfx tag for specialist entertainer Project: Freeciv Submitted by: cazfi Submitted on: Sat 31 May 2014 02:34:43 AM EEST Category: rulesets Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: For backward compatibility existing rulesets need to keep using rule_name elvis for entertainers, but we shouldn't force also new rulesets to use it instead of entertainer. Attached patch adds entertainer tags to specialists.spec so that graphics are found for rulesets using that specialist name. ___ File Attachments: --- Date: Sat 31 May 2014 02:34:43 AM EEST Name: EntertainerTag.patch Size: 536B By: cazfi http://gna.org/patch/download.php?file_id=20876 ___ Reply to this item at: http://gna.org/patch/?4750 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4751] Update codeset.m4 to serial 5 (gettext-0.18.2)
URL: http://gna.org/patch/?4751 Summary: Update codeset.m4 to serial 5 (gettext-0.18.2) Project: Freeciv Submitted by: cazfi Submitted on: Sat 31 May 2014 03:31:37 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: We have made similar fixes to our version ourselves, but having bit by bit (whitespace) identical version to upstream makes future comparisons easier. ___ File Attachments: --- Date: Sat 31 May 2014 03:31:37 AM EEST Name: CodesetM4Up.patch Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=20877 ___ Reply to this item at: http://gna.org/patch/?4751 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4752] Remove unused imlib.m4
URL: http://gna.org/patch/?4752 Summary: Remove unused imlib.m4 Project: Freeciv Submitted by: cazfi Submitted on: Sat 31 May 2014 03:40:58 AM EEST Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: Remove unused imlib.m4. In addition to applying this patch the file should be removed also from version control with 'svn rm' ___ File Attachments: --- Date: Sat 31 May 2014 03:40:58 AM EEST Name: ImlibM4Rm.patch Size: 355B By: cazfi http://gna.org/patch/download.php?file_id=20878 ___ Reply to this item at: http://gna.org/patch/?4752 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
