[Freeciv-Dev] [patch #4803] Probable incorrrect use of single equal sign in if statement

2014-06-13 Thread Jon 
URL:
  

 Summary: Probable incorrrect use of single equal sign in if
statement
 Project: Freeciv
Submitted by: stratthinker
Submitted on: Sat 14 Jun 2014 12:51:49 AM UTC
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

In the file srv_main.c I found on line 1244 this code
[code]
if ((filename = strrchr(filepath, '/'))) {
[/code]
shouldn't there be a double equal sign.
I have uploaded a patch to change it to a double equal sign.



___

File Attachments:


---
Date: Sat 14 Jun 2014 12:51:49 AM UTC  Name: srv_main.patch  Size: 440B   By:
stratthinker
Changed single equal sign to double equal sign


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4802] spechash improvements

2014-06-13 Thread pepeto 
URL:
  

 Summary: spechash improvements
 Project: Freeciv
Submitted by: pepeto
Submitted on: ven. 13 juin 2014 23:14:10 CEST
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

I noticed I wasn't warned in compilation time about bug #22185 when I worked
for patch #4729. So, I decided to review the spechash code...

In the patch:
* Functions are no more blindly casted to genhash_XXX_fn_t ;
* Differentiation between internal key|data types (used inside genhash) and
user key|data types (used by the caller) ;
* Make a set of default functions for integer, allocated string, and static
strings key|data.




___

File Attachments:


---
Date: ven. 13 juin 2014 23:14:10 CEST  Name: spechash.patch  Size: 51 ko   By:
pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22185] Floating point exception (core dumped)

2014-06-13 Thread pepeto 
URL:
  

 Summary: Floating point exception (core dumped)
 Project: Freeciv
Submitted by: pepeto
Submitted on: ven. 13 juin 2014 22:59:28 CEST
Category: client
Severity: 5 - Blocker
Priority: 7 - High
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r25010
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0

___

Details:

I didn't change attr_key_val() in patch #4729. So it might perform a division
by zero (the argument num_buckets is not initialized). Fix attached.




___

File Attachments:


---
Date: ven. 13 juin 2014 22:59:28 CEST  Name: client_attribute_spechash.patch 
Size: 1 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22184] Windows installer has translations from freeciv domain only

2014-06-13 Thread Marko Lindqvist 
URL:
  

 Summary: Windows installer has translations from freeciv
domain only
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 13 Jun 2014 10:13:28 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Not actually tested, but reading windows installer makefile it seems to me
that it will remove translations of the nations and ruledit domains from the
package.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19307] SECFILE_RETURN_VAL_IF_FAIL() returning NULL as boolean

2014-06-13 Thread Marko Lindqvist 
Update of bug #19307 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21942] Crash when opening city window with gtk3

2014-06-13 Thread Marko Lindqvist 
Follow-up Comment #3, bug #21942 (project freeciv):

> it seems something related to the 64 bits OS. Doesn't it?

It just shows that you're using 64 bit version. In recent years all the
32bit/64bit incompatibilities in freeciv have been problems with 32bits as
such systems are rarely used by the development team any more (I switched to
64bit OS 2006, so...)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4793] Remove gui-sdl2/alphablit.c from under version control

2014-06-13 Thread Marko Lindqvist 
Update of patch #4793 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21942] Crash when opening city window with gtk3

2014-06-13 Thread David Fernandez 
Follow-up Comment #2, bug #21942 (project freeciv):

I just updated to kubuntu 14.04, I compiled rev25134 with gtk3 enabled, and it
keep crashing when I build my first city.

___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4772] Revert to gtk2-client as default client in 2.5

2014-06-13 Thread Marko Lindqvist 
Update of patch #4772 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4797] dai_find_source_building() to consider all unit related requirement types

2014-06-13 Thread Marko Lindqvist 
Follow-up Comment #1, patch #4797 (project freeciv):

- Do not check existence of the requirement building, when the building is
just being considered to be built

(file #20996)
___

Additional Item Attachment:

File name: FindSrcBuildingReqTypes-2.patch Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22158] tech_upkeep_style 'Cities' vs team_pooled_research

2014-06-13 Thread David Fernandez 
Follow-up Comment #1, bug #22158 (project freeciv):

The way I see it, I think the upkeep should take into acount all the cities
from all the players on the same team, as you point.

The original idea of this new style was to redefine the tech upkeep as "the
bulbs needed per city".
When the tech upkeep is 10, one player should pay 10 bulbs per city, and 4
players in same team should also pay 10 bulbs per city.

If the tech upkeep is shared and paid only once per team, I think it should
take into account all the cities owned by the team.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4801] Gtk3 client: Change the way spy action probabilities are displayed.

2014-06-13 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Gtk3 client: Change the way spy action probabilities
are displayed.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 13 Jun 2014 12:38:25 PM UTC
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

- Show "(?%)" in stead of making the button red when "known to be unknown".
- Add a tool tip when the action probability is known.



___

File Attachments:


---
Date: Fri 13 Jun 2014 12:38:25 PM UTC  Name: 0002-Gtk3.patch  Size: 6kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4800] Gtk2 client: Change the way spy action probabilities are displayed.

2014-06-13 Thread Sveinung Kvilhaugsvik 
URL:
  

 Summary: Gtk2 client: Change the way spy action probabilities
are displayed.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 13 Jun 2014 12:34:56 PM UTC
Category: client-gtk-2.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

- Show "(?%)" in stead of a warning icon for "known to be unknown".
- Add a tool tip when the action probability is known.



___

File Attachments:


---
Date: Fri 13 Jun 2014 12:34:56 PM UTC  Name: 0001-Gtk2-client.patch  Size: 7kB
  By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev