[Freeciv-Dev] [bug #22238] civ2civ3: buildings with old obsolete_by syntax

2014-06-24 Thread Jacob Nevins 
Update of bug #22238 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-civ2civ3-obsoleteby.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3318] Lycian nation

2014-06-24 Thread Jacob Nevins 
Follow-up Comment #3, patch #3318 (project freeciv):

Attached patch comments out Lydian civilwar_nation (not yet added: patch
#3423) to avoid a warning at -d 3 level.

(file #21150)
___

Additional Item Attachment:

File name: trunk-lycian-civilwar.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4292] Formosan nation

2014-06-24 Thread Jacob Nevins 
Follow-up Comment #2, patch #4292 (project freeciv):

The legend for this nation has missing spaces at line wraps, so comes out
wrong. Patch attached.

(file #21149)
___

Additional Item Attachment:

File name: trunk-formosan-legend.patchSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22235] Add rule_name for ruthenian.ruleset (now Kievan Rus')

2014-06-24 Thread Jacob Nevins 
Update of bug #22235 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-kievan-rus-rule-name-bis.patch Size:5 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22238] civ2civ3: buildings with old obsolete_by syntax

2014-06-24 Thread Jacob Nevins 
URL:
  

 Summary: civ2civ3: buildings with old obsolete_by syntax
 Project: Freeciv
Submitted by: jtn
Submitted on: Wed 25 Jun 2014 00:17:54 BST
Category: rulesets
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: trunk r25262
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0

___

Details:

Running server with "-d 3" showed that Women's Suffrage and Coinage still have
old pre-requirements 'obsolete_by = "None"' syntax.

Perhaps this should be a harder error? It showed up as follows. Another ticket
if so.


3: Unused entries in file data/civ2civ3/buildings.ruleset:
3:   unused entry: building_womens_suffrage.obsolete_by
3:   unused entry: building_capitalization.obsolete_by





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4799] Unhardcode "IgWall"

2014-06-24 Thread Marko Lindqvist 
Follow-up Comment #4, patch #4799 (project freeciv):

- Changes needed to stub ruleset

(file #21147)
___

Additional Item Attachment:

File name: IgWallRm-4.patch.bz2   Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [Freeciv-commits] r25261 - /trunk/ai/default/aiunit.c

2014-06-24 Thread Emmet Hikory 
Marko Lindqvist wrote:
> On 24 June 2014 22:33,   wrote:
> > Author: persia
> > Date: Tue Jun 24 21:33:48 2014
> > New Revision: 25261
> >
> > URL: http://svn.gna.org/viewcvs/freeciv?rev=25261&view=rev
> > Log:
> > Cleanups in dai_is_unit_tired_waiting_boat()
> >
> > * Fix home continent test to check continent rather than tile
> 
>  Isn't that a bug in S2_5 also?

Indeed it is: bugfix only patch attached to bug #22237

-- 
Emmet HIKORY

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22237] dai_is_unit_tired_waiting_boat() checks tile identity rather than continent identity

2014-06-24 Thread Emmet Hikory 
URL:
  

 Summary: dai_is_unit_tired_waiting_boat() checks tile
identity rather than continent identity
 Project: Freeciv
Submitted by: persia
Submitted on: Wed 25 Jun 2014 05:08:36 AM JST
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: persia
Originator Email: 
 Open/Closed: Open
 Release: r25255 (S2_5)
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.0

___

Details:

Discovered while working on patch #4839 (and fixed in trunk there),
dai_is_unit_tired_waiting_boat() has a commented conditional that is intended
to check if the unit is on it's home continent, which instead checks to see if
the unit is in it's home city.

The attached patch extracts only the bugfix from the trunk patch, for
application to S2_5.



___

File Attachments:


---
Date: Wed 25 Jun 2014 05:08:36 AM JST  Name:
fix-home-continent-test-to-check-continent-rather-than-tile.patch  Size: 742B 
 By: persia



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3279] Rusyn nation

2014-06-24 Thread Jacob Nevins 
Follow-up Comment #3, patch #3279 (project freeciv):

r23250 ,
which added the Rusyn nation, also renamed the Ruthenians to the Kievan Rus'.

See bug #22235 for some fixup we'll have to do for that, for backward
compatibility.

Is there likely to be a forthcoming "real" Ruthenian ruleset, or is the term
"Ruthenian" too imprecise?
(Patch #1496 is where ruthenian.ruleset was originally added, and has some
more discussion.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4649] Use gen-move compliant bodyguard filter

2014-06-24 Thread Emmet Hikory 
Follow-up Comment #9, patch #4649 (project freeciv):

Updated patch doesn't generate the assertion failures when run: apparently I
was attempting to use a cache before populating it again.

(file #21145)
___

Additional Item Attachment:

File name: use-gen-move-compatible-bodyguard-filter+noassert.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4836] Ignore nativity-providing extras for simple types

2014-06-24 Thread Emmet Hikory 
Update of patch #4836 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22235] Add rule_name for ruthenian.ruleset (now Kievan Rus')

2014-06-24 Thread Jacob Nevins 
Update of bug #22235 (project freeciv):

  Status:   Need Info => In Progress

___

Follow-up Comment #2:

> work out what effect this has on civilwar_nations and 
> conflicts_with before committing.
Ah, the rule_name is used for those. So all the civilwar/conflicts that were
changed to "Kievan Rus'" in patch #3279 would have to be changed back here.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4841] Consider defense effects for any defender

2014-06-24 Thread Emmet Hikory 
Update of patch #4841 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4839] Cleanups in dai_is_unit_tired_waiting_boat()

2014-06-24 Thread Emmet Hikory 
Follow-up Comment #2, patch #4839 (project freeciv):

Unfortunately, as I was doing my post-commit cleanup, I noticed that I
reversed the logical test with this patch.  Attached is another patch that
fixes that.

(file #21144)
___

Additional Item Attachment:

File name: fix-reversed-logic-in-dai_is_unit_tired_waiting_boat.patch Size:1
KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4838] Use UTYF_BADCITYDEFENDER in process_defender_want()

2014-06-24 Thread Emmet Hikory 
Update of patch #4838 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4837] Use pathfinding to identify missile carrier risk

2014-06-24 Thread Emmet Hikory 
Update of patch #4837 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22232] Rulesave fails to save pythagorean_diagnonal==FALSE for RS_DEFAULT_PYTHAGOREAN_DIAGONAL==TRUE sources

2014-06-24 Thread Emmet Hikory 
Update of bug #22232 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] [Freeciv-commits] r25261 - /trunk/ai/default/aiunit.c

2014-06-24 Thread Marko Lindqvist 
On 24 June 2014 22:33,   wrote:
> Author: persia
> Date: Tue Jun 24 21:33:48 2014
> New Revision: 25261
>
> URL: http://svn.gna.org/viewcvs/freeciv?rev=25261&view=rev
> Log:
> Cleanups in dai_is_unit_tired_waiting_boat()
>
> * Fix home continent test to check continent rather than tile

 Isn't that a bug in S2_5 also?


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22230] pf_normal_map_move_cost crash

2014-06-24 Thread Emmet Hikory 
Update of bug #22230 (project freeciv):

  Status:None => Confirmed  
 Release: => SVN r25188 

___

Follow-up Comment #4:

I played whack-a-mole with this a bit today.  Returning PF_IMPOSSIBLE_MC as I
described in comment #2 removes some cases, but I found others in further
autogame testing.  Changing pf_*_node_iterate_until() to return FALSE if ptile
== NULL, and only initialise node when it is provided seems to avoid crashes
in the core pathfinding code, but causes assertion failures in other parts of
the code (and occasional crashes).  The specific problem chunks from patch
#4678 are related to the case where the starting position for the path is to
be ignored (either set TB_IGNORE or cannot invade), causing the initial node
to have the tile set to NULL (to indicate no path is possible).: reverting
these chunks resulted in a lack of crashes on the model of those in the
original report and comment #1, but I don't believe this to be the correct
solution, as it means that the pathfinding code proceeds with a known invalid
node (for which the invalidity is not being tracked).

I've attached a patch that removes the symptom, but won't apply it to trunk,
rather hoping someone else with better understanding will investigate further
(perhaps using my results as a starting point).

Note that I do not believe the backtrace in comment #3 is directly related:
the call path is sufficiently different that I can't understand how the change
in my patch could cause this not to occur.



(file #21143)
___

Additional Item Attachment:

File name: revert-selected-parts-of-patch-4768.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev