[Freeciv-Dev] [bug #22608] Gtk buttons no longer localised on Windows

2014-09-12 Thread Marko Lindqvist
Follow-up Comment #2, bug #22608 (project freeciv):

We had similar bug for gtk3-client after the modpack installer changes in Win
installer package creation, caused by the fact that gtk3 translations file was
not part of the package (the regexp to match what translation files to include
was broken). I would check existence of the gtk2 translation files (mo) before
anything else.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22567] AI does not build/buy defenders as enemy approaches

2014-09-12 Thread pepeto
Follow-up Comment #27, bug #22567 (project freeciv):

Tested with revision 25715 shows the AI to build units for attacking and for
defending. So the cause is probably something in revision(s) > 25715.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22567] AI does not build/buy defenders as enemy approaches

2014-09-12 Thread pepeto
Follow-up Comment #26, bug #22567 (project freeciv):

I have observed:
* The AI doesn't make units for attacking other players (with or without
reverting) ;
* The AI doesn't make units for defense (with or without reverting) ;
* The AI sometimes (but not always) defend against barbarians with reverting
the patches, but doesn't defend at all without.

Also noticed that patch #5201 doesn't help.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22615] in team_members() [common/team.c::453]: assertion '((void *)0) != pteam' failed.

2014-09-12 Thread pepeto
URL:
  

 Summary: in team_members() [common/team.c::453]: assertion
'((void *)0) != pteam' failed.
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 13 sept. 2014 01:42:16 CEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r26384
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Occurred when barbarians appeared, I think.


1: in team_members() [common/team.c::453]: assertion '((void *)0) != pteam'
failed.
2: Backtrace:
2: 0: ./client/freeciv-gtk2(backtrace_print+0x30) [0x61a6f0]
2: 1: ./client/freeciv-gtk2(vdo_log+0x8b) [0x61f70b]
2: 2: ./client/freeciv-gtk2(do_log+0x7d) [0x61f7bd]
2: 3: ./client/freeciv-gtk2(fc_assert_fail+0x8e) [0x61f9ae]
2: 4: ./client/freeciv-gtk2(team_members+0x32) [0x60b2e2]
2: 5: ./client/freeciv-gtk2(research_player_iter_init+0x56) [0x606af6]
2: 6: ./client/freeciv-gtk2(research_total_bulbs_required+0xa5)
[0x606c55]
2: 7: ./client/freeciv-gtk2(research_update+0x130) [0x607490]
2: 8: ./client/freeciv-gtk2(handle_research_info+0x151) [0x4a70a1]
2: 9: ./client/freeciv-gtk2(client_handle_packet+0x5fe) [0x4ada8e]
2:10: ./client/freeciv-gtk2(client_packet_input+0x1f) [0x474f0f]
2:11: ./client/freeciv-gtk2(input_from_server+0x6c) [0x47b7ec]
2:12: ./client/freeciv-gtk2() [0x44b920]
2:13:
/lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_context_dispatch+0x135)
[0x7fad95638ce5]
2:14: /lib/x86_64-linux-gnu/libglib-2.0.so.0(+0x49048) [0x7fad95639048]
2:15: /lib/x86_64-linux-gnu/libglib-2.0.so.0(g_main_loop_run+0x6a)
[0x7fad9563930a]
2:16: /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0(gtk_main+0xa7)
[0x7fad96394447]
2:17: ./client/freeciv-gtk2(ui_main+0x539) [0x44cc69]
2:18: ./client/freeciv-gtk2(client_main+0x331) [0x475551]
2:19: /lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf5)
[0x7fad9502dec5]
2:20: ./client/freeciv-gtk2() [0x449aee]






___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22614] in player_number() [common/player.c::730]: assertion '((void *)0) != pplayer' failed.

2014-09-12 Thread pepeto
URL:
  

 Summary: in player_number() [common/player.c::730]: assertion
'((void *)0) != pplayer' failed.
 Project: Freeciv
Submitted by: pepeto
Submitted on: sam. 13 sept. 2014 01:20:36 CEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r26384
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Lot of these messages appear when the game ends when the client is a global
observer. Didn't test if the client is detached, neither in S2_5 nor S2_4.

handle_endgame_player() does not check for client_has_player().





___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22608] Gtk buttons no longer localised on Windows

2014-09-12 Thread Christian Prochaska
Follow-up Comment #1, bug #22608 (project freeciv):

The GTK+ 2 version is still the same (2.24.10), but the other GTK+-related
libraries have been upgraded with the GTK+ 3 bundle. I could reproduce the
problem with Freeciv 2.3.5 after replacing the GLib DLL with the newer
version. Interestingly, the GTK+ 3 client doesn't seem to be affected.

___

Reply to this item at:

  

___
  Nachricht gesendet von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22573] AI prefers coinage in early game

2014-09-12 Thread pepeto
Follow-up Comment #2, bug #22573 (project freeciv):

Erratum: it was civ2civ3 ruleset.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22567] AI does not build/buy defenders as enemy approaches

2014-09-12 Thread Marko Lindqvist
Follow-up Comment #25, bug #22567 (project freeciv):

> I have rebuilt an autogame with reverted patch #4970 and
> patch #4971. Attaching autosave at turn 800 shows that
> barbarians nearly invaded all the world.

There's several problems in AI vs barbarians equation, but reverting those
patches makes AI to at least to attempt defending. I recommend testing as
global observer to autogame with timeout 10-20 to see how AI does not get
defenders even when barbarian unit is standing next to the city to conquer.
Low 'onsetbarbs' helps.

I've been using my own rulesets, which is almost identical to variant2
(available via modpack installer).
I'll create an autogame to demonstrate this unless you can make one yourself
sooner.

As for my last night comments about patch #4970, I probably read the patch the
wrong direction (reading the reverting patch -> what I thought was removed,
was actually added)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5225] Centralize checking that an action probability represents a possible value.

2014-09-12 Thread Sveinung Kvilhaugsvik
URL:
  

 Summary: Centralize checking that an action probability
represents a possible value.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 12 Sep 2014 05:40:45 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

(textual dependency on patch #5224)



___

File Attachments:


---
Date: Fri 12 Sep 2014 05:40:45 PM UTC  Name:
0002-Centralize-checking-that-an-action-probability-repre.patch  Size: 8kB  
By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5224] Xaw client: Create action_dialog.c containing diplomat and caravan dialog

2014-09-12 Thread Sveinung Kvilhaugsvik
URL:
  

 Summary: Xaw client: Create action_dialog.c containing
diplomat and caravan dialog
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 12 Sep 2014 03:56:36 PM UTC
Category: client-xaw
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Fri 12 Sep 2014 03:56:36 PM UTC  Name:
0001-Xaw-client-Create-action_dialog.c-containing-diploma.patch  Size: 68kB  
By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22612] SDL clients don't move on in the action queue after "Keep moving"

2014-09-12 Thread Sveinung Kvilhaugsvik
URL:
  

 Summary: SDL clients don't move on in the action queue after
"Keep moving"
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 12 Sep 2014 03:52:19 PM UTC
Category: client-sdl2
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:





___

File Attachments:


---
Date: Fri 12 Sep 2014 03:52:19 PM UTC  Name:
0001-SDL-clients-Move-on-to-the-next-action-selection-aft.patch  Size: 1kB  
By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22585] Player handicaps memory leak

2014-09-12 Thread pepeto
Update of bug #22585 (project freeciv):

  Status: In Progress => Ready For Test 
 Assigned to:None => pepeto 
 Planned Release: => 2.6.0  


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22590] Various memory leak when loading a ruleset

2014-09-12 Thread pepeto
Update of bug #22590 (project freeciv):

  Status: In Progress => Ready For Test 
 Assigned to:None => pepeto 
 Release:   trunk => trunk, S2_5
 Planned Release: => 2.5.0, 2.6.0   

___

Follow-up Comment #1:

Version for S2_5 attached.


(file #22164)
___

Additional Item Attachment:

File name: S2_5_ruleset_load.patchSize:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22584] dai_units_ruleset_init() memory leak

2014-09-12 Thread pepeto
Update of bug #22584 (project freeciv):

  Status: In Progress => Ready For Test 
 Assigned to:None => pepeto 
 Release:   trunk => trunk, S2_5
 Planned Release: => 2.5.0, 2.6.0   

___

Follow-up Comment #1:

Version for S2_5 attached.


(file #22163)
___

Additional Item Attachment:

File name: S2_5_dai_units_ruleset_init.patch Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22605] Infinite loop in fair_do_geometry

2014-09-12 Thread pepeto
Update of bug #22605 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => pepeto 
Operating System:None => Any
 Planned Release: => 2.5.0, 2.6.0   

___

Follow-up Comment #3:

Fix: reduce the maximum number of iteration proportionally to the number of
tiles (clipped between 1 and 10).


(file #22162)
___

Additional Item Attachment:

File name: fair_island_map_gen_max_iter.patch Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5183] Update HACKING documentation about topology and map coordinates

2014-09-12 Thread pepeto
Update of patch #5183 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5175] Replace gold_upkeep_style magic values by enumerators/strings

2014-09-12 Thread pepeto
Update of patch #5175 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5174] Replace tech_leakage magic values by enumerators/strings

2014-09-12 Thread pepeto
Update of patch #5174 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5173] Replace tech_cost_style magic values by enumerators/strings

2014-09-12 Thread pepeto
Update of patch #5173 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22589] Player colors memory leak

2014-09-12 Thread pepeto
Follow-up Comment #1, bug #22589 (project freeciv):

A bit more verbose version.


(file #22161)
___

Additional Item Attachment:

File name: playercolor2.patch Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22588] show_ruleset_info() memory leak

2014-09-12 Thread pepeto
Update of bug #22588 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22587] Server player private map memory leak

2014-09-12 Thread pepeto
Update of bug #22587 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22586] Unit types memory leak

2014-09-12 Thread pepeto
Update of bug #22586 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #21038] Can't enter text with some CJK input methods => replace gtk+ DLLs with version >2.24.10

2014-09-12 Thread taka
Follow-up Comment #17, bug #21038 (project freeciv):

The bug has mainly three troubles:

1) Texts disappear 
https://bugzilla.gnome.org/show_bug.cgi?id=668239 (main report)

2) Not activity GtkSpinButton
https://bugzilla.gnome.org/show_bug.cgi?id=674334 (sub report)

3) Can not input any texts
https://bugzilla.gnome.org/show_bug.cgi?id=678414 (sub report)

It seems that bug #22607 is 1) type bug.
For more details, read Bugzilla Bug 668239 (main report).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22583] luascript_func_add_valist() memory leak

2014-09-12 Thread pepeto
Update of bug #22583 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5212] Gtk clients: Merge diplomat_dialog.c and caravan_dialog.c to action_dialog.c

2014-09-12 Thread Sveinung Kvilhaugsvik
Update of patch #5212 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22582] net_lookup_getaddrinfo() memory leak

2014-09-12 Thread pepeto
Update of bug #22582 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22607] Nothing is written on every page in help browser in Japanese locale

2014-09-12 Thread anonymous
Follow-up Comment #5, bug #22607 (project freeciv):

Thank you for your cooperation.

>In Options / Local client / Font, what have you got selected for "Help Text"?
Does changing it make a difference?
I have also tried some fonts, but nothing changed.
Maybe there is no relationship between the type of font and this bug.

>With the Japanese localisation, 2.3.5, 2.4.3, and 2.5.0-beta1 show the
symptom
In addition to ver2.5.0beta1, this bug occurs in all of the version 2.4.0,
2.4.1, 2.4.2, and 2.4.3.

>The only exception I noticed was the help text for individual technologies
I confirmed, too. Only these pages seems to be normal.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22567] AI does not build/buy defenders as enemy approaches

2014-09-12 Thread pepeto
Follow-up Comment #24, bug #22567 (project freeciv):

>> Umh, what else there was in patch #4970 and patch #4971 to
>> explain this? Or do you think it's dormant issue that pf
>> changes activate?
>
> I don't know. I have posted the reverse map (new version) at
> patch #5201. If it really fixes the symptoms, I would say I
> have done a mistake testing without patch #4970 and patch #4971
> (forgot to compile?). 

I have rebuilt an autogame with reverted patch #4970 and patch #4971.
Attaching autosave at turn 800 shows that barbarians nearly invaded all the
world.


(file #22159, file #22160)
___

Additional Item Attachment:

File name: TEST-T0800-Y02375-auto.sav.bz2 Size:87 KB
File name: TEST.serv  Size:0 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22578] Client goto uses erroneous 'transported_by_initially' with waypoints

2014-09-12 Thread pepeto
Update of bug #22578 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5214] SDL clients: Merge diplomat_dialog.c and caravan_dialog.c to action_dialog.c

2014-09-12 Thread Sveinung Kvilhaugsvik
Update of patch #5214 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5194] transport_from_tile() -> unit_could_load_at(), unit_can_load() and transporter_for_unit_at()

2014-09-12 Thread pepeto
Update of patch #5194 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5211] Gtk clients: unit action selection dialog: wait for follow up questions.

2014-09-12 Thread Sveinung Kvilhaugsvik
Update of patch #5211 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22571] Client goto not able to handle move_rate=0, moves_left>0

2014-09-12 Thread pepeto
Update of bug #22571 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22604] The Qt client overwrites server provided target unit in the unit action selection dialog

2014-09-12 Thread Sveinung Kvilhaugsvik
Update of bug #22604 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22610] Can no longer nuke current tile

2014-09-12 Thread pepeto
Update of bug #22610 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #3:

My apologies. Fix attached.


(file #22158)
___

Additional Item Attachment:

File name: client_nuke_now.patch  Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22567] AI does not build/buy defenders as enemy approaches

2014-09-12 Thread pepeto
Follow-up Comment #23, bug #22567 (project freeciv):

> Old pathfinding code used to consider effects of veterancy and
> bonuses (including tile and player specific requirements) to
> the attacker speed. New code just assigns unit type's base
> move_rate.

This is not right. Old pathfinding code for reverse map was ignoring movements
effects. I forgot it in the first implementation. This was one of the higest
reason I did patch #4970.

I forgot however to change the cost adjustment line in
pf_reverse_map_get_costs():

if (cost > param->utype->move_rate) {
  cost = param->utype->move_rate;
}


Another change in patch #4970 is the use of utype->unknown_move_cost when the
map is not known.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5201] pf_reverse_map() improvements

2014-09-12 Thread pepeto
Update of patch #5201 (project freeciv):

  Status:   Need Info => Ready For Test 

___

Follow-up Comment #4:

> I think you're basically reverting an improvement made some
> time ago. Unless something else has changed also, this map is
> not "only for map knowledge", but for any unit movement
> restrictions.
> That includes movement bonuses (Lighthouse etc) and ZoC
> (attacking units of the same owner are not preventing each
> other from moving)

Okay. Agreed (except that pf_reverse_map never used ZoC restrictions, because
ZoC is too flexible due to unit moves, and movement bonuses are already
handled in unit_move_rate()).

However, the map knowledge is still wrong. But because assess_danger() already
take care of units the city owner cannot see, maybe omniscient should be
always set to TRUE in this case. This would also remove the usage of
unknown_move_cost.


(file #22157)
___

Additional Item Attachment:

File name: pf_reverse_map3.patch  Size:20 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22610] Can no longer nuke current tile

2014-09-12 Thread pepeto
Update of bug #22610 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22315] QT client refers to "CMA" rather than "city governor"

2014-09-12 Thread mir3x
Update of bug #22315 (project freeciv):

 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Rest was fixed in patch #5208

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22610] Can no longer nuke current tile

2014-09-12 Thread Jacob Nevins
Follow-up Comment #2, bug #22610 (project freeciv):

I've confirmed that patch #5191 causes this bug; with the previous revision
(S2_4 r26338) it's possible to nuke in place (including your own city, if
you're so inclined).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22610] Can no longer nuke current tile

2014-09-12 Thread Jacob Nevins
Follow-up Comment #1, bug #22610 (project freeciv):

...or maybe caused by patch #5191? (Haven't tested)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5216] Qt-client: locale fix in chat widget

2014-09-12 Thread mir3x
Update of patch #5216 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5215] Qt-client: Updated units report

2014-09-12 Thread mir3x
Update of patch #5215 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5213] Qt-client: Added goto dialog

2014-09-12 Thread mir3x
Update of patch #5213 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev