[Freeciv-Dev] [bug #23011] No Save, Save As, Exit option

[mir3x]

Update of bug #23011 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  
 Planned Release: => 2.5, trunk 

___

Follow-up Comment #1:

Added Save, Save As and Leave Game menus.

(file #23199)
___

Additional Item Attachment:

File name: Qt-SaveMenu.patch  Size:4 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23010] No about dialog

[mir3x]

Update of bug #23010 (project freeciv):

  Status:None => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #2:

Fixed in bug #23009

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23056] civ2civ3: Aifill Inconsistency

[David Fernandez]

Follow-up Comment #1, bug #23056 (project freeciv):

The default setting could be changed to 6, but I think it is not really an
inconsistency. The suggestion of the readme is supposed for new players (first
game with these rules), the same way that it suggests the "cheating" AI level
for experienced players.

Most of my tests with the AI were done with 12 players and "normal" level, and
I like the variety of maps created with this size.

I like to play with 6 players too, but the small maps are too predictable, and
I find these games too easy (unless I place them all in the same team).

I guess it depends if you want the default setting to be aimed for new players
or for average players.
However, I'd be interested to know how many players do other people like to
play.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5543] civ2civ3: Crusaders no longer cause military unhappiness

[Sveinung Kvilhaugsvik]

Update of patch #5543 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23052] "Fallout" appear as a category in Qt client help

[mir3x]

Update of bug #23052 (project freeciv):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5564] civ2civ3: backport some terrain effects

[David Fernandez]

URL:
  

 Summary: civ2civ3: backport some terrain effects
 Project: Freeciv
Submitted by: bardo
Submitted on: Mon 15 Dec 2014 01:28:13 PM UTC
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

It is a patch for S2_5 to add some terrain changes from trunk that I find
important for game balance:
- Allowed early transformation from Forest to Grassland, so it is possible to
transform Grass->Forest->Plain, and also Plain->Forest->Grass, with same
working time (25).
- Harbors and Offshore Platform can be built adjacent to any oceanic tile
again (same as classic rules), so Global warming does not affect them.
- Restored Food output of Deep oceans, so Global warming does not affect
Oceans that much. Now oceans transformed to deep ocean would only lose their
specials.
- Reduced irrigation times in Swamps. They represent the drainage of
wetlands.

I have verified that it does not cause troubles when you load an old savegame
where workers are performing those affected alterations.

I have not included the changes to terrain transformations by global warming,
nuclear winter, nor those available with Fusion power. I'm still testing those
in trunk, and I think the ones in current v2.5 are good enough.



___

File Attachments:


---
Date: Mon 15 Dec 2014 01:28:13 PM UTC  Name: civ2civ3-terrain_work-S2_5.patch 
Size: 7kB   By: bardo



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5554] Add a unit type role for each action after the unit flags and roles.

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, patch #5554 (project freeciv):

I'm not sure if I understand exactly what you are suggesting. I therefore
can't answer your question truthfully. What I can do is to explain the
reasoning behind this patch while keeping various possible interpretations of
your suggestion in mind. I hope that parts of what follows will address at
least some of you concerns.

The built in AI currently uses the role system to ask for a unit with a
certain unit flag when it really wants a unit that can do an action associated
with the flag. It assumes that all units with that flag are capable of
performing the action. Note that it cares about the action it self, not what
particular action enabler(s) make it possible.

The motivation behind this patch is to allow follow up patches that makes the
AI look for the ability to perform the wanted action in stead of looking for
flags like "TradeRoute" and "HelpWonder".

How an action behaves is independent of what action enabler(s) makes it legal.
Generalized actions aren't planned to change that. The difference in action
behavior will depend on the generalized action it self, not on the action
enabler(s) that make it legal.

Actions aren't generalized in 2.6. The number of actions is therefore
constant. This patch creates a unit role (located after the unit role flags
that are located after the real unit type flags) for each action.

The advantage of creating a unit role is that the existing unit role system
can be reused. Storing information about what units can perform it to the
action structure would enable less reuse. (A disadvantage of reusing the role
system is that action specific custom functionality becomes more difficult. If
many action specific customizations are wanted it would make a separate system
more appealing)

Automatically creating the role in stead of requiring it to be defined in the
ruleset (or added to the unit role enum) creates less work. It also makes the
role to ask for in cases when a unit capable of performing action X is wanted
known. (Generalized actions will require a way to find an action to look for.
Probably some action flag. It is therefore like associating a unit flag with
an action)

Using unit type flags to grant permissions to do a (set of) action(s) (under
certain circumstances) should probably be the recommended style in the
documentation. It makes it possible to continue thinking about the ability to
do an action as a flag. In many cases it will also increase order. But
enforcing it would make other cases more complex.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5564] civ2civ3: backport some terrain effects

[David Fernandez]

Follow-up Comment #1, patch #5564 (project freeciv):

For reference, this is a port of patch #4806

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5544] civ2civ3: backport changes from trunk to S2_5

[David Fernandez]

Follow-up Comment #3, patch #5544 (project freeciv):

For reference, this a port of patch #4965 and patch #4811.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5308] Compatibility mode for ruleset loading

[Sveinung Kvilhaugsvik]

Follow-up Comment #1, patch #5308 (project freeciv):

Just thinking out loud here: What about making compat_mode carry information
about the version to be compatible with? (Say, an enum starting with something
like RULECOMPAT_OFF followed by versions) This would allow adding old hard
coded rules that moved to the ruleset between versions without adding them to
rulesets that have removed them.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5308] Compatibility mode for ruleset loading

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, patch #5308 (project freeciv):

_What about making compat_mode carry information about the version to be
compatible with?_
That was assuming we want a higher resolution than what is provided by ruleset
capabilities. Considering how we don't even have a that high resolution for
save games I withdraw the suggestion.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5565] Replace packet variant process by function pointers

[pepeto]

URL:
  

 Summary: Replace packet variant process by function pointers
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:03:52 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

This patch removes the usage of switch statements to access to
send_packet_XXX_100() and receive_packet_XXX_100() functions. Instead, it use
array of function pointers to access to the functions directly. A hash table
based on network capabilities is used to limit the number of initializations
of the function arrays.

Also, make different how cs/sc restrictions are handled.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:03:52 CET  Name: packet_variants.patch  Size: 22
ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5566] Remove get_packet_from_connection_helper() and receive_packet_XXX() functions

[pepeto]

URL:
  

 Summary: Remove get_packet_from_connection_helper() and
receive_packet_XXX() functions
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:08:54 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

After applying patch #5565, it becomes easy to remove the huge switch
statement represented by get_packet_from_connection_helper().

In addition, fix potential usage of out of bounds memory when packet
statistics are enabled.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:08:54 CET  Name: get_packet_from_connection.patch 
Size: 5 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5567] Remove switch statement in packet_name()

[pepeto]

URL:
  

 Summary: Remove switch statement in packet_name()
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:10:01 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Replace it by an array of strings.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:10:01 CET  Name: packet_name.patch  Size: 1 ko  
By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5568] Remove usage of switch statement in packet_has_game_info_flag()

[pepeto]

URL:
  

 Summary: Remove usage of switch statement in
packet_has_game_info_flag()
 Project: Freeciv
Submitted by: pepeto
Submitted on: lun. 15 déc. 2014 16:11:48 CET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: pepeto
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Replace it by an array of booleans.




___

File Attachments:


---
Date: lun. 15 déc. 2014 16:11:48 CET  Name: packet_has_game_info_flag.patch 
Size: 1 ko   By: pepeto



___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5566] Remove get_packet_from_connection_helper() and receive_packet_XXX() functions

[pepeto]

Update of patch #5566 (project freeciv):

  Depends on: => patch #5565


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

[pepeto]

Update of patch #4949 (project freeciv):

  Depends on: => patch #5565


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

[pepeto]

Update of patch #4949 (project freeciv):

  Depends on: => patch #5567


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

[pepeto]

Update of patch #4949 (project freeciv):

  Depends on: => patch #5568


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4949] [Metaticket] Get rid of massive switch-cases

[pepeto]

Update of patch #4949 (project freeciv):

  Depends on: => patch #5566


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5569] Put the rule that only domestic wonder building can receive help in the ruleset.

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Put the rule that only domestic wonder building can
receive help in the ruleset.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 15 Dec 2014 05:19:02 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

The restriction against helping foreign wonders is add to the Help Wonder
action of all rulesets.

The AI won't help other players build a wonder. ()



___

File Attachments:


---
Date: Mon 15 Dec 2014 05:19:02 PM UTC  Name:
0001-Put-the-rule-that-only-domestic-wonder-building-can-.patch  Size: 8kB  
By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5487] Start positions for earth scenarios

[David Fernandez]

Follow-up Comment #8, patch #5487 (project freeciv):

I like the idea. I'll try to add some tile labels to these 2 earth maps.
Should I add generic names like Pacific Ocean, Gobi Desert, and Alps. Or
specific places like Everest, Niagara Falls or Lake Titicaca?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5570] Clean up: Remove the unused variable caravan_arrival_queue

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Clean up: Remove the unused variable
caravan_arrival_queue
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 15 Dec 2014 06:57:10 PM UTC
Category: client
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

that should have been removed as a part of patch #5482.



___

File Attachments:


---
Date: Mon 15 Dec 2014 06:57:10 PM UTC  Name:
0001-Clean-up-Remove-the-unused-variable-caravan_arrival_.patch  Size: 1kB  
By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23044] City size 1 , citizen count 2 for [city_name]. Error message.

[Jarkko Huttunen]

Follow-up Comment #2, bug #23044 (project freeciv):

I'm using alternate movement (phasemode = PLAYER), So problem is apparently
there.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23022] GTK2 Client crash when resize or move dialogs

[Jarkko Huttunen]

Follow-up Comment #11, bug #23022 (project freeciv):

"This error does not occur with Freeciv-2.5.0-beta2-win32-gtk2 on a 32 bit
windows XP."

I have same system and version and it crashes when moving dialogs on other
players turn. Not on your own turn.
"Program has done illegal operation and has to be terminated"

Might not be exactly like this but you know that message. (Translated from
finnish).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22744] experimental ruleset: size 1 cities dissolve very often

[Jarkko Huttunen]

Follow-up Comment #4, bug #22744 (project freeciv):

These thoughts about how migration should work are quite right,
I'd like to add.

5. When people migrate short distances, migration should favor bigger cities.
They have tendency collect people of the surrounding countryside and towns.

6. Threshold for migration should drop as cities grow, that way it would allow
mass migration on certain times.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5487] Start positions for earth scenarios

[David Fernandez]

Follow-up Comment #9, patch #5487 (project freeciv):

I answer my own question... I'm adding those considered "natural wonders" like
Angel Falls, Uluru, Kilimanjaro, Grand Canyon, etc

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21710] Add inspirational descriptions or quotes to each technology in ruleset

[Jarkko Huttunen]

Follow-up Comment #4, bug #21710 (project freeciv):

This should be implemented to later releases. Civ2 type entry for new
discoveries would make following the advancement of your civilization, and so
the gameplay, much easier and intriguing.

Generic "discovered x researching y goal is z" - messages feel total
understatements with advances.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23007] Encoding problems in city names

[mir3x]

Update of bug #23007 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  
 Planned Release: => 2.5, trunk 

___

Follow-up Comment #2:

Fixed

(file #23207)
___

Additional Item Attachment:

File name: Qt-Windows-Locale.patchSize:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5571] Allow the client to select what target to get action probabilities for.

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Allow the client to select what target to get action
probabilities for.
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 15 Dec 2014 09:17:31 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Use this to make sure that the targets won't accidentally change when the
client requests an update to an open action selection dialog.

Remember to update the network cap string



___

File Attachments:


---
Date: Mon 15 Dec 2014 09:17:31 PM UTC  Name:
0001-Allow-the-client-to-select-what-target-to-get-action.patch  Size: 4kB  
By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5535] Rename "refugee" gfx tag as "migrants"

[Marko Lindqvist]

Update of patch #5535 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23088] Action selection dialog: Same mnemonic used for more than one action

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Action selection dialog: Same mnemonic used for more
than one action
 Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 15 Dec 2014 09:26:29 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

b Bribe Enemy Unit, Help build Wonder
e Establish Embassy
g Steal Gold
i Investigate City
m Enter Marketplace
p Poison City
r Incite a Revolt, Establish Trade Route
s Sabotage Enemy Unit, Sabotage City, Industrial Sabotage, Industrial
Espionage
t Steal Technology






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23088] Action selection dialog: Same mnemonic used for more than one action

[Sveinung Kvilhaugsvik]

Update of bug #23088 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5506] Remove --eventthread commandline option completely

[Marko Lindqvist]

Follow-up Comment #1, patch #5506 (project freeciv):

Updated against svn HEAD

(file #23209)
___

Additional Item Attachment:

File name: EventthreadOptionRm-2.patchSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23068] Segmentation fault when starting scenario in generate_players()

[Marko Lindqvist]

Update of bug #23068 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5547] Set cairo filter for all scaled operations

[Marko Lindqvist]

Update of patch #5547 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23064] package_and_send_worker_task() sets wrong value for NULL target

[Marko Lindqvist]

Update of bug #23064 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23088] Action selection dialog: Same mnemonic used for more than one action

[Sveinung Kvilhaugsvik]

Update of bug #23088 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Attached patch assigns the following mnemonics so each action have its own
even if a ruleset allows some unit to do all action enabler controlled actions
at once:
a Sabotage Enemy Unit
b Help build Wonder
c Incite a Revolt
d Industrial Espionage
e Establish Embassy
g Steal Gold
i Investigate City
l Industrial Sabotage
m Enter Marketplace
p Poison City
r Establish Trade Route
s Sabotage City
t Steal Technology
u Bribe Enemy Unit

I am extremely open to change what action have what mnemonic.

Would it be acceptable to keep patch #4582 targeted at 2.6? By using it the
mnemonic moves to the ruleset with the name. Mnemonic collisions between
actions that won't be enabled at the same time won't matter then.

(file #23210)
___

Additional Item Attachment:

File name: 0001-Give-some-action-UI-names-new-mnemonics-to-make-each.patch
Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23088] Action selection dialog: Same mnemonic used for more than one action

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, bug #23088 (project freeciv):

Give "Incite a Revolt" v to avoid colliding with the Gtk client's cancel
button.

v Incite a Revolt

(file #23211)
___

Additional Item Attachment:

File name: 0001-Give-some-action-UI-names-new-mnemonics-to-make-each.patch
Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20772] City dialog unit lists too short vertically if unpopulated, don't grow if a unit is added

[Marko Lindqvist]

Update of bug #20772 (project freeciv):

  Status:None => Ready For Test 
 Planned Release:   2.5.0 => 2.4.5, 2.5.0, 2.6.0

___

Follow-up Comment #2:

Fixes attached.

Use gtk_widget_set_size_request() on table inside the scrolled window, not
gtk_scrolled_window_set_min_content_height() on scrolled window itself. While
this is not explicitly setting constant height, it sets minimum height, and
I'm not aware of any situation where it would expand to size bigger than
that.
Also use unit height and not terrain tile height.

I also tested setting vexpand for the scrolled windows, but that gave less
good results when one of the windows is populated and the other is not - they
would only divide remaining space once populated one has already taken space
it needs, meaning it gets much higher than the unpopulated one.

(file #23212, file #23213)
___

Additional Item Attachment:

File name: CitydlgUnitHeight.patchSize:1 KB
File name: CitydlgUnitHeight-S2_5.patch   Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4997] [Metaticket] Get rid of action_enabler_append_hard()

[Sveinung Kvilhaugsvik]

Update of patch #4997 (project freeciv):

  Depends on: => patch #5569


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5572] Maximum citymindist 11

[Marko Lindqvist]

URL:
  

 Summary: Maximum citymindist 11
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 01:12:56 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Requested by GriffonSpade at forums:
http://forum.freeciv.org/f/viewtopic.php?f=13&t=51&start=30



___

File Attachments:


---
Date: Tue 16 Dec 2014 01:12:56 AM EET  Name: MaxCitymindist11.patch  Size:
498B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5573] Update README.nations for new styles system

[Marko Lindqvist]

URL:
  

 Summary: Update README.nations for new styles system
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 01:24:07 AM EET
Category: docs
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Update README.nations City Styles chapter to match National Styles code.



___

File Attachments:


---
Date: Tue 16 Dec 2014 01:24:07 AM EET  Name: READMEStyles.patch  Size: 1kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5574] Barbarian Leader escape to ruleset

[Marko Lindqvist]

URL:
  

 Summary: Barbarian Leader escape to ruleset
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 01:42:14 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Ruleset format already supports everything needed to implement barbarian
leader escape rule. Remove the hardcoded rule, and implement it to all
supplied rulesets instead.



___

File Attachments:


---
Date: Tue 16 Dec 2014 01:42:14 AM EET  Name: RulesetEscape.patch  Size: 7kB  
By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23039] "… can't build Settlers yet."

[Sveinung Kvilhaugsvik]

Update of bug #23039 (project freeciv):

  Status:None => In Progress
 Assigned to:None => sveinung   

___

Follow-up Comment #1:

Thank you for testing the 2.5 beta.

_Is this a bug, or is civ2civ3 significantly different in this area?_
A civ2civ3 settler has a population cost of 2. Unless you wish to spend the
entire population of a size 2 city you must wait until it grows.

_The in game help does say that a Settler can be built at size 2._
I can see that "requires 2 population to be built" can be understood that way.
Maybe it should be clarified that it refers to cost?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5575] Windows menu entry for ruledit

[Marko Lindqvist]

URL:
  

 Summary: Windows menu entry for ruledit
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 01:56:49 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add menu entry for ruledit in Windows. Ruledit is currently only available
bundled in Qt-client package.



___

File Attachments:


---
Date: Tue 16 Dec 2014 01:56:49 AM EET  Name: RuleditWinInstaller.patch  Size:
3kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23039] "… can't build Settlers yet."

[Sveinung Kvilhaugsvik]

Follow-up Comment #2, bug #23039 (project freeciv):

_I can see that "requires 2 population to be built" can be understood that
way. Maybe it should be clarified that it refers to cost?_
Attached patch changes it to "Costs %d population to build". Any native
English speaker that can comment on how correct his is?

(file #23218)
___

Additional Item Attachment:

File name: 0001-Help-Specify-that-population-cost-is-the-price-payed.patch
Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5576] Deinitialize nls

[Marko Lindqvist]

URL:
  

 Summary: Deinitialize nls
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 03:07:59 AM EET
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

Add missing free_nls() call to freeciv-ruledit. Also adjust order of
initializations and deinitializations to match other programs.



___

File Attachments:


---
Date: Tue 16 Dec 2014 03:07:59 AM EET  Name: RuleditFreeNls.patch  Size: 645B 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23089] fc_client::init() lacking function header

[Marko Lindqvist]

URL:
  

 Summary: fc_client::init() lacking function header
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 03:26:44 AM EET
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

CodingStyle allows no new code (and Qt-client in its entirety counts as new
code) to add functions without function headers.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23090] Setting ruledit window title often crashes

[Marko Lindqvist]

URL:
  

 Summary: Setting ruledit window title often crashes
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 03:36:08 AM EET
Category: freeciv-ruledit
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0

___

Details:

Explicit conversion from const char * to const QString seems to help, as in
attached fix.



___

File Attachments:


---
Date: Tue 16 Dec 2014 03:36:08 AM EET  Name: RuleditWindowTitle.patch  Size:
615B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4160] Gfx for Inaccessible terrain

[Marko Lindqvist]

Follow-up Comment #5, patch #4160 (project freeciv):

Inaccessible terrain for trident. Art by The Square Cow on forum:
http://forum.freeciv.org/f/viewtopic.php?f=12&t=477

Consider inspection period for these started.

(file #23221, file #23222)
___

Additional Item Attachment:

File name: TridentInaccessible.patch  Size:1 KB
File name: inacc_tiles.pngSize:123 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23091] Hexemplio base icons vertically misaligned in editor

[Marko Lindqvist]

URL:
  

 Summary: Hexemplio base icons vertically misaligned in editor
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 04:16:35 AM EET
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Probably new city_offset is not correctly applied there.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3351] Allow rulesets to override the default helpdata.txt?

[Marko Lindqvist]

Follow-up Comment #2, patch #3351 (project freeciv):

We have still not started doing anything about this. Is this soemthing we
implement for 2.6 in stable S2_6 branch, or do we postpone it to 3.0?

> for any ruleset that departs radically from the norm.
This could be considered dependency for release-quality alien ruleset. Also
the other way around, use of this probably needs to be demonstrated with alien
ruleset before it gets other users. The alien ruleset has already been
postponed to 3.0.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5577] Flag for "Animal Kingdom" nation

[Marko Lindqvist]

URL:
  

 Summary: Flag for "Animal Kingdom" nation
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 05:27:21 AM EET
Category: art
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4690] [Metaticket] Art required for 2.6

[Marko Lindqvist]

Update of patch #4690 (project freeciv):

  Depends on: => patch #5577


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5027] Fort and Airstrip graphics for Amplio2/Cimpletoon/Hexemplio/Toonhex

[Marko Lindqvist]

Update of patch #5027 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 
 Summary: Trench and Airfield graphics => Fort and Airstrip
graphics for Amplio2/Cimpletoon/Hexemplio/Toonhex


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5578] Fort and Airstrip graphics for Trident

[Marko Lindqvist]

URL:
  

 Summary: Fort and Airstrip graphics for Trident
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 05:34:06 AM EET
Category: art
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

civ2civ3 pre-bases Fort and Airtstip need gfx in all supported tilesets.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4690] [Metaticket] Art required for 2.6

[Marko Lindqvist]

Update of patch #4690 (project freeciv):

  Depends on: => patch #5578


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5013] Maglev graphics for all supplied tilesets

[Marko Lindqvist]

Follow-up Comment #1, patch #5013 (project freeciv):

Patches for Amplio. In addition to these textfile patches, maglev.png should
be copied from amplio2/ to amplio/

Consider inspection period started.

Once new files are added to amplio in version control, also .modpack file on
the modpack server should be updated to install the new files.

(file #23223, file #23224)
___

Additional Item Attachment:

File name: AmplioMaglev.patch Size:1 KB
File name: AmplioMaglev-S2_5.patchSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #5579] Remove amplio Makefile.am from version control

[Marko Lindqvist]

URL:
  

 Summary: Remove amplio Makefile.am from version control
 Project: Freeciv
Submitted by: cazfi
Submitted on: Tue 16 Dec 2014 06:25:44 AM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.5, 2.5.0, 2.6.0

___

Details:

As amplio is no longer part of tarball, its Makefile.am is obsolete and only
confusing people (it's probably also outdated). Remove it from under version
control.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev