[Freeciv-Dev] [patch #5738] FREECIV_JSON_CONNECTION
URL: http://gna.org/patch/?5738 Summary: FREECIV_JSON_CONNECTION Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 09:59:34 PM EET Category: bootstrap Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0, 3.0.0 ___ Details: Make JSON_CONNECTION macro available from public freeciv_config.h header and rename it as FREECIV_JSON_CONNECTION ___ File Attachments: --- Date: Wed 21 Jan 2015 09:59:34 PM EET Name: FreecivJsonConnection.patch Size: 2kB By: cazfi http://gna.org/patch/download.php?file_id=23573 ___ Reply to this item at: http://gna.org/patch/?5738 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5737] dataio_json.[ch] packets_json.[ch]
URL: http://gna.org/patch/?5737 Summary: dataio_json.[ch] packets_json.[ch] Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 09:29:47 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: Add initial versions of json-protocol files. To understand what this contains, it's good to know how it was created: 1) Current freeciv sources were patched by freeciv-web protocol changes (making it to use json-protocol) 2) Copied patched dataio.[ch] and packets.[ch] as _json.[ch] versions and restored plain version of the original files 3) Cleaned up a bit made to compile separately from other freeciv-web changes ___ File Attachments: --- Date: Wed 21 Jan 2015 09:29:47 PM EET Name: DataioJson.patch.bz2 Size: 13kB By: cazfi http://gna.org/patch/download.php?file_id=23572 ___ Reply to this item at: http://gna.org/patch/?5737 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5233] Client goto turn number
Follow-up Comment #12, patch #5233 (project freeciv): You might notice I have no more time free to coding Freeciv nowadays. I have kept 4 tickets that I have started to work on. However, you may steal them. ___ Reply to this item at: http://gna.org/patch/?5233 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23205] civ2civ3: free building upkeep under communism should not be cumulative
Update of bug #23205 (project freeciv): Status:None = Ready For Test Assigned to:None = sveinung Release: = TRUNK, 2.6, 2.5 Planned Release: = 3.0.0, 2.6.0, 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?23205 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23206] civ2civ3: Sun Tzu wonder too powerful now that it is cumulative to barracks
URL: http://gna.org/bugs/?23206 Summary: civ2civ3: Sun Tzu wonder too powerful now that it is cumulative to barracks Project: Freeciv Submitted by: bardo Submitted on: mié 21 ene 2015 16:26:42 UTC Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Now that the extra veteran level of Sun Tzu's War Academy is summed to the barracks, I find this wonder a bit overpowered. I think the easiest solution, that I'd vote to include in v2.5 if possible, is to remove the 2nd effect of the wonder: the extra chances of getting the next veteran level in combat. It would also prevent the problem of being cumulative to the same bonus from Tribal government. ___ File Attachments: --- Date: mié 21 ene 2015 16:26:42 UTC Name: civ2civ3-suntzu_veteran-Trunk.patch Size: 2kB By: bardo http://gna.org/bugs/download.php?file_id=23570 --- Date: mié 21 ene 2015 16:26:42 UTC Name: civ2civ3-suntzu_veteran-S2_5.patch Size: 2kB By: bardo http://gna.org/bugs/download.php?file_id=23571 ___ Reply to this item at: http://gna.org/bugs/?23206 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23205] civ2civ3: free building upkeep under communism should not be cumulative
URL: http://gna.org/bugs/?23205 Summary: civ2civ3: free building upkeep under communism should not be cumulative Project: Freeciv Submitted by: bardo Submitted on: mié 21 ene 2015 15:38:17 UTC Category: rulesets Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: The wonder A.Smith's Trading Co. and the government Communism grant a similar bonus: free upkeep for buildings that cost 1 gold. The wonder was supposed to be useless under Communism, but the way I implemented it, both effects are summed, so buildings with cost 2 become free of upkeep too. This patch prevents both effects from being cumulative. ___ File Attachments: --- Date: mié 21 ene 2015 15:38:17 UTC Name: civ2civ3-upkeep_free-Trunk.patch Size: 626B By: bardo http://gna.org/bugs/download.php?file_id=23568 --- Date: mié 21 ene 2015 15:38:17 UTC Name: civ2civ3-upkeep_free-S2_5.patch Size: 469B By: bardo http://gna.org/bugs/download.php?file_id=23569 ___ Reply to this item at: http://gna.org/bugs/?23205 ___ Mensaje enviado vía/por Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Update of patch #5736 (project freeciv): Status: Ready For Test = In Progress Planned Release: 2.5.0, 2.6.0, 3.0.0 = 2.5.1, 2.6.0, 3.0.0 ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5740] Free future tech name strings on exit
URL: http://gna.org/patch/?5740 Summary: Free future tech name strings on exit Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 11:52:02 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: bug #23173 took care of freeing future tech names vector. It failed to free the individual elements. This patch does that. ___ File Attachments: --- Date: Wed 21 Jan 2015 11:52:02 PM EET Name: FutureStringsFree.patch Size: 806B By: cazfi http://gna.org/patch/download.php?file_id=23577 --- Date: Wed 21 Jan 2015 11:52:02 PM EET Name: FutureStringsFree-S2_5.patch Size: 732B By: cazfi http://gna.org/patch/download.php?file_id=23578 ___ Reply to this item at: http://gna.org/patch/?5740 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23195] create_string16() can return pointer to freed memory
Update of bug #23195 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23195 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5739] Log failure to save game
URL: http://gna.org/patch/?5739 Summary: Log failure to save game Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 11:20:22 PM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: Do not print error about failure to save a game to console only, but log the incident too, with related secfile_error(). ___ File Attachments: --- Date: Wed 21 Jan 2015 11:20:22 PM EET Name: LogSaveFailure.patch Size: 554B By: cazfi http://gna.org/patch/download.php?file_id=23574 ___ Reply to this item at: http://gna.org/patch/?5739 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23197] HOWTOPLAY uses numerical values for generator settings
Update of bug #23197 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23197 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23208] fz_File structure for xz-compressed files not freed
URL: http://gna.org/bugs/?23208 Summary: fz_File structure for xz-compressed files not freed Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 11:25:11 PM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: fz_fclose() does not free fz_File in case of xz-compressed files. Fix attached. ___ File Attachments: --- Date: Wed 21 Jan 2015 11:25:11 PM EET Name: XzFcloseFree.patch Size: 381B By: cazfi http://gna.org/bugs/download.php?file_id=23575 ___ Reply to this item at: http://gna.org/bugs/?23208 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23209] create_command() does not free argument tokenization
URL: http://gna.org/bugs/?23209 Summary: create_command() does not free argument tokenization Project: Freeciv Submitted by: cazfi Submitted on: Wed 21 Jan 2015 11:35:39 PM EET Category: general Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: create_command() does not free tokens it allocates with get_tokens(). Fix attached. ___ File Attachments: --- Date: Wed 21 Jan 2015 11:35:39 PM EET Name: FreeCreateTokens.patch Size: 647B By: cazfi http://gna.org/bugs/download.php?file_id=23576 ___ Reply to this item at: http://gna.org/bugs/?23209 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5722] Remove gtk-client (1.2) from agents/ include path
Update of patch #5722 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5722 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5721] DejaGNU test harness for common client code
Follow-up Comment #1, patch #5721 (project freeciv): What kind of plan you have about updating this to current freeciv development version? 2.4 is quite old in that respect (2.5 is about to release, 2.6 is in stable branch already, feature development is targeting 3.0) It might be worth taking a new copy of stub client as a base and port your changes to that rather than trying to update your existing console-client. ___ Reply to this item at: http://gna.org/patch/?5721 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5737] dataio_json.[ch] packets_json.[ch]
Follow-up Comment #1, patch #5737 (project freeciv): Nice work cazfi, this looks good! ___ Reply to this item at: http://gna.org/patch/?5737 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22884] Finished worker task not removed from the city
Update of bug #22884 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #1: Attached patch clears worker task from the city as soon as a worker starts working on it. (file #23580) ___ Additional Item Attachment: File name: ClearWorkerTasks.patch Size:8 KB ___ Reply to this item at: http://gna.org/bugs/?22884 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5741] Free listen socks list on exit
URL: http://gna.org/patch/?5741 Summary: Free listen socks list on exit Project: Freeciv Submitted by: cazfi Submitted on: Thu 22 Jan 2015 01:22:41 AM EET Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.5, 2.5.0, 2.6.0, 3.0.0 ___ Details: Free listen socks list on server exit to clear one more valgrind report. ___ File Attachments: --- Date: Thu 22 Jan 2015 01:22:41 AM EET Name: ListenSocksFree.patch Size: 406B By: cazfi http://gna.org/patch/download.php?file_id=23579 ___ Reply to this item at: http://gna.org/patch/?5741 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5724] Do not cache value of ACTIVITY_IRRIGATE (or ACTIVITY_MINE) in targeted form
Update of patch #5724 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5724 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21475] Text background problems with gtk2 =2.24.21
Follow-up Comment #17, bug #21475 (project freeciv): From the gtk+-2.24.21 NEWS, the suspicios bugfix is https://bugzilla.gnome.org/show_bug.cgi?id=695636 . It touches windows specific code, and has been reported to cause rendering problems for some users. One attached screenshot shows problem very similar to ours. I'll try to do crosser build with that commit reverted. ___ Reply to this item at: http://gna.org/bugs/?21475 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #21475] Text background problems with gtk2 =2.24.21
Follow-up Comment #18, bug #21475 (project freeciv): Hence this is not a gtk2 bug but is merely an error in the freeciv theme stylesheet. Err... you can't deduct that from the fact that a theme that seem to have no background image set at all has no problems. It's still gtk-bug even if you can avoid it by not using the buggy (theming) feature. ___ Reply to this item at: http://gna.org/bugs/?21475 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5652] Drop effect nreqs compatibility support
Update of patch #5652 (project freeciv): Status: Ready For Test = Done Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5652 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5729] Protocol: Get rid of the unit_move packet.
Follow-up Comment #4, patch #5729 (project freeciv): Oh, right. It's used only from client to server and not to the other direction. Sorry for the noise. One wonders how much it would help if there *was* a specialized packet (unit id + tile id + facing direction + moves left) for the most common unit change server sends to the clients. Delta protocol of course helps with bandwith of current setup, but it still needs to send, and process, the delta bits for all the fields. ___ Reply to this item at: http://gna.org/patch/?5729 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #22993] Cancel treaty and Withdraw vision buttons sensitive for team mates
Update of bug #22993 (project freeciv): Status:None = Ready For Test Planned Release:2.5.0, 2.6.0 = 2.5.0, 2.6.0, 3.0.0 ___ Follow-up Comment #1: Fixes for gtk2-, gtk3-, qt-, sdl-, and sdl2-clients. (file #23581, file #23582) ___ Additional Item Attachment: File name: TeamWithdrawSensitivity.patch Size:4 KB File name: TeamWithdrawSensitivity-S2_5.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?22993 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23210] Can't withdraw vision during war
URL: http://gna.org/bugs/?23210 Summary: Can't withdraw vision during war Project: Freeciv Submitted by: cazfi Submitted on: Thu 22 Jan 2015 04:09:12 AM EET Category: client-sdl2 Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: ___ Details: Reading the source code (not tested): sdl-client's check that players are not already in war before adding buttons for Cancelling Treaty. The bug is that also Withdraw Vision button is handled within that block guarded by the not-in-war check. So if you end to a war with someone you shared vision with, there's no way for you to withdraw the vision (I'm assuming it doesn't happen automatically when war is declared) ___ Reply to this item at: http://gna.org/bugs/?23210 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5233] Client goto turn number
Follow-up Comment #11, patch #5233 (project freeciv): Is there any reason this couldn't go to 2.6 other than lack of available effort? I'd quite like to see it get in. Mind if I steal it, if I get time? I think it's basically working? ___ Reply to this item at: http://gna.org/patch/?5233 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #20598] Something funny with Ready checkboxes in pregame screen
Follow-up Comment #5, bug #20598 (project freeciv): I believe I was still seeing it on Xubuntu 12.04 right up until I upgraded a couple of weeks ago. I no longer see it on Xubuntu 14.04. It might be down to an ancient Gtk3 version, although given it's theme-specific the interaction could be more complex and the bug still latent. ___ Reply to this item at: http://gna.org/bugs/?20598 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5729] Protocol: Get rid of the unit_move packet.
Follow-up Comment #2, patch #5729 (project freeciv): See patch #4804 for another (unimplemented) idea about changing the UNIT_MOVE packet. ___ Reply to this item at: http://gna.org/patch/?5729 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4804] Unify UNIT_MOVE and UNIT_LOAD packets, allowing transfer onto specific transport on adjacent tile
Follow-up Comment #2, patch #4804 (project freeciv): Need to remember that UNIT_MOVE is a frequently used packet and shouldn't be bloated too much. ___ Reply to this item at: http://gna.org/patch/?4804 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23202] Action probability for capture units is always 0, 5%
Update of bug #23202 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23202 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5728] make request_new_unit_activity() wrap request_new_unit_activity_targeted()
Update of patch #5728 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5728 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5719] Add missing translation comment on ui_name_sabotage_unit default
Update of patch #5719 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?5719 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5729] Protocol: Get rid of the unit_move packet.
Update of patch #5729 (project freeciv): Status: Ready For Test = Need Info ___ Follow-up Comment #3: _How this affects bandwidth usage?_ Each keypad move becomes about 3 times as large. (The length of the order sent is always 1) For *total* bandwith this is insignificant. Server to client is a lot larger than client to server. (Some connections have more bandwith in one direction than the other) _You replace one of the most often sent packages_ We have a subset of players that move their units with the keypad more often than they move them via goto? ___ Reply to this item at: http://gna.org/patch/?5729 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
