[Freeciv-Dev] [patch #5913] json protocol: Handle multiple packets in buffer -case
Follow-up Comment #1, patch #5913 (project freeciv): I just tested this patch by applying it to the latest version of Freeciv-web from github. After applying the patch, no packets could be sent to or from the Freeciv server, so it is not possible start any games when the patch is applied. Please test the patch in a full Freeciv-web installation. In general I support the effort of improving connection reliability of JSON based connections, however, it needs to work with Freeciv-web as well. Also noting here that I think that embedding Libwebsockets is the long-term solution, see bug #23283. ___ Reply to this item at: http://gna.org/patch/?5913 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5913] json protocol: Handle multiple packets in buffer -case
Follow-up Comment #2, patch #5913 (project freeciv): I don't fully undestand the patch, but it could be that the patch is correct, but that it requires some changes in Freeciv-proxy. The patch needs more testing. ___ Reply to this item at: http://gna.org/patch/?5913 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16506] Option missing to disable ZOC imposed by units (e.g., Freight, Caravan)
Follow-up Comment #14, bug #16506 (project freeciv): Can this please be backmerged to 2.5? Unfortunately not. Absolutely not because it would violate custom ruleset format freeze of a stable series (and to some extend also network protocol freeze). Not practically since it's not an single change to backport, but it depends on other rework (I think quite a many small details would need to be changed, rather than big refactoring of one part of the code) ___ Reply to this item at: http://gna.org/bugs/?16506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5922] rscompat: Remove redundant action enabler requirement vector initialization.
URL: http://gna.org/patch/?5922 Summary: rscompat: Remove redundant action enabler requirement vector initialization. Project: Freeciv Submitted by: sveinung Submitted on: Sun 08 Mar 2015 09:16:32 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: Action enabler requirement vector initialization is already done in action_enabler_new(). There is no need to do it by hand while adding compatibility action enablers. ___ File Attachments: --- Date: Sun 08 Mar 2015 09:16:32 PM UTC Name: 0001-rscompat-Remove-redundant-action-enabler-requirement.patch Size: 2kB By: sveinung http://gna.org/patch/download.php?file_id=24035 ___ Reply to this item at: http://gna.org/patch/?5922 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16506] Option missing to disable ZOC imposed by units (e.g., Freight, Caravan)
Follow-up Comment #13, bug #16506 (project freeciv): Can this please be backmerged to 2.5? Really stupid when a single explorer wanders into your land and prevents you from using roads... ___ Reply to this item at: http://gna.org/bugs/?16506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #15641] text not rendered when cross-compiling
Update of bug #15641 (project freeciv): Category: client-sdl = general Status:None = Ready For Test Planned Release: = 3.0.0 ___ Follow-up Comment #1: While I don't think we currently support any system where runtime endianness check would be needed, it's probably a good idea to have the logic for it in just one place in case it will be needed in the future. Attached patch adds inline is_bigendian() that always, for a given build, returns the same value. Any compiler knows to optimize it away, along with never-true branches when it's used as a guard. (file #24021) ___ Additional Item Attachment: File name: IsBigendian.patch Size:15 KB ___ Reply to this item at: http://gna.org/bugs/?15641 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #14585] Wish: client-side progress bar for end-turn activities
Update of bug #14585 (project freeciv): Status:None = Ready For Test Planned Release: 2.6.0 = 2.6.0, 3.0.0 ___ Follow-up Comment #4: Minimally tested patch to turn gtk-client timeout display to show eta (estimation = previous turn change) of server finishing processing. (file #24020) ___ Additional Item Attachment: File name: TurnChangeWait.patch Size:12 KB ___ Reply to this item at: http://gna.org/bugs/?14585 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16362] ggz page gives Gtk-WARNING
Update of bug #16362 (project freeciv): Status:None = Wont Fix Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #5: We've since dropped ggx support. ___ Reply to this item at: http://gna.org/bugs/?16362 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16385] Consider changing how base ownership works to avoid problems with buoys
Update of bug #16385 (project freeciv): Status: Postponed = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #14: Ok to close this ticket? Nobody disagreed. ___ Reply to this item at: http://gna.org/bugs/?16385 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5923] Add a string value field to the packet unit_do_action
URL: http://gna.org/patch/?5923 Summary: Add a string value field to the packet unit_do_action Project: Freeciv Submitted by: sveinung Submitted on: Sun 08 Mar 2015 10:50:03 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0 ___ Details: so it later can be used to order a unit to found a city with a specified name. Remember to update network capstring when committing this patch. ___ File Attachments: --- Date: Sun 08 Mar 2015 10:50:03 PM UTC Name: 0002-Add-a-string-value-field-to-the-packet-unit_do_actio.patch Size: 7kB By: sveinung http://gna.org/patch/download.php?file_id=24036 ___ Reply to this item at: http://gna.org/patch/?5923 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23367] window
Update of bug #23367 (project freeciv): Status:None = Invalid Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23367 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5913] json protocol: Handle multiple packets in buffer -case
Follow-up Comment #3, patch #5913 (project freeciv): It then seems that freeciv-web protocol is not symmetric in a sense that server-proxy has different packet structure to what proxy-server has. The patch includes some changes that were necessary for handling packets sent by the server (like in server-proxy protocol). Now you are saying that they actually break receiving packets from freeciv-web proxy (proxy-server)? I think this patch can be broken to a couple of separate changes: 1) Shifting the buffer (where previously was a no-op memmove() with the same source and dest + simply marking the buffer empty) 2) json_loadb() buffer length correction, not including raw-protocol header terminating NULL (handling of that NULL is what I suspect most) 3) Change to checking the minimum length of the buffer to be sane. That's actually an overdue change from the time we removed the unused 'type' from the packet header. The whole code-block is now actually obsolete (we've already read the 'length', no point to check if we've got it) but I didn't remove it in this patch as an unrelated change no packets could be sent to or from the Freeciv server Umh, the change is in receiving side only. So how could that affect sending? ___ Reply to this item at: http://gna.org/patch/?5913 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16882] Separate gold transfers from diplcost
Update of bug #16882 (project freeciv): Status:None = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #3: There's separate settings, diplgoldcost and diplbulbcost, for these in 2.6. ___ Reply to this item at: http://gna.org/bugs/?16882 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16506] Option missing to disable ZOC imposed by units (e.g., Freight, Caravan)
Update of bug #16506 (project freeciv): Status:None = Duplicate Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #12: ZoC flag introduced in 2.6 ___ Reply to this item at: http://gna.org/bugs/?16506 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19087] Slicker language selection in Windows installer
Update of bug #19087 (project freeciv): Status: Need Info = Ready For Test Planned Release: = 2.5.1, 2.6.0, 3.0.0 ___ Follow-up Comment #5: Patch written from scratch. Creates langstat.txt, but does not yet try to use it in Windows Installer build process. Added Makefile of its own for bootstrap/. This means that 1) the directory gets created to builddir hierarchy too - there's directory to build langstat.txt to 2) we can control its position in subdirectory listing while root Makefile was always the first one to get handled - we create langstat.txt only after translation/ has been handled and po-files merged against current strings - percentages reflect po-files in distribution, not the situation as in previously committed po-file version Currently has only core translation domain statistics. (file #24022, file #24023) ___ Additional Item Attachment: File name: Langstat.patch Size:5 KB File name: Langstat-S2_5.patchSize:4 KB ___ Reply to this item at: http://gna.org/bugs/?19087 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19033] Add a LUA 'tick' event
Follow-up Comment #2, bug #19033 (project freeciv): I want to be able to save the game every 15 minutes. That's currently possible by enabling autosave type timer. ___ Reply to this item at: http://gna.org/bugs/?19033 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5736] Dynamically get supported file formats
Follow-up Comment #5, patch #5736 (project freeciv): Since this change on S2_6, if I run the client in my build tree with -t trident, the client dies on Start New Game: 0: Failed reading graphics file /home/jtn/src/freeciv/git/bS2_6/../data/flags/usa.svg: Couldn't recognise the image file format for file '/home/jtn/src/freeciv/git/bS2_6/../data/flags/usa.svg' 2: Backtrace: 2: 0: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(backtrace_print+0x30) [0x610de0] 2: 1: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(vdo_log+0x8b) [0x615e5b] 2: 2: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(do_log+0x7d) [0x615f0d] 2: 3: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(load_gfxfile+0x61) [0x4687e1] 2: 4: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2() [0x4be8b8] 2: 5: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2() [0x4c0272] 2: 6: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(tileset_setup_nation_flag+0xb5) [0x4c5fa5] 2: 7: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(client_handle_packet+0x399) [0x4adcb9] 2: 8: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(client_packet_input+0x1f) [0x47238f] 2: 9: /home/jtn/src/freeciv/git/bS2_6/./client/freeciv-gtk2(input_from_server+0x6c) [0x478f4c] ... I suspect that the data/flags/foo.svg files that live alongside the .pngs in svn are now causing trouble because something in Gtk thinks it knows about .svg; and that this only affects tilesets using the small flags because foo-large.svg doesn't exist. ___ Reply to this item at: http://gna.org/patch/?5736 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23302] Can't see settler city footprint with grid enabled
Follow-up Comment #4, bug #23302 (project freeciv): Looks good, thanks! ___ Reply to this item at: http://gna.org/bugs/?23302 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5920] Placeholder Internet graphics
Update of patch #5920 (project freeciv): Status: In Progress = Duplicate Open/Closed:Open = Closed ___ Follow-up Comment #1: Oops, we already have a ticket: patch #5806. ___ Reply to this item at: http://gna.org/patch/?5920 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5806] Internet gfx to large buildings set
Update of patch #5806 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #1: Attached a placeholder graphic for both large and small tilesets. * buildings.png - data/misc * internet.png - data/wonders * internet.xcf - data/graphics/wonders (file #24024, file #24025, file #24026, file #24027) ___ Additional Item Attachment: File name: trunk-S2_6-S2_5-internet-gfx.patch Size:1 KB File name: buildings.png Size:123 KB File name: internet.png Size:2 KB File name: internet.xcf Size:33 KB ___ Reply to this item at: http://gna.org/patch/?5806 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5920] Placeholder Internet graphics
URL: http://gna.org/patch/?5920 Summary: Placeholder Internet graphics Project: Freeciv Submitted by: jtn Submitted on: Sun 08 Mar 2015 11:21:37 UTC Category: art Priority: 5 - Normal Status: In Progress Privacy: Public Assigned to: jtn Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.5.0, 2.6.0, 3.0.0 ___ Details: civ2civ3's Internet wonder is the only one without a unique image. Here's a placeholder, in case no-one has a better idea. ___ Reply to this item at: http://gna.org/patch/?5920 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23343] New Japanese translation for Freeciv ver2.5.0
Update of bug #23343 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?23343 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5606] Found city as action enablers controlled activity
Update of patch #5606 (project freeciv): Depends on: = patch #5923 ___ Reply to this item at: http://gna.org/patch/?5606 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23367] window
URL: http://gna.org/bugs/?23367 Summary: window Project: Freeciv Submitted by: None Submitted on: Mon 09 Mar 2015 02:33:30 AM UTC Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: Mac OS Planned Release: ___ Details: ___ Reply to this item at: http://gna.org/bugs/?23367 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23367] window
Follow-up Comment #1, bug #23367 (project freeciv): Sorry, I intended to search, not to file a report. Please delete. ___ Reply to this item at: http://gna.org/bugs/?23367 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5858] Worker units' handwritten help redundant with autogenerated help
Update of patch #5858 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #1: Patches. In S2_6+ versions, fixing this for civ2civ3 is deferred to patch #4936 (it's on my private branch now). In S2_6+ versions, this is likely to be a transitional stage. The information about extras currently associated with the Workers unit should move to the extras' own sections of the help. (file #24028, file #24029) ___ Additional Item Attachment: File name: trunk-S2_6-help-terrainalter-redundant.patch Size:9 KB File name: S2_5-help-terrainalter-redundant.patch Size:12 KB ___ Reply to this item at: http://gna.org/patch/?5858 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23362] civ2civ3 help: Settlers, Workers, and Engineers but not Migrants
Update of bug #23362 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #1: Also help for Construction, about which units can build fortresses. (file #24030, file #24031) ___ Additional Item Attachment: File name: trunk-S2_6-help-civ2civ3-terrainalter-migrants.patch Size:2 KB File name: S2_5-help-civ2civ3-terrainalter-migrants.patch Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?23362 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #5921] Make citytile_type a specenum.
URL: http://gna.org/patch/?5921 Summary: Make citytile_type a specenum. Project: Freeciv Submitted by: sveinung Submitted on: Sun 08 Mar 2015 03:05:49 PM UTC Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: sveinung Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 3.0.0, 2.6.0 ___ Details: ___ File Attachments: --- Date: Sun 08 Mar 2015 03:05:49 PM UTC Name: 0001-Make-citytile_type-a-specenum.patch Size: 3kB By: sveinung http://gna.org/patch/download.php?file_id=24034 ___ Reply to this item at: http://gna.org/patch/?5921 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #23281] Ruleset tech help should document enabled extras more thoroughly
Update of bug #23281 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn Depends on: = bugs #23362 ___ Follow-up Comment #1: I haven't checked what other rulesets could benefit yet. All of them, basically. S2_6+ also fix a regression since 2.5: tech help for Refrigeration was no longer mentioning Farmland. (file #24032, file #24033) ___ Additional Item Attachment: File name: trunk-S2_6-help-tech-extras.patch Size:4 KB File name: S2_5-help-tech-extras.patchSize:3 KB ___ Reply to this item at: http://gna.org/bugs/?23281 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
