[Freeciv-Dev] [bug #23414] autoconf: Incorrect test on nullptr

2015-03-28 Thread Alexey Novikov
Follow-up Comment #6, bug #23414 (project freeciv):

If AC_CHECK_HEADERS is placed under AC_CHECK_CACHED configure will produce
inconsistent output like this: checking for nullptr... checking for
cstdlib... ok.

I think it would be better to utilise AC_CHECK_HEADER_ONCE to make header
check cached but that macros ignores AC_LANG_PUSH([C++]).

___

Reply to this item at:

  http://gna.org/bugs/?23414

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5821] activity_offset_x

2015-03-28 Thread Marko Lindqvist
Follow-up Comment #1, patch #5821 (project freeciv):

- Update (format of) supplied tilesets
- Document the new field in README.graphics

(file #24136)
___

Additional Item Attachment:

File name: ActivityOffset-2.patch Size:6 KB


___

Reply to this item at:

  http://gna.org/patch/?5821

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23414] autoconf: Incorrect test on nullptr

2015-03-28 Thread Marko Lindqvist
Update of bug #23414 (project freeciv):

  Status:None = Ready For Test 
 Assigned to:None = cazfi  


___

Reply to this item at:

  http://gna.org/bugs/?23414

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23416] Segfault on autosave when the player picked his nation

2015-03-28 Thread Marko Lindqvist
Update of bug #23416 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23416

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23418] Half of the Fortress gfx not shown in Amplio2

2015-03-28 Thread Marko Lindqvist
Update of bug #23418 (project freeciv):

  Status:  Ready For Test = Fixed  
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?23418

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5957] citydlg overview tab bottom part column spacing

2015-03-28 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5957

 Summary: citydlg overview tab bottom part column spacing
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Mar 2015 08:33:17 AM EEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.4.5, 2.5.1, 2.6.0, 3.0.0

___

Details:

There seems to be copy/paste error in setting column spacing for bottom grid
of the overview tab of gtk3-client citydlg. Instead of 'bottom', spacing is
set for 'hbox' set up earlier.
This seems mostly harmless - I noticed no difference in bottom grid when I
fixed this. I noticed this only because of the extra 'hbox' reference when
that grid was supposed to be all set up already.

Fix attached.




___

File Attachments:


---
Date: Sun 29 Mar 2015 08:33:17 AM EEST  Name: BottomColumnSpacing.patch  Size:
504B   By: cazfi

http://gna.org/patch/download.php?file_id=24138

___

Reply to this item at:

  http://gna.org/patch/?5957

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23427] City without Bridge Building help problem

2015-03-28 Thread Marko Lindqvist
URL:
  http://gna.org/bugs/?23427

 Summary: City without Bridge Building help problem
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Mar 2015 08:47:12 AM EEST
Category: docs
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.5.1, 2.6.0, 3.0.0

___

Details:

Robin Patterson in
http://freeciv.wikia.com/wiki/Talk:Freeciv-manual/3_%282.5%29:

However, in 2.5.0 (classic ruleset) it does not, but must wait for Bridge
Building. This is contrary to the in-game help statement that a city is
developed with roads.

Grepping is developed with roads finds one place in helpdata.txt that says
so.




___

Reply to this item at:

  http://gna.org/bugs/?23427

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5956] Remove code to load base or road maps from savegame3.c

2015-03-28 Thread Marko Lindqvist
URL:
  http://gna.org/patch/?5956

 Summary: Remove code to load base or road maps from
savegame3.c
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 29 Mar 2015 02:04:48 AM EET
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Remove dead code (as it would apply to pre-2.6 savegames only) loading base
and road maps from savegame3.c. Most of special map loading code is gone too,
with (broken) river overlay -case left as an reference for reimplementation.



___

File Attachments:


---
Date: Sun 29 Mar 2015 02:04:48 AM EET  Name: Savegame3BasesRoads.patch  Size:
12kB   By: cazfi

http://gna.org/patch/download.php?file_id=24137

___

Reply to this item at:

  http://gna.org/patch/?5956

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5947] Qualify ruledit statistics strings

2015-03-28 Thread Marko Lindqvist
Update of patch #5947 (project freeciv):

  Status:  Ready For Test = Done   
 Assigned to:None = cazfi  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?5947

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #5756] Make Amplio2 maglevs more distinct

2015-03-28 Thread Marko Lindqvist
Update of patch #5756 (project freeciv):

  Status: In Progress = Ready For Test 

___

Follow-up Comment #4:

I'm going to commit this version from GriffonSpade after 36h:
http://forum.freeciv.org/f/viewtopic.php?f=12t=7start=107


___

Reply to this item at:

  http://gna.org/patch/?5756

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22856] gtk+-3.14: Left panel black with Messages and Chat report location other than Merged

2015-03-28 Thread Marko Lindqvist
Follow-up Comment #1, bug #22856 (project freeciv):

Works with gtk+-3.16.0

___

Reply to this item at:

  http://gna.org/bugs/?22856

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #23414] autoconf: Incorrect test on nullptr

2015-03-28 Thread Marko Lindqvist
Follow-up Comment #5, bug #23414 (project freeciv):

Not a big issue, but is there some reason you placed the header check outside
the cached part of the nullptr check?

___

Reply to this item at:

  http://gna.org/bugs/?23414

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev