[Freeciv-Dev] [patch #6474] Qt client - show resize cursor in chat and messages

2015-10-24 Thread mir3x 
URL:
  

 Summary: Qt client - show resize cursor in chat and messages
 Project: Freeciv
Submitted by: mir3x
Submitted on: Sat 24 Oct 2015 09:19:05 AM CEST
Category: client-qt
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

It was possible to resize chat and messages already, but cursor wasn't changed
when hovered over edge.
Now he changes shape so everyone will figure those widgets could be easily
resized.




___

File Attachments:


---
Date: Sat 24 Oct 2015 09:19:05 AM CEST  Name: qt_resize_chat_messages.patch 
Size: 2kB   By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23965] Savegame loading depends on fc_assert() family members being defined

2015-10-24 Thread Marko Lindqvist 
URL:
  

 Summary: Savegame loading depends on fc_assert() family
members being defined
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 24 Oct 2015 10:40:31 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Noticed in S2_6 savegame.c:

  fc_assert_exit_msg(secfile_lookup_int(file, &map.server.riches,
"map.riches"),
 "%s", secfile_error());
  fc_assert_exit_msg(secfile_lookup_int(file, &map.server.huts,
"map.huts"),
 "%s", secfile_error());
  fc_assert_exit_msg(secfile_lookup_int(file,
&ei,
"map.generator"),
 "%s", secfile_error());


Not checked if this affects also savegame2.c (and in case of TRUNK;
savegame3.c)





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23939] map shadows Qt map

2015-10-24 Thread Marko Lindqvist 
Update of bug #23939 (project freeciv):

  Status:None => In Progress


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23950] No way to save client options if you have disabled 'Save Options on Exit' in general

2015-10-24 Thread mir3x 
Update of bug #23950 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => mir3x  
 Planned Release: => 2.5.2, 2.6, 3.0

___

Follow-up Comment #1:

Added those menu entries: "Save Options Now" and checkable "Save Options on
Exit".

(file #25421)
___

Additional Item Attachment:

File name: qt_client_save_options.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

2015-10-24 Thread Andreas Røsdal 
URL:
  

 Summary: Segfault when loading in Freeciv web
 Project: Freeciv
Submitted by: andreasr
Submitted on: Sat 24 Oct 2015 11:07:49 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

The following segfault occurs regularly when loading å game in Freeciv web:




pplayer = 
__FUNCTION__ = "server_packet_input"
#11 0x004a624e in incoming_client_packets (pconn=)
at sernet.c:460
command_ok = 
packet = {data = 0x25f6c60, type = PACKET_CHAT_MSG_REQ}
#12 server_sniff_all_input () at sernet.c:856
pconn = 0x87a560 
nb = 
i = 
s = 
max_desc = 
readfs = {fds_bits = {64, 0 }}
writefs = {fds_bits = {0 }}
exceptfs = {fds_bits = {0 }}
tv = {tv_sec = 0, tv_usec = 17389}
__FUNCTION__ = "server_sniff_all_input"
#13 0x0040e5cd in srv_main () at srv_main.c:3187
__FUNCTION__ = "srv_main"
#14 0x00406c19 in main (argc=20, argv=0x7ffcd264ed18) at
civserver.c:459
inx = 20
showhelp = 
showvers = 
option = 
__FUNCTION__ = "main"




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Segfault when loading in Freeciv web

2015-10-24 Thread Andreas Røsdal 
Follow-up Comment #1, bug #23966 (project freeciv):

bt full
#0  __strncpy_sse2 (s1=0x7ffcd2647aff "", s1@entry=0x7ffcd2647b00 "",
    s2=0x1 , n=n@entry=47)
    at ./strncpy.c:41
    n4 = 11
    c = 
    s = 0x7ffcd2647b00 ""
#1  0x7f0f3722dfba in __strncpy_chk (s1=s1@entry=0x7ffcd2647b00 "",
    s2=, n=n@entry=47, s1len=s1len@entry=4076) at
strncpy_chk.c:32
No locals.
#2  0x0047e08d in strncpy (__len=, __src=,
    __dest=0x7ffcd2647b00 "") at
/usr/include/x86_64-linux-gnu/bits/string3.h:120
No locals.
#3  send_ruleset_control (dest=dest@entry=0x2538470) at ruleset.c:3512
    part = {
  text =
"\000\000\000\000\000\000\000\000`{d\322\374\177\000\000\377\377\377\377\377\377\377\377\016",
'\000' , "
\000\000\000\000\000\000\000\000\000Ёd\322\374\177\000\000uta\000\000\000\000\000\002\000\000\000\000\000\000\000\020\000\000\000\"#FFyta\000\000\000\000\000*5
has been removed from the
game.\000APd\000\000\000`\202d\322\374\177\000\000
\204d\322\374\177\000\000`\202d\322\374\177\000\000W\205^\000\000\000\000\000\b\204d\322\374\177\000\000\001\000\000\000\000\000\000\000\377\003\000\000\000\000\000\000\030\000\000\000\060\000\000\000І"...}
    this_len = 
    packet = {num_unit_classes = 0, num_unit_types = 0,
num_impr_types = 0,
  num_tech_types = 0, num_extra_types = 14, num_base_types =
0,
  num_road_types = 0, num_goods_types = 1, num_disaster_types
= 0,
  num_achievement_types = 0, num_multipliers = 0, num_styles
= 0,
  num_music_styles = 0, government_count = 0, nation_count =
0,
  styles_count = 0, terrain_count = 0, resource_count = 0,
  num_specialist_types = 0, prefered_tileset = '\000'
,
  prefered_soundset = '\000' ,
  prefered_musicset = '\000' ,
popup_tech_help = false,
  name = "Web-default", '\000' ,
  version = '\000' , desc_length = 47}
    desc_left = 
    index = 0
#4  0x00490d21 in send_rulesets (dest=0x2538470) at ruleset.c:7176
No locals.
#5  0x00418527 in load_command (
    caller=caller@entry=0x87a560 ,
    filename=filename@entry=0x7ffcd264b1e0 "JLV", check=check@entry=false)
    at stdinhand.c:3662
    loadtimer = 0x6efde80
    uloadtimer = 0x33ac6a0
    file = 0x25f42b0
    arg =
"/home/freeciv/freeciv-web/freeciv-web/resin/webapps/ROOT/savegames/JLV.sav.xz",
'\000' ,
"I\a\032\067\017\177\000\000p\223d\322\374\177\000\000`\223d\322\374\177\000\000)0\027\067\017\177\000\000\071\341]\000\000\000\000\000\020\341]\000\000\000\000\000\352\364\026\067\017\177",
'\000' ...
    __FUNCTION__ = "load_command"
#6  0x0041ab2c in handle_stdin_input_real (
    caller=caller@entry=0x87a560 , str=,
    str@entry=0x7ffcd264bd00 "/load JLV", check=check@entry=false,
    read_recursion=read_recursion@entry=0) at stdinhand.c:4229
    full_command = "load JLV", '\000' ,
"\377\377\377\377\377\377\377\377", '\000' , "
\000\000\000\000\000\000\000\000\000N\000\000\000\374\177", '\000' , "\001\000\000\000\000\000\000\000\377\377\377\377\377\377\377\377N",
'\000' , "\374\177
\000\000\000\000\000\000\000\000\000`\260d\322\374\177\000\000cy`\000\000\000\000\000\002\000\000\000\000\000\000\000O\000\000\000\017\177\000\000fy`",
'\000' ...
    command =
"load\000\000\000\000\300V\031\004\000\000\000\000\000\020\000\000\000\000\000\000\006)\031\067\017\177\000\000\020\000\000\000\000\000\000\000i%\000\000\000\000\000\000\001\000\000\000\000\000\000\000\244\201",
'\000' ,
"\372\000\000\000\000\000\000\000\000\020\000\000\000\000\000\000\b\000\000\000\000\000\000\000\252\312)V\000\000\000\000\b\302>8\000\000\000\000)y(V\000\000\000\000\340\201\321\b\000\000\000\000)y(V\000\000\000\000\340\223K\t",
'\000' ,
"\300V\031\004\000\000\000\000\n\000\000\000\000\000\000\000\000+Freeci"...---Type
 to continue, or q  to quit---

    arg = "JLV", '\000' ,
"\340\263d\322\374\177\000\000P\262d\322\374\177\000\000\340\223Z\002\000\000\000\000p\224Z\002\000\000\000\000search
your-server.de\n\000\061\060\060\n\000BY HAND -- YOUR CHANGES WILL BE
OVERWRITTEN\n\000nf(8)\n\000|\000\000\000\374\177\000\000\300\225Z\002\000\000\000\000\200\224Z\002\000\000\000\000@Dž0\017\177\000\000`\264d\322\374\177\000\000\200\265d\322\374\177\000\000\000\024[\002\000\000\000\000)\333\024\067\017\177\000\000\000challeng"...
    cptr_s = 
    cptr_d = 
    cmd = CMD_LOAD
    level = 
    __FUNCTION__ = "handle_stdin_input_real"
#7  0x0041d199 in handle_stdin_input (
    caller=caller@entry=0x87a560 ,
    str=str@entry=0x7ffcd264bd00 "/load JLV") at stdinhand.c:4028
No locals.
#8  0x004c1e00 in handle_chat_msg_req (
    pconn=pconn@entry=0x87a560 , message=)
    at handchat.c:343
    real_message = "/load JLV", '\000' ,
"\024\353\060\070\017\177\000\000\016\204S\002\000\000\000\000\020\202S\002\000\000\000\000\016\204S\002\377\000\000\000\024\353\060\070\017\177\000\000\016\204S\002\000\000\000\000\020\202S\002\000\000\000\000\016\2

[Freeciv-Dev] [task #7924] S2_6 network protocol freeze

2015-10-24 Thread Jacob Nevins 
Update of task #7924 (project freeciv):

  Depends on: => patch #6475


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6475] Re-order extra_cause enum to make player actions contiguous

2015-10-24 Thread Jacob Nevins 
URL:
  

 Summary: Re-order extra_cause enum to make player actions
contiguous
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 24 Oct 2015 12:30:29 BST
Category: None
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

I've been carrying a local patch for ages which reorders the extra_cause enum
to divide causes into two contiguous ranges: those which the user can initiate
with a keypress, and those they cannot.
(This is part of the prototype patch series attached to patch #3756.)

I'm not yet sure that the final form of patch #3756 will even need this, but I
may as well apply it before 2.6 network freeze in case it comes in useful
later. If subsequent changes break the ranges, no great loss.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3756] RFC: UI for building generic roads, bases, etc

2015-10-24 Thread Jacob Nevins 
Update of patch #3756 (project freeciv):

  Depends on: => patch #6475


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6475] Re-order extra_cause enum to make player actions contiguous

2015-10-24 Thread Jacob Nevins 
Update of patch #6475 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-rearrange-extra-cause.patch Size:1 KB
File name: S2_6-rearrange-extra-cause.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3756] RFC: UI for building generic roads, bases, etc

2015-10-24 Thread Jacob Nevins 
Additional Item Attachment, patch #3756 (project freeciv):

File name: trunk-extra-ui-prototype-ter.mbox Size:33 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3756] RFC: UI for building generic roads, bases, etc

2015-10-24 Thread Jacob Nevins 
Follow-up Comment #9, patch #3756 (project freeciv):

Rebased on top of current trunk + patch #6475.
No change to functionality.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23967] multiplay server becomes too heavy

2015-10-24 Thread anonymous 
URL:
  

 Summary: multiplay server becomes too heavy
 Project: Freeciv
Submitted by: None
Submitted on: 2015年10月24日 15時12分33秒
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.5.1
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Recently we played Freeciv in multiplayer but the server became abnormally
heavy.
I was automatically disconnected and  it took about 120 seconds to reconnect.
("Network" server settings wasn't changed. about 10 players,1000 tiles, no AI
player)

I think such lag didn't occur in ver 2.5.0,
and connection request from specific player occasionally leads to lag.
I have been playing multiplayer for several years and I'm convinced that this
lag is clearly abnormal. 




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23967] multiplay server becomes too heavy

2015-10-24 Thread Marko Lindqvist 
Follow-up Comment #1, bug #23967 (project freeciv):

Are you sure there was no kind of hickups in the network between the server
and client, or one of them having other heavy traffic?

Can you send a savegame so we can check if it's related to the game
situation?

> connection request from specific player occasionally leads to lag.

It's a known problem that when the server needs to wait for "slowly
connecting" client, it's stuck (I think there's over an decade old bugreport
about it still unresolved).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23968] Qt client - chat auto scroll

2015-10-24 Thread mir3x 
URL:
  

 Summary: Qt client - chat auto scroll
 Project: Freeciv
Submitted by: mir3x
Submitted on: Sat 24 Oct 2015 06:19:38 PM CEST
Category: client-qt
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: mir3x
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.5.2, 2.6, 3.0

___

Details:

Chat could stop autoscrolling, if user has marked some text somewhere. If also
it's scrolled to another page - he won't see marked text and chat wont scroll
at all, which will be confusing.

Now chat will be always autoscrolled.



___

File Attachments:


---
Date: Sat 24 Oct 2015 06:19:38 PM CEST  Name: qt_chat_cursor.patch  Size: 1kB 
 By: mir3x



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23968] Qt client - chat auto scroll

2015-10-24 Thread mir3x 
Additional Item Attachment, bug #23968 (project freeciv):

File name: qt_chat_cursor.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23968] Qt client - chat auto scroll

2015-10-24 Thread mir3x 
Additional Item Attachment, bug #23968 (project freeciv):

File name: qt_chat_cursor_v2.patchSize:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23935] Client segfault when starting second local game

2015-10-24 Thread Jacob Nevins 
Update of bug #23935 (project freeciv):

 Planned Release:2.6.0, 3.0.0 => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #1:

Happens on S2_5 too.

Similar backtrace can be provoked without restarting server by going into edit
mode and changing to global observer using dropdown.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23969] Client segfault on quit, preceded by Gtk-CRITICAL IA__gtk_text_buffer errors

2015-10-24 Thread Jacob Nevins 
URL:
  

 Summary: Client segfault on quit, preceded by Gtk-CRITICAL
IA__gtk_text_buffer errors
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 24 Oct 2015 18:53:04 BST
Category: client-gtk-2.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

S2_5 r30188 (and later branches).
Simply start the client and immediately quit; no need to start a server.


(freeciv-gtk2:8332): Gtk-CRITICAL **: IA__gtk_text_buffer_get_end_iter:
assertion 'GTK_IS_TEXT_BUFFER (buffer)' failed
(freeciv-gtk2:8332): Gtk-CRITICAL **: IA__gtk_text_buffer_insert: assertion
'GTK_IS_TEXT_BUFFER (buffer)' failed
(freeciv-gtk2:8332): Gtk-CRITICAL **: IA__gtk_text_buffer_create_mark:
assertion 'GTK_IS_TEXT_BUFFER (buffer)' failed
Segmentation fault (core dumped)



#0  0x7fdd648abfc0 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#1  0x7fdd648c1414 in ?? ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#2  0x7fdd648c1ecb in gtk_text_iter_get_offset ()
   from /usr/lib/x86_64-linux-gnu/libgtk-x11-2.0.so.0
No symbol table info available.
#3  0x004cf693 in real_output_window_append (
astring=astring@entry=0x7fffc51b5de0 "Saved settings to file
/home/jtn/.freeciv-client-rc-2.5", tags=0x2b60830, conn_id=conn_id@entry=-1)
at chatline.c:921
buf = 0x0
iter = {dummy1 = 0x600, dummy2 = 0x6dc3e13554357d00, 
  dummy3 = 73386784, dummy4 = 0, dummy5 = 6680772, dummy6 = 0, 
  dummy7 = 0, dummy8 = 0, dummy9 = 0x7fdd63858760 , 
  dummy10 = 0x18, dummy11 = 6469926, dummy12 = 0, dummy13 = 82, 
  dummy14 = 0x68c6b8}
mark = 0x0
text_start_offset = 
__FUNCTION__ = "real_output_window_append"
#4  0x0047797f in output_window_append (color=..., 
featured_text=featured_text@entry=0x7fffc51b6410 "Saved settings to file
/home/jtn/.freeciv-client-rc-2.5") at chatline_common.c:130
plain_text = "Saved settings to file
/home/jtn/.freeciv-client-rc-2.5\000
k\033\305\377\177\000\000`j\033\305\377\177\000\000\352DNc\335\177\000\000\227\347c\000\000\000\000\000\352DNc\335\177\000\000\261\346c\000\000\000\000\000\352DNc\335\177\000\000pd\033\305\377\177\000\000`d\033\305\377\177\000\000\030\000\000\000\060\000\000\000@e\033\305\377\177\000\000\200d\033\305\377\177\000\000@_\033\305\377\177\000\000\260_\033\305\377\177\000\000P_\033\305\377\177\000\000(\315%\002\000\000\000\000\377\377\377\377\377\377\377\377\000\000\000\000\n\000\061\061"...
tags = 0x2b60830
__FUNCTION__ = "output_window_append"
#5  0x00477a6d in output_window_vprintf (color=..., 
format=, args=args@entry=0x7fffc51b6a48)
at chatline_common.c:145
featured_text = "Saved settings to file
/home/jtn/.freeciv-client-rc-2.5\000\000\000\000\000\000\000\000\000\032\000\000\000\000\000\000\000\260@\216",
'\000' ,
"\231XXc\335\177\000\000\000\000\000\000\000\000\000\000\003\060Qc\335\177\000\000\000\000\000\000\001\000\000\000\300\071\064\002\000\000\000\000|\b\000\000\000\000\000\000\000\200\022P\335\177\000\000\000\000\000\000\001\000\000\000bUQc\335\177\000\000\000\000\000\000\000\000\000\000\300\071\064\002",
'\000' , "\300\071\064\002", '\000' ...
#6  0x00477b12 in output_window_printf (color=..., 
format=) at chatline_common.c:159
args = {{gp_offset = 32, fp_offset = 48, 
overflow_arg_area = 0x7fffc51b6b20, 
reg_save_area = 0x7fffc51b6a60}}
#7  0x004b0bea in options_save () at options.c:5317
sf = 0x22b3a40
name = 0x8f6de0  "/home/jtn/.freeciv-client-rc-2.5"
#8  0x0047606b in client_exit () at client_main.c:639
No locals.
#9  0x004763af in client_main (argc=1, argv=0x7fffc51b6ed8)
at client_main.c:621
i = 1
loglevel = LOG_NORMAL
ui_options = 
ui_separator = 
option = 
user_tileset = 
fatal_assertions = -1
aii = 1
__FUNCTION__ = "client_main"
#10 0x7fdd634bbec5 in __libc_start_main (main=0x44b200 , argc=1, 
argv=0x7fffc51b6ed8, init=, fini=, 
rtld_fini=, stack_end=0x7fffc51b6ec8) at libc-start.c:287
result = 
unwind_buf = {cancel_jmp_buf = {{jmp_buf = {0, 1215812188462379877, 
4502021, 140736500297424, 0, 0, -1215720623487847579, 
-1196365231511964827}, mask_was_saved = 0}}, priv = {pad = {
  0x0, 0x0, 0x62b690 <__libc_csu_init>, 0x7fffc51b6ed8}, data = {
  prev = 0x0, cleanup = 0x0, canc

[Freeciv-Dev] [bug #16675] Trident tileset and ocean layers

2015-10-24 Thread Jacob Nevins 
Update of bug #16675 (project freeciv):

  Status:None => Fixed  
 Open/Closed:Open => Closed 
 Planned Release: => 2.5.2, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23969] Client segfault on quit, preceded by Gtk-CRITICAL IA__gtk_text_buffer errors

2015-10-24 Thread Marko Lindqvist 
Follow-up Comment #1, bug #23969 (project freeciv):

Does patch #6458 help?

My guess would be that as that particular message "Saved settings to file..."
is late in the shutdown that output window has already been closed at the
time.

Would also explain why I haven't seen related problem seen as part of bug
#23861 debugging in my own system as I have settings saving on exit disabled.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23969] Client segfault on quit, preceded by Gtk-CRITICAL IA__gtk_text_buffer errors

2015-10-24 Thread Jacob Nevins 
Follow-up Comment #2, bug #23969 (project freeciv):

> Does patch #6458 help?
Yes; it transmutes the error to


1: Output when no message buffer: Saved settings to file
/home/jtn/.freeciv-client-rc-2.5


with no segfault.

> I have settings saving on exit disabled.
I have it enabled.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23939] map shadows Qt map

2015-10-24 Thread Marko Lindqvist 
Update of bug #23939 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Move global map inside (global) game-structure not to use any name from global
namespace for it.

(file #25428, file #25429)
___

Additional Item Attachment:

File name: GameMap.patch.bz2  Size:26 KB
File name: GameMap-S2_6.patch.bz2 Size:25 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23969] Client segfault on quit, preceded by Gtk-CRITICAL IA__gtk_text_buffer errors

2015-10-24 Thread Marko Lindqvist 
Follow-up Comment #3, bug #23969 (project freeciv):

Regardless of the client (even if it had time to print the message to output
window) it makes no sense to show that message in a window closing before any
human can read it.

Would log_verbose() be the correct thing for it?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23970] Tradepartned NULL when players removed

2015-10-24 Thread Marko Lindqvist 
URL:
  

 Summary: Tradepartned NULL when players removed
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 24 Oct 2015 10:33:51 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: TRUNK r29569
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Apparently the autogame was already ending, and some players were already
freed when this happened. This is an somewhat modified r29569.

1: in set_city_production() [common/city.c::2638]: assertion 'tcity != NULL'
failed.
2: Backtrace:
2: 0: server/freeciv-server(backtrace_print+0x22) [0x636bf2]
2: 1: server/freeciv-server(vdo_log+0x76) [0x63a4e6]
2: 2: server/freeciv-server(do_log+0x7b) [0x63a57b]
2: 3: server/freeciv-server(fc_assert_fail+0x8c) [0x63a76c]
2: 4: server/freeciv-server(city_refresh_from_main_map+0x7fd) [0x56830d]
2: 5: server/freeciv-server(city_refresh+0x29) [0x488c79]
2: 6: server/freeciv-server(city_refresh_queue_processing+0x4c)
[0x4894fc]
2: 7: server/freeciv-server(server_remove_player+0x292) [0x4a4bd2]
2: 8: server/freeciv-server(server_game_free+0x9d) [0x43c63d]
2: 9: server/freeciv-server(srv_main+0x1cf) [0x43ca6f]
2:10: server/freeciv-server(main+0x267) [0x433567]




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23970] Tradepartner NULL when players removed

2015-10-24 Thread Marko Lindqvist 
Update of bug #23970 (project freeciv):

 Summary: Tradepartned NULL when players removed =>
Tradepartner NULL when players removed


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23955] Editor Tool Icon Leak

2015-10-24 Thread Marko Lindqvist 
Update of bug #23955 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6458] Make sure that message_buffer exist before appending to it

2015-10-24 Thread Marko Lindqvist 
Update of patch #6458 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6464] Partially restore --preserve-dup-deps

2015-10-24 Thread Marko Lindqvist 
Update of patch #6464 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6466] Wooden Fort art for Amplio2

2015-10-24 Thread Marko Lindqvist 
Update of patch #6466 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6469] Install rulesets as part of ruledit installation

2015-10-24 Thread Marko Lindqvist 
Update of patch #6469 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6467] Make target/actor exists sanity checks asserts

2015-10-24 Thread Sveinung Kvilhaugsvik 
Update of patch #6467 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6468] savegame: use stored diplstate_type order

2015-10-24 Thread Sveinung Kvilhaugsvik 
Update of patch #6468 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev