[Freeciv-Dev] [patch #6500] generate_packets.py: ignore argument position

[Sveinung Kvilhaugsvik]

Update of patch #6500 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6501] New configure option --disable-delta-protocol

[Marko Lindqvist]

Follow-up Comment #2, patch #6501 (project freeciv):

Sorry for being a bit late with my comments.

General comment is that have you investigated the possibility to support both
delta and no-delta at runtime and have server and client to negotiate if it
can be used (with configure option to control if the counterpart being build
ever agrees to deltaless communication)

As for this patch; it seems you don't check against illegal values at all.
What happens if one writes '--enable-delta-protocol=No' (note Capital 'N') ?
Or does AC_ARG_ENABLE() do all that automatically by default for you when
called with just two arguments?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6501] New configure option --disable-delta-protocol

[Sveinung Kvilhaugsvik]

Update of patch #6501 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23984] Conversion from 'enum diplrel_other' to 'enum citytile_type'

[Sveinung Kvilhaugsvik]

Update of bug #23984 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

(tested with clang 3.5)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23954] Pixmap too short in city dialog in supported units

[Marko Lindqvist]

Update of bug #23954 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Attached patch
- Adds tileset_unit_with_upkeep_height() and tileset_unit_layout_offset_y() to
client common code for guis to use
- Makes gtk2- and gtk3-clients to use them

The behavior is what it seemed like to be the intention already (overhead
tileset draws upkeep icons completely below the unit sprite, iso-tileset has
them to overlay lower part of the unit sprite using offset *tile*_height from
the top of the *unit* sprite)

In gtk3-client's case trident upkeep icons were almost completely cut out
before this fix. In gtk2-client the icons were completely visible, but the
clickable area was too small.

(file #25524)
___

Additional Item Attachment:

File name: UnitUpkeepHeight.patch Size:8 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7814] S2_6 datafile format freeze

[Marko Lindqvist]

Update of task #7814 (project freeciv):

  Depends on: => patch #6511


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6511] Tileset "unit_layout_icon_offset_y"

[Marko Lindqvist]

URL:
  

 Summary: Tileset "unit_layout_icon_offset_y"
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 Oct 2015 08:20:45 PM EET
Category: client
Priority: 5 - Normal
  Status: In Progress
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Make unit upkeep (or generally "overlay") icons y-offset tileset configurable,
once bug #23954 provides clean place, tileset_unit_layout_offset_y(), to
implement it to.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23999] Error out on invalid values given to --disable-delta-protocol

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Error out on invalid values given to
--disable-delta-protocol
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 29 Oct 2015 07:32:09 PM UTC
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: TRUNK
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Reported by Marko Lindqvist 






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6496] Look ws2tcpip.h for socklen_t definition

[Marko Lindqvist]

Update of patch #6496 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6501] New configure option --disable-delta-protocol

[Sveinung Kvilhaugsvik]

Follow-up Comment #3, patch #6501 (project freeciv):

_have you investigated the possibility to support both delta and no-delta at
runtime and have server and client to negotiate if it can be used_
I have been playing with the idea of using the optional protocol capability
system. Haven't investigated it enough to estimate how much effort it would
take.

_As for this patch; it seems you don't check against illegal values at all._
Correct. The arguments '--disable-delta-protocol' (handled by AC_ARG_ENABLE)
and '--enable-delta-protocol=no' should result in the delta protocol support
being disabled. A missing option, it being enabled or an illegal value should
not disable it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6501] New configure option --disable-delta-protocol

[Marko Lindqvist]

Follow-up Comment #4, patch #6501 (project freeciv):

So it is silently accepting an illegal value. Unlike any other of our
AC_ARG_ENABLE() options.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6501] New configure option --disable-delta-protocol

[Sveinung Kvilhaugsvik]

Follow-up Comment #5, patch #6501 (project freeciv):

> So it is silently accepting an illegal value. Unlike any other of our
AC_ARG_ENABLE() options.
Now bug #23999. (The "set to 'False' to figure out what it does, forget about
it and then wonder why network games doesn't work" use case is better handled
by patch #6512)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6512] Mention the network protocol in the Configuration Summary

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Mention the network protocol in the Configuration
Summary
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 29 Oct 2015 07:20:47 PM UTC
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Should probably also warn about the consequences if the normal network
protocol (binary with delta) is unsupported.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24000] "Please include winsock2.h before windows.h"

[Marko Lindqvist]

URL:
  

 Summary: "Please include winsock2.h before windows.h"
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 29 Oct 2015 11:01:57 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

In file included from /usr/share/mingw-w64/include/ws2tcpip.h:17:0,
 from ../../../utility/netintf.h:47,

/usr/share/mingw-w64/include/winsock2.h:15:2: warning: #warning Please include
winsock2.h before windows.h [-Wcpp]





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23989] Public netitnf.h header has non-public HAVE_SOCKLEN_T

[Marko Lindqvist]

Update of bug #23989 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

Fix for HAVE_SOCKEN_T -> FREECIV_HAVE_SOCKLEN_T, HAVE_WINSOCK ->
FREECIV_HAVE_WINSOCK, and all includes from netintf.h

All new public macros needed for this are used also in other places where they
should, but the fixing process did not propagate to fix other problematic
macros on those other headers.

HAVE_WINSOCK -> FREECIV_HAVE_WINSOCK is special case in that the macro is not
defined automatically at all but only by our own AC_DEFINE() and the old name
does not exist at all (even in private side) any more -> all uses must be
changed, not only those at public headers.

(file #25525, file #25526)
___

Additional Item Attachment:

File name: NetintfPublicMacros.patch  Size:18 KB
File name: NetintfPublicMacros-S2_6.patch Size:18 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23811] Dead man can cancel treaties

[Marko Lindqvist]

Update of bug #23811 (project freeciv):

  Status:None => Ready For Test 
 Assigned to:None => cazfi  
 Planned Release: => 2.5.2, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23811] Dead man can cancel treaties

[Isaac O'Hern]

Follow-up Comment #1, bug #23811 (project freeciv):

Made it a DIPL_ERROR to cancel a treaty if either player involved is dead.

(file #25527)
___

Additional Item Attachment:

File name: dead_player_treaty.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6512] Mention the network protocol in the Configuration Summary

[Sveinung Kvilhaugsvik]

Update of patch #6512 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => sveinung   
 Planned Release: => 3.0.0  

___

Additional Item Attachment:

File name: 0001-Show-protocol-in-the-configuration-summary.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24001] actiontools.c not including fc_config.h

[Marko Lindqvist]

URL:
  

 Summary: actiontools.c not including fc_config.h
 Project: Freeciv
Submitted by: cazfi
Submitted on: Fri 30 Oct 2015 01:56:23 AM EET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.6.0, 3.0.0

___

Details:

Building actiontools.c, including common headers without any macros from
fc_config.h set, causes incompatibilities with other object files built with
properly set macros.

Fix attached




___

File Attachments:


---
Date: Fri 30 Oct 2015 01:56:23 AM EET  Name: ActiontoolsFcConfig.patch  Size:
460B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6495] gtk_menus.xml -> gtk2_menus.xml + gtk3_menus.xml

[Marko Lindqvist]

Update of patch #6495 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23966] Xz decompression failure due to too small PLAIN_FILE_BUF_SIZE

[Marko Lindqvist]

Update of bug #23966 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23954] Pixmap too short in city dialog in supported units

[Marko Lindqvist]

Update of bug #23954 (project freeciv):

  Status:None => In Progress

___

Follow-up Comment #1:

In S2_5 things have to be arranged some fixed way, but this may require giving
tileset more control over the placement of the upkeep icons in S2_6 -> d3f
stuff.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24000] "Please include winsock2.h before windows.h"

[Marko Lindqvist]

Update of bug #24000 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

Fixes.

For S2_6/TRUNK WindowsIncluderOrder* patches are meant to be used. S2_5
version of that patch is attached just in case, but the one meant to get
committed to S2_5 is Revert6496.patch (not complete revert, but one getting
rid of ws2tcpip.h stuff)

(file #25530, file #25531, file #25532, file #25533)
___

Additional Item Attachment:

File name: WindowsIncludeOrder.patch  Size:7 KB
File name: WindowsIncludeOrder-S2_6.patch Size:7 KB
File name: Revert6496.patch   Size:0 KB
File name: WindowsIncludeOrder-S2_5.patch Size:7 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24000] "Please include winsock2.h before windows.h"

[Marko Lindqvist]

Update of bug #24000 (project freeciv):

Category:None => general
  Status:None => In Progress
 Planned Release: => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #1:

For S2_5 it's probably best to revert patch #6496 except for the
"- Do not fail the socklen_t configure check just because (any) system lacks
headers needed providing socklen_t in some other system"
part. Otherwise the patch is the first time we use any ws2 stuff without
providing any real benefit. The ws2 include might bring incompatibility
stuff.
Let's have overall ws2 update targeted to S2_6.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23888] explorer_goto() can mess goto_tile for AI task using it

[Marko Lindqvist]

Update of bug #23888 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev