[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europe_1901's turn change

[Sveinung Kvilhaugsvik]

Follow-up Comment #10, bug #24018 (project freeciv):

I contacted XYZ.

Based on my understanding of his reply (XYZ: correct me if I'm wrong) there
were performance problems in 2.4 too.

He suggested to reduce the number of Engineers.

_I'm about to measure how much exactly it costs in case of europe_1901's turn
change._
If we end up changing the scenario to make it more AI player friendly I'll
keep an unfixed copy for AI benchmarking.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6592] Mark string vector strings in packets.def

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Mark string vector strings in packets.def
 Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 12 Nov 2015 12:09:19 AM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0, 2.5.2

___

Details:

Use a field type alias to STRING to make the change as unintrusive as possible
for now. I have verified that there is no difference in the code generated by
generate_packets.py.

(Kept unintrusive so it can go into 2.5. I think a follow up patch that
changes generate_packets.py, dataio etc so the string vector encoding and
decoding becomes a filed type would be a good idea)



___

File Attachments:


---
Date: Thu 12 Nov 2015 12:09:19 AM UTC  Name:
3.0-and-2.6--Mark-string-vector-strings-in-packets.def.patch  Size: 4kB   By:
sveinung


---
Date: Thu 12 Nov 2015 12:09:19 AM UTC  Name:
2.5-Mark-string-vector-strings-in-packets.def.patch  Size: 3kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3729] Attacking player specific reverse pathfinding map for cities

[Marko Lindqvist]

Follow-up Comment #2, patch #3729 (project freeciv):

Later it has turned out that the main benefit of this patch is handling of
movement bonus effects. Otherwise attacker with movement bonus that the
defender does not have, could attack sooner than expected, in many cases
taking empty city before defending player felt urgency to buy defender. 

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6591] assess_danger(): setup assess_turns outside loop

[Marko Lindqvist]

URL:
  

 Summary: assess_danger(): setup assess_turns outside loop
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 12 Nov 2015 12:27:29 AM EET
Category: ai
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.5.2, 2.6.0, 3.0.0

___

Details:

More cleanup than optimization:
Move setting of assess_turns outside of the opponent iterating loop. 



___

File Attachments:


---
Date: Thu 12 Nov 2015 12:27:29 AM EET  Name: AssessTurnsOutsideLoop.patch 
Size: 1kB   By: cazfi


---
Date: Thu 12 Nov 2015 12:27:29 AM EET  Name: AssessTurnsOutsideLoop-S2_5.patch
 Size: 1kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europe_1901's turn change

[Marko Lindqvist]

Follow-up Comment #9, bug #24018 (project freeciv):

The one big performance hit we've knowingly added in recent years is patch
#3729. I'm about to measure how much exactly it costs in case of europe_1901's
turn change.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24047] Qt client - crash in city dialog with context menu

[mir3x]

Update of bug #24047 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #1:

Seems also message boxes causes crash on turn change.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6550] Optimize is_move_cardinal()

[Marko Lindqvist]

Update of patch #6550 (project freeciv):

 Summary: Write base_get_direction_for_step() macros open,
discard unnecessary parts => Optimize is_move_cardinal()


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6550] Write base_get_direction_for_step() macros open, discard unnecessary parts

[Marko Lindqvist]

Update of patch #6550 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: 2.5.x, 2.6.0, 3.0.0 => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #2:

Scrap that previous patch, and optimize is_cardinal_move() directly, at least
for the worst case (direction is *not* cardinal, or is the very last cardinal
direction to check)

Old code called get_direction_for_step() and then compared if the direction
returned is cardinal one. Under the hood this expanded to:
- Iterating through all the legal directions
- Comparing if move to that direction would match the move we're checking
- Once matching direction is found, check if it's cardinal one

New code cuts out function call overhead and:
- Iterates through cardinal directions only (not so many directions to check)
- Compares if move to that direction matches the move we're checking -> if it
does, it's cardinal move
- If no matches found -> move is not cardinal. No need for separate check of
direction cardinality


(file #25726)
___

Additional Item Attachment:

File name: IsMoveCardinalOptimize.patch   Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23998] best_act used uninitialized in autosettlers -warning

[Marko Lindqvist]

Update of bug #23998 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.5.2, 2.6.0, 3.0.0

___

Follow-up Comment #1:

This seems like we had a bug here. We try to make unit to execute task even
when we never even tried to look up task for it.
I think units without UTYF_SETTLERS, but with UTYF_CITIES (causing them to
reach this autosettler code regardless) could be affected.

Fix attached


(file #25725)
___

Additional Item Attachment:

File name: OnlySettlersAutosettle.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23986] Compiling with clang spawns a lot of warnings

[Marko Lindqvist]

Update of bug #23986 (project freeciv):

 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23986] Compiling with clang spawns a lot of warnings

[Marko Lindqvist]

Update of bug #23986 (project freeciv):

Category:None => bootstrap  
  Status:None => Duplicate  
 Assigned to:None => cazfi  

___

Follow-up Comment #1:

-Wtautological compare was handled in patch #6499, other cases have been
handled in other tickets.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6590] Sandbox summary to dismiss AI performance, savegame compatibility

[Marko Lindqvist]

URL:
  

 Summary: Sandbox summary to dismiss AI performance, savegame
compatibility
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 11 Nov 2015 09:45:04 PM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0, 3.0.0

___

Details:

Add AI performance and savegame compatibility to the list of things we don't
care about in sandbox ruleset.



___

File Attachments:


---
Date: Wed 11 Nov 2015 09:45:04 PM EET  Name: SandboxDissAISGCompat.patch 
Size: 620B   By: cazfi


---
Date: Wed 11 Nov 2015 09:45:04 PM EET  Name: SandboxDissAISGCompat-S2_6.patch 
Size: 658B   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6532] Single barbarian nation to sandbox

[Marko Lindqvist]

Update of patch #6532 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6556] Send packet-like structures without extra copy-operation

[Marko Lindqvist]

Update of patch #6556 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6589] Set rulesetdir to 'default' in most supplied scenario maps

[Marko Lindqvist]

URL:
  

 Summary: Set rulesetdir to 'default' in most supplied
scenario maps
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 11 Nov 2015 08:42:24 PM EET
Category: rulesets
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Set rulesetdir to 'default' in those supplied scenario maps where it doesn't
break compatibility. Exceptions are:
- tutorial is customized for civ2civ3 -> shouldn't be loaded with
freeciv-web's current default ruleset
- tileset_demo gives errors about illegal irrigation placement when loaded
with default = civ2civ3 ruleset, it requires 'classic' (we may want to rework
this in another ticket)

This is targeted to TRUNK only -> 'default' = 'civ2civ3'. There's no need to
make things more complex by having S2_6 to load 'default' -> 'classic' instead
of direct 'classic' as there's no freeciv-web to load S2_6 scenarios with its
own view of what 'default' means.



___

File Attachments:


---
Date: Wed 11 Nov 2015 08:42:24 PM EET  Name: DefaultRulesetScenarios.patch 
Size: 15kB   By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6541] Support TRUNK-style 'default' ruleset in scenario

[Marko Lindqvist]

Update of patch #6541 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24052] Science report progress bar crash when research not set

[Marko Lindqvist]

Update of bug #24052 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24018] The AI players are extremely slow during europe_1901's turn change

[Sveinung Kvilhaugsvik]

Update of bug #24018 (project freeciv):

 Summary: The AI players are extremely slow during
europa_1901's turn change => The AI players are extremely slow during
europe_1901's turn change


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24057] Multiplayer ruleset using E.TECH_GAIN when should use E.TECH_EMBASSY

[Marko Lindqvist]

Update of bug #24057 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6417] client goto: respect the final order

[Sveinung Kvilhaugsvik]

Update of patch #6417 (project freeciv):

  Depends on: => patch #6588


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6588] Centralize action actor target distance rules

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: Centralize action actor target distance rules
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 11 Nov 2015 05:26:39 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Store an action's the minimum and maximum legal distance between actor and
target for in the action structure it self.



___

File Attachments:


---
Date: Wed 11 Nov 2015 05:26:39 PM UTC  Name:
0009-Centralize-action-actor-target-distance-rules.patch  Size: 14kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22960] Lots of runtime floating point warnings about CONN_PING_INFO

[Marko Lindqvist]

Update of bug #22960 (project freeciv):

  Status:  Ready For Test => Need Info  

___

Follow-up Comment #10:

Not closing the ticket yet, want to see if the error still occurs.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6352] Governor range settings

[Marko Lindqvist]

Update of patch #6352 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16184] Governor minimal surplus of -20 not low enough

[Marko Lindqvist]

Update of bug #16184 (project freeciv):

  Status:None => Duplicate  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #4:

Patch #6352 adds options to control the min and max.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #3326] Change range for city gov from -20<>20 to -inf<-19<>20

[Marko Lindqvist]

Update of patch #3326 (project freeciv):

  Status:None => Duplicate  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 

___

Follow-up Comment #3:

Patch #6352 adds options to control the min and max.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6587] The player is responsible for the illegal action

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: The player is responsible for the illegal action
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 11 Nov 2015 03:33:04 PM UTC
Category: general
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0

___

Details:

Assert that the player is responsible for the illegal action before bothering
him with a message about it or punishing him for it.



___

File Attachments:


---
Date: Wed 11 Nov 2015 03:33:04 PM UTC  Name:
0008-The-player-is-responsible-for-the-illegal-action.patch  Size: 13kB   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6586] ruledit: take ruleset as an argument

[Sveinung Kvilhaugsvik]

Update of patch #6586 (project freeciv):

  Depends on: => patch #6585


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6586] ruledit: take ruleset as an argument

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: ruledit: take ruleset as an argument
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 11 Nov 2015 02:49:38 PM UTC
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Wed 11 Nov 2015 02:49:38 PM UTC  Name:
0008-ruledit-take-ruleset-as-an-argument.patch  Size: 4kB   By: sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6585] ruledit: load ruleset when enter is pressed

[Sveinung Kvilhaugsvik]

URL:
  

 Summary: ruledit: load ruleset when enter is pressed
 Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 11 Nov 2015 02:48:31 PM UTC
Category: freeciv-ruledit
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 3.0.0, 2.6.0

___

Details:





___

File Attachments:


---
Date: Wed 11 Nov 2015 02:48:31 PM UTC  Name:
0007-ruledit-load-ruleset-when-enter-is-pressed.patch  Size: 986B   By:
sveinung



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev