Re: [Freeciv-Dev] some regressions

2016-06-25 Thread Christian Knoke 
Christian Knoke wrote on Jun 25, 21:29 (+0200):
> Marko Lindqvist wrote on Jun 25, 21:19 (+0300):
> > On 25 June 2016 at 15:20, Christian Knoke  wrote:

> > > when I manually save the game in freeciv-gtk3, and then quit, the server
> > > does an additional quitidle save. It didn't do that before.
> > 
> >  Server forked from the client? So the client failed to kill the
> > server, and instead it waited for the idle time?
> 
> I think so, too. 
> 
> As savefile dates tell me, it happens sometimes, and sometimes not, when I
> save and quit. I will watch.

Try attached savegame with rev 33022 from 2.5.4+ GTK3 client.

/set savename test
save (from menue)
quit (from menue)

> From savefile dates, the first occurence of this was on June, 13th:

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.


sixplayer-T0163-Y01130-manual.sav.bz2
Description: Binary data
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7310] Msys2 environment 160618

2016-06-25 Thread Marko Lindqvist 
Update of patch #7310 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24468] Commandline option parameters allocated with get_option_malloc() not freed

2016-06-25 Thread Marko Lindqvist 
Follow-up Comment #4, bug #24468 (project freeciv):

TRUNK & S2_6 versions updated against svn

(file #27678, file #27679)
___

Additional Item Attachment:

File name: FreeGetOptionsMallocResults-2.patch Size:23 KB
File name: FreeGetOptionsMallocResults-S2_6-2.patch Size:22 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7314] Server option --keep for opening persistent metaconnection

2016-06-25 Thread Marko Lindqvist 
Update of patch #7314 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] some regressions

2016-06-25 Thread Christian Knoke 
Marko Lindqvist wrote on Jun 25, 21:19 (+0300):
> On 25 June 2016 at 15:20, Christian Knoke  wrote:
> >
> > Two bugs in todays 2.5+:
> >
> > when gunpowder is invented, legions aren't upgraded to musceteers any more
> > in that turn, at least not all
> 
>  You mean production of legions? 

yes.

> That's not a regression. It depends on what cities are handled before
> cumulative bulb count gets high enough to provide the tech, and which ones
> are handled after.

I know it's been that way for a long time, but I got the impression this had
been improved at some point, so that production would be updated by the
server immidiate and complete (in a second run through the cities).

> > when I manually save the game in freeciv-gtk3, and then quit, the server
> > does an additional quitidle save. It didn't do that before.
> 
>  Server forked from the client? So the client failed to kill the
> server, and instead it waited for the idle time?

I think so, too. 

As savefile dates tell me, it happens sometimes, and sometimes not, when I
save and quit. I will watch.

From savefile dates, the first occurence of this was on June, 13th:

$ ls -ltr *manual* *quitidle*

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6616] Sandbox: Hermit's Place

2016-06-25 Thread Marko Lindqvist 
Update of patch #6616 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #1:

The existing patch is good as it is, now that engine side fixes are in place.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24796] Terrain changes do not update continent id information

2016-06-25 Thread Marko Lindqvist 
URL:
  

 Summary: Terrain changes do not update continent id
information
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Jun 2016 09:34:55 PM EEST
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 
 Contains string changes: None

___

Details:

This came up while trying to fix bug #23179. When terrain changes from land to
ocean, or ocean to land, continent numbers are not updated. This can get
complicated if continents gets split or merged.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] some regressions

2016-06-25 Thread Marko Lindqvist 
On 25 June 2016 at 15:20, Christian Knoke  wrote:
>
> Two bugs in todays 2.5+:
>
> when gunpowder is invented, legions aren't upgraded to musceteers any more
> in that turn, at least not all

 You mean production of legions? That's not a regression. It depends
on what cities are handled before cumulative bulb count gets high
enough to provide the tech, and which ones are handled after.

> when I manually save the game in freeciv-gtk3, and then quit, the server
> does an additional quitidle save. It didn't do that before.

 Server forked from the client? So the client failed to kill the
server, and instead it waited for the idle time?


 - ML

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23179] Borders not adjusted when land terrain changes to ocean

2016-06-25 Thread Marko Lindqvist 
Update of bug #23179 (project freeciv):

  Status:  Ready For Test => None   

___

Follow-up Comment #2:

Since the "continent number" is not set correctly for the tile that has
changed, asserts are failing.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21347] Ability to not save resources not exposed to scenario editor

2016-06-25 Thread Marko Lindqvist 
Update of bug #21347 (project freeciv):

  Status:  Ready For Test => Duplicate  
 Open/Closed:Open => Closed 

___

Follow-up Comment #12:

-> patch #7325

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7325] Expose 'have_resources' to editor

2016-06-25 Thread Marko Lindqvist 
URL:
  

 Summary: Expose 'have_resources' to editor
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Jun 2016 04:37:47 PM EEST
Category: editor
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 
 Contains string changes: None

___

Details:

This was already attempted at bug #21347, but it had to be reverted. The
problems were related to the fact that once there's units in game, changing
parts of the map is much more challenging. We probably want to make this
functionality available only in such scenarios where players are not saved.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] some regressions

2016-06-25 Thread Christian Knoke 

Two bugs in todays 2.5+:

when gunpowder is invented, legions aren't upgraded to musceteers any more
in that turn, at least not all

when I manually save the game in freeciv-gtk3, and then quit, the server
does an additional quitidle save. It didn't do that before.

Christian

-- 
Christian Knoke* * *http://cknoke.de
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.

___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24778] freeciv-manual buildings table not closed

2016-06-25 Thread Frank 
Follow-up Comment #6, bug #24778 (project freeciv):

Thanks, some missing alio pictures on the wiki are now the last issue ;-)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24795] Fix display of link marks

2016-06-25 Thread Jacob Nevins 
Update of bug #24795 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_6-link-marks-fix.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24790] 2.6alpha local options crash

2016-06-25 Thread Frank 
Follow-up Comment #3, bug #24790 (project freeciv):

The intro screen says r32928. Madness, apparently I shreddered the setup file.
But http://forum.freeciv.org/f/viewtopic.php?f=14&t=315&start=60#p5101
confirms r32928.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24795] Fix display of link marks

2016-06-25 Thread Jacob Nevins 
URL:
  

 Summary: Fix display of link marks
 Project: Freeciv
Submitted by: jtn
Submitted on: Sat 25 Jun 2016 11:19:35 AM BST
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.6.0, 3.0.0
 Contains string changes: No

___

Details:

patch #7299 "Fix some shadow warnings seen on OpenBSD / set 6" slightly broke
the drawing of the link marks.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7312] Don't be afraid to switch from building unit to building building

2016-06-25 Thread Marko Lindqvist 
Update of patch #7312 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6915] Saveturns counter value at the beginning of the new game

2016-06-25 Thread Marko Lindqvist 
Update of patch #6915 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #1:

Patch to count turn 0 towards saveturns. As a bonus feature, we now get, with
saveturns = 1, save from the game starting situation rather than after one
turn.

(file #27676)
___

Additional Item Attachment:

File name: ZeroTurnSave.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24072] Segmentation fault with traderoutes

2016-06-25 Thread Marko Lindqvist 
Update of bug #24072 (project freeciv):

  Status:None => Duplicate  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [task #7986] Tracking release 2.5.5

2016-06-25 Thread Marko Lindqvist 
Update of task #7986 (project freeciv):

  Depends on: => patch #7231


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #7231] Suppress theme warnings from gtk3-client

2016-06-25 Thread Marko Lindqvist 
Update of patch #7231 (project freeciv):

  Status:None => Ready For Test 
 Summary: Replace replaceable deprecated pseudo-classes from
gtk3-client theme => Suppress theme warnings from gtk3-client

___

Follow-up Comment #3:

> Have to see if we can suppress those warnings.

Attached patch wraps Gtk Warning logging to log_verbose(). This behavior can
be avoided (to use default gtk logging) with commandline option
--gtk-warnings.

(file #27674, file #27675)
___

Additional Item Attachment:

File name: Gtk3GtkWarns.patch Size:2 KB
File name: Gtk3GtkWarns-S2_5.patchSize:3 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24794] Typo "patttern" in fracture generator help

2016-06-25 Thread Marko Lindqvist 
URL:
  

 Summary: Typo "patttern" in fracture generator help
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sat 25 Jun 2016 10:40:06 AM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 3.0.0
 Contains string changes: None

___

Details:

Fix attached



___

File Attachments:


---
Date: Sat 25 Jun 2016 10:40:06 AM EEST  Name: Pa3tern.patch  Size: 802B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #6882] Fracture map generator (2.91)

2016-06-25 Thread Marko Lindqvist 
Update of patch #6882 (project freeciv):

  Status:  Ready For Test => Done   
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev