Re: [Freeciv-Dev] (PR#39643) [Bug] Internal server exits silently for ruleset errors
http://bugs.freeciv.org/Ticket/Display.html?id=39643 > On 15/09/2007, Marko Lindqvist wrote: > > On 31/08/2007, Marko Lindqvist wrote: > > S2_1 solution might be just to send chat message to all clients > > before final exit(). > > Here are patches to send that chat message. > > Not that user is likely to notice it. gtk -client goes back to main > menu immediately when server dies closing chat -window. Maybe new kind > of event - which has popups enabled by default - should be used for > this. I'll leave improvements to future patches (and probably to trunk/S2_2 only). These I consider ready for commit. - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39643) [Bug] Internal server exits silently for ruleset errors
http://bugs.freeciv.org/Ticket/Display.html?id=39643 > On 31/08/2007, Marko Lindqvist wrote: > > I have always hated how ruleset loading code just exit() for any > error in ruleset ... > - If internally server quits like that, no explanation is provided > for user (client) ... > S2_1 solution might be just to send chat message to all clients > before final exit(). Here are patches to send that chat message. Not that user is likely to notice it. gtk -client goes back to main menu immediately when server dies closing chat -window. Maybe new kind of event - which has popups enabled by default - should be used for this. - ML RulesetError_39643_TRUNK.diff.bz2 Description: BZip2 compressed data RulesetError_39643.diff.bz2 Description: BZip2 compressed data ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39643) [Bug] Internal server exits silently for ruleset errors
http://bugs.freeciv.org/Ticket/Display.html?id=39643 > I have always hated how ruleset loading code just exit() for any error in ruleset (printing error message to server console, but still). Now it appeared to me that: - If internally server quits like that, no explanation is provided for user (client) - This can happen to end-user (with tested and released modpack) simply because modpack is outdated, and incompatible with new Freeciv version in use Without seeing code just now, I assume that handling those errors in a sane way and returning to command prompt after ruleset load failure is too complicated and bugprone rewrite for S2_1. S2_1 solution might be just to send chat message to all clients before final exit(). - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
