Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 I have verified that a unit sentried and then moved does not lose focus. The report accurately describes the problem. I have not yet found the problem. Unfortunately, there seem to be several methods used for every test, and for every action. I'm going blind trying to understand the subtle differences (usually, there's no good reason). The root cause appears to be documented in packhand.c: Exception: When the client puts a unit in focus, it's status is set to idle immediately, before informing the server about the new status. This is because the server can never deny a request for idle, and should not be concerned about which unit the client is focusing on. Unfortunately, this means the client and server fields are unsynchronized, while elsewhere code always assumes they are the same. I'm going blind trying to find these subtle differences, too. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 Jason Dorje Short wrote: This was introduced in 39817. I've been over and over my code in PR#39817 today. I don't see the problem. Apparently, it needs more eyeballs. I'll leave this to Jason. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 [wsimpson - Fr 16. Nov 2007, 09:32:20]: Daniel Markstedt wrote: Not necessarily. It may also be something that has ceased to work as intended, regardless of having been previously reported as a bug or not. Sorry, perhaps you're not a native English speaker (although I've no previous cause to complain), but these terms have specific meanings in computer science. Sometimes, new bugs are just broken code Regression testing is usually a suite of tests, usually developed by experience with previous bugs. For more background, the en.wikipedia article isn't too bad. Your suggested en.wikipedia article (http://en.wikipedia.org/wiki/Regression_testing) says: Regression bugs occur whenever software functionality that previously worked as desired, stops working or no longer works in the same way that was previously planned. Typically regression bugs occur as an unintended consequence of program changes. And from http://en.wikipedia.org/wiki/Software_regression: A software regression is a software bug which makes a feature stop working after a certain event (system upgrade, system patching, daylight saving time switch, etc.) This doesn't read like re-introduction of a previously existing bug to me. It might be a special meaning of the word regression, but obviously not the one and only. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 This was introduced in 39817. I'm not sure why but at a guess the unsentried unit is being put onto the urgent-focus queue then refocused later when it runs out of moves and unit focus is supposed to advance. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] (PR#39868) [regression] unit woken up from sentry not properly deselected
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 On 11/16/07, Christian Prochaska [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39868 [wsimpson - Fr 16. Nov 2007, 09:32:20]: Daniel Markstedt wrote: Not necessarily. It may also be something that has ceased to work as intended, regardless of having been previously reported as a bug or not. Sorry, perhaps you're not a native English speaker (although I've no previous cause to complain), but these terms have specific meanings in computer science. Sometimes, new bugs are just broken code Regression testing is usually a suite of tests, usually developed by experience with previous bugs. For more background, the en.wikipedia article isn't too bad. Your suggested en.wikipedia article (http://en.wikipedia.org/wiki/Regression_testing) says: Regression bugs occur whenever software functionality that previously worked as desired, stops working or no longer works in the same way that was previously planned. Typically regression bugs occur as an unintended consequence of program changes. And from http://en.wikipedia.org/wiki/Software_regression: A software regression is a software bug which makes a feature stop working after a certain event (system upgrade, system patching, daylight saving time switch, etc.) This doesn't read like re-introduction of a previously existing bug to me. It might be a special meaning of the word regression, but obviously not the one and only. Perhaps the term is used differently in different branches of the software engineering field/business. Where I happen to work (web browser) the term is used in the sense I described. ~Daniel ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
