On 24 August 2014 17:10,  <sveinun...@users.sourceforge.net> wrote:
> Author: sveinung
> Date: Sun Aug 24 16:10:20 2014
> New Revision: 26014
>
> URL: http://svn.gna.org/viewcvs/freeciv?rev=26014&view=rev
> Log:
> New diplomatic relationship requirement type property foreign
>
> Only support the local range since that is the only place it makes sense.
>
> See patch #5068
>
> Modified:
>     trunk/common/fc_types.h
>     trunk/common/player.c
>     trunk/common/player.h
>     trunk/common/requirements.c
>     trunk/doc/README.effects

 No fc_version there -> obviously no network capability string change.

> -/* Asymmetric diplomatic relations.
> +/* Other diplomatic relation properties.
>   *
>   * The first element here is numbered DS_LAST
>   */

 There's no comment that this is part of network protocol. Is that really so?
 How is the DiplRel requirement sent to client so that these values do
not matter?

> -#define SPECENUM_NAME diplrel_asym
> -#define SPECENUM_VALUE7 DRA_GIVES_SHARED_VISION
> +#define SPECENUM_NAME diplrel_other
> +#define SPECENUM_VALUE7 DRO_GIVES_SHARED_VISION
>  #define SPECENUM_VALUE7NAME N_("Gives shared vision")
> -#define SPECENUM_VALUE8 DRA_RECEIVES_SHARED_VISION
> +#define SPECENUM_VALUE8 DRO_RECEIVES_SHARED_VISION
>  #define SPECENUM_VALUE8NAME N_("Receives shared vision")
> -#define SPECENUM_VALUE9 DRA_HOSTS_EMBASSY
> +#define SPECENUM_VALUE9 DRO_HOSTS_EMBASSY
>  #define SPECENUM_VALUE9NAME N_("Hosts embassy")
> -#define SPECENUM_VALUE10 DRA_HAS_EMBASSY
> +#define SPECENUM_VALUE10 DRO_HAS_EMBASSY
>  #define SPECENUM_VALUE10NAME N_("Has embassy")
> -#define SPECENUM_VALUE11 DRA_HOSTS_REAL_EMBASSY
> +#define SPECENUM_VALUE11 DRO_HOSTS_REAL_EMBASSY
>  #define SPECENUM_VALUE11NAME N_("Hosts real embassy")
> -#define SPECENUM_VALUE12 DRA_HAS_REAL_EMBASSY
> +#define SPECENUM_VALUE12 DRO_HAS_REAL_EMBASSY
>  #define SPECENUM_VALUE12NAME N_("Has real embassy")
> -#define SPECENUM_VALUE13 DRA_HAS_CASUS_BELLI
> +#define SPECENUM_VALUE13 DRO_HAS_CASUS_BELLI
>  #define SPECENUM_VALUE13NAME N_("Has Casus Belli")
> -#define SPECENUM_VALUE14 DRA_PROVIDED_CASUS_BELLI
> +#define SPECENUM_VALUE14 DRO_PROVIDED_CASUS_BELLI
>  #define SPECENUM_VALUE14NAME N_("Provided Casus Belli")
> +#define SPECENUM_VALUE15 DRO_FOREIGN
> +#define SPECENUM_VALUE15NAME N_("Is foreign")
>  #include "specenum_gen.h"


 - ML

_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to