[Freeciv-Dev] [bug #13636] [patch] update for migration
Update of bug #13636 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
Follow-up Comment #4, bug #13636 (project freeciv): I fixed one more thing. - check_city_migrations() definition missed 'void' parameter list 1. Since this is C, empty parameter list must be given as 'void' 2. Parameter lists must be identical in declaration and definition (file #6004) ___ Additional Item Attachment: File name: MigrationUpdt_13636.diff Size:8 KB ___ Reply to this item at: http://gna.org/bugs/?13636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
Follow-up Comment #3, bug #13636 (project freeciv):
updated version; changes:
- check variable declaration
- fix coding style (beginning of a function '{' on the
next line)
- fix !pplayer
(file #5981)
___
Additional Item Attachment:
File name: version2-13636-migration.patch.diff Size:9 KB
___
Reply to this item at:
http://gna.org/bugs/?13636
___
Nachricht geschickt von/durch Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
Follow-up Comment #2, bug #13636 (project freeciv): Also, CodingStyle dictates that variables are never declared in the middle of the function. You move some variable declarations from the beginning of the city_migration_score() to the middle. ___ Reply to this item at: http://gna.org/bugs/?13636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
Follow-up Comment #1, bug #13636 (project freeciv):
+ players_iterate(pplayer) {
+if (!pplayer || !pplayer-cities) {
Check for !pplayer is not needed inside players_iterate().
___
Reply to this item at:
http://gna.org/bugs/?13636
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
URL: http://gna.org/bugs/?13636 Summary: [patch] update for migration Project: Freeciv Submitted by: syntron Submitted on: Samstag 06.06.2009 um 13:09 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: this patch updates the migration calculation changes: - minimum for mgr_*change is 0 - changed logic of the function calls - score calculation is moved and only executed if the value of mgr_score_calc_turn (a new variable in the city struct) is not equal to the current turn - define default values for city-migration_score and city-mgr_score_calc_turn I also added information about the used equations to http://freeciv.wikia.com/wiki/Math_of_Freeciv ___ File Attachments: --- Date: Samstag 06.06.2009 um 13:09 Name: migration.patch.diff Size: 9kB By: syntron http://gna.org/bugs/download.php?file_id=5899 ___ Reply to this item at: http://gna.org/bugs/?13636 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13636] [patch] update for migration
Update of bug #13636 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13636 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
