[Freeciv-Dev] [bug #13846] recursion checking for the read command
Update of bug #13846 (project freeciv): Status:None = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #7, bug #13846 (project freeciv):
I think book's comment about wrappers asked for something like this:
bool handle_stdin_input(...)
{
return handle_stdin_input_real(... , 0);
}
bool read_init_script(...)
{
return read_init_script_real(... , 0);
}
static bool handle_stdin_input_real(... , int recursion)
{
...
}
static bool read_init_script_real(..., int recursion)
{
...
handle_stdin_input_real(... , recursion + 1);
...
}
___
Reply to this item at:
http://gna.org/bugs/?13846
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #8, bug #13846 (project freeciv): OK; after a _long_ time looking at the code I think I see what you mean. I will prepare an updated patch ... ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #6, bug #13846 (project freeciv): updated patch changes: - max 10 calls to read - check is possible for the read command (used for voting?) (file #6132) ___ Additional Item Attachment: File name: gna13846-recursion-checking-for-the-read-command.patch Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Update of bug #13846 (project freeciv): Assigned to:None = cazfi ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #5, bug #13846 (project freeciv): I added 'bool read_cmd'. I thin this can be changed to 'int read_level' and for 'read_level = 5' there will be an error message ... ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
URL: http://gna.org/bugs/?13846 Summary: recursion checking for the read command Project: Freeciv Submitted by: syntron Submitted on: Mittwoch 01.07.2009 um 21:42 Category: general Severity: 2 - Minor Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Release: Operating System: None ___ Details: see summery ___ File Attachments: --- Date: Mittwoch 01.07.2009 um 21:42 Name: 0001-recursion-checking-for-the-read-command.patch Size: 6kB By: syntron http://gna.org/bugs/download.php?file_id=6107 ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #1, bug #13846 (project freeciv): add missing changes to stdinhand.h (file #6108) ___ Additional Item Attachment: File name: 0001-recursion-checking-for-the-read-command.patch Size:7 KB ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #2, bug #13846 (project freeciv): Just infinite recursion should be prohibited, not any read inside other read. That is, original file should not read itself, nor file that reads the original, nor file that reads file that read original... but otherwise read should be allowed. ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #13846] recursion checking for the read command
Follow-up Comment #4, bug #13846 (project freeciv): Please no static variables. Use a context argument and a wrapper/recursive function pair. Ask if you need an example. なんじゃそりゃ。 ___ Reply to this item at: http://gna.org/bugs/?13846 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
