[Freeciv-Dev] [bug #15373] Fix health calculation

[Matthias Pfafferodt]

Update of bug #15373 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation

[Matthias Pfafferodt]

Follow-up Comment #6, bug #15373 (project freeciv):

updated patch including the fix for the condition

(file #8178)
___

Additional Item Attachment:

File name: 20100221-trunk-update-calculation-of-city-illness.patch Size:5 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation

[Jacob Nevins]

Follow-up Comment #5, bug #15373 (project freeciv):

Another issue found while investigating bug #15422: get_trade_illness() has
the following code:


if (trade_city != NULL
&& trade_city->turn_plague != -1
&& trade_city->turn_plague - game.info.turn < 5) {
/* ... call in sick ... */
}


This will always trigger once turn_plague is set for a city, as
trade_city->turn_plague <= game.info.turn, so the result of the subtraction
will be negative. So, once a city has had the plague, it will be infectious
forever, I think.

I assume the intention is that a city remains contagious only for about 5
turns; swapping the condition will give that result.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation

[Matthias Pfafferodt]

Update of bug #15373 (project freeciv):

Category:rulesets => general
  Status:None => Ready For Test 
 Assigned to:None => syntron


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation

[Matthias Pfafferodt]

Update of bug #15373 (project freeciv):

 Summary: Fix health calculation + add health effect to
default/effects.ruleset => Fix health calculation 

___

Follow-up Comment #4:

split this patch into two parts; this one includes only the changes to the
calculation of the city illness. I will open another bug report with the
changes to the ruleset.

This patch is for trunk and S2_2 (after 2.2.0 is released)

== patch comments ==

update calculation of city illness

* for testing the calculations I used floating point numbers but within the
freeciv codebase integers are used - this results in rounding errors (no
illness up to size 10); now the values are calculated using floats
* move the check for illness_min_size into city_illness() and offset the
starting of illness by this value; city will start with a low illness value
at a city size of 'illness_min_size + 1'
* cleanup comment for city_illness()

(file #8135)
___

Additional Item Attachment:

File name: 20100215-trunk-update-calculation-of-city-illness.patch Size:5 KB


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation + add health effect to default/effects.ruleset

[Jacob Nevins]

Update of bug #15373 (project freeciv):

 Release: 2.2.0-beta3 => 2.2.0-beta3,2.2.0-RC1  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation + add health effect to default/effects.ruleset

[Jacob Nevins]

Update of bug #15373 (project freeciv):

 Release: 2.2.0-beta3 => 2.2.0-beta3, 2.2.0-RC1 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation + add health effect to default/effects.ruleset

[Jacob Nevins]

Update of bug #15373 (project freeciv):

 Planned Release: => 2.2.1  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15373] Fix health calculation + add health effect to default/effects.ruleset

[Jacob Nevins]

Update of bug #15373 (project freeciv):

 Summary: add health effect to default/effects.ruleset => Fix
health calculation + add health effect to default/effects.ruleset

___

Follow-up Comment #3:

Wow, that certainly makes a difference!
I've repurposed this bug into a mongrel; it might yet be split.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev