[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[pepeto]

Update of bug #15440 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[pepeto]

Follow-up Comment #8, bug #15440 (project freeciv):

Typo. You're right.


(file #8244)
___

Additional Item Attachment:

File name: S2_2_translate_ruleset_help3.diff Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[Jacob Nevins]

Follow-up Comment #7, bug #15440 (project freeciv):

In the S2_2 version (file #8236, S2_2_translate_ruleset_help2.diff):


-#define HELP_RULESET_ITEM "About Ruleset"
+#define HELP_RULESET_ITEM _("About Ruleset")


That should be N_("..."), shouldn't it? (Trunk version looks right.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[pepeto]

Update of bug #15440 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #6:

New fixes attached, according to your right comments and what I should have
done previously.


(file #8235, file #8236)
___

Additional Item Attachment:

File name: trunk_translate_ruleset_help2.diff Size:1 KB
File name: S2_2_translate_ruleset_help2.diff Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[pepeto]

Update of bug #15440 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #5:

> Meant to say: I've tried this and the result compiles and works
> in English, but I haven't yet figured out how to test in other
> languages.

Not a problem.

Your solution is better I guess, I thought about it, but preferred a minimal
patch for the moment. I will redo it.

> Feels like this is a long-standing issue probably masked by the
> fact that the strings defined there are also duplicated across
> all the clients. (In fact, since the string "About Ruleset"
> appears i18n-marked in many clients,
> mystrdup(_(HELP_RULESET_ITEM)) should work without marking up
> helpdlg_g.h.

However, this would just push back the problem, if someone change that
string, it shouldn't be able to translate it later.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[Jacob Nevins]

Follow-up Comment #4, bug #15440 (project freeciv):

Meant to say: I've tried this and the result compiles and works in English,
but I haven't yet figured out how to test in other languages.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[Jacob Nevins]

Follow-up Comment #3, bug #15440 (project freeciv):

> In addition, when I select the appropriate menu, I get the last item, not
the _About Ruleset_ one.

I don't see this, but that's presumably because I'm running Freeciv in
English.

I'm slightly dubious about changing mystrdup(HELP_RULESET_ITEM) to
mystrdup(_("About Ruleset")), as this duplicates the string "About Ruleset"
in two places -- helpdata.c and client/include/helpdlg_g.h, where
HELP_RULESET_ITEM is defined.

Is the right fix not to change all the definitions in helpdlg_g.h from the
form

#define HELP_RULESET_ITEM "About Ruleset"

to

#define HELP_RULESET_ITEM N_("About Ruleset")

(and add client/include/helpdlg_g.h to po/POTFILES.in)? Then you could write
mystrdup(_(HELP_RULESET_ITEM)).

Feels like this is a long-standing issue probably masked by the fact that the
strings defined there are also duplicated across all the clients. (In fact,
since the string "About Ruleset" appears i18n-marked in many clients,
mystrdup(_(HELP_RULESET_ITEM)) should work without marking up helpdlg_g.h.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[pepeto]

Update of bug #15440 (project freeciv):

  Status:   Confirmed => Ready For Test 
 Assigned to:None => pepeto 

___

Follow-up Comment #2:

Fix attached.


(file #8191, file #8192)
___

Additional Item Attachment:

File name: trunk_translate_ruleset_help.diff Size:1 KB
File name: S2_2_translate_ruleset_help.diff Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[pepeto]

Update of bug #15440 (project freeciv):

  Status:None => Confirmed  
 Planned Release:   2.2.0 => 2.2.1  

___

Follow-up Comment #1:

In addition, when I select the appropriate menu, I get the last item, not the
_About Ruleset_ one.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #15440] Translation About Ruleset in Help menu

[anonymous]

URL:
  

 Summary: Translation About Ruleset in Help menu
 Project: Freeciv
Submitted by: None
Submitted on: Воскресенье 21.02.2010 at 10:23 CET
Category: client
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: svinin...@gmail.com
 Open/Closed: Open
 Release: 2.2.0-RC1
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.2.0

___

Details:

None display translation for string:

About Ruleset

You are playing Freeciv with default rules.






___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev