Re: [Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Sorry that I did forgot to close the ticket. Also thanks for doing all the work at the moment (closing all tickets, coding, ...)! Am Monday 13 September 2010 01:05:18 schrieben Sie: Update of bug #16644 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Update of bug #16644 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Follow-up Comment #9, bug #16644 (project freeciv): I will check it. I did test it and is working for the case mentioned in bug #14944. If there are no objections I will commit this patch this weekend. ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Follow-up Comment #6, bug #16644 (project freeciv): However, I never found a way to reproduce bug #14944. Could someone ensure it doesn't revert the fix for it? I hope you could do this for me? I will check it. bug #14944 was about the change from an int representation of the foggedborder setting (0/1) to TRUE/FALSE values (secfile_lookup_bool). In this patch I did remove the check for the number of cities (-1 != total_ncities) which this patch readds. So it still _should_ work ... Do you know if new savegames (version 2) work as expected? ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Follow-up Comment #7, bug #16644 (project freeciv): You are right, there is probably the same problem there. ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Follow-up Comment #8, bug #16644 (project freeciv): It is right in savegame2.c. Because we are sure dc_total is saved if fog of war is enabled. However, we could need the server to repair it if we need to test things about fog of war enabled/disabled. New version attached, but maybe not relevant. To you the honour to determine what to do... (file #10261) ___ Additional Item Attachment: File name: trunk_load_private_map3.diff Size:2 KB ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Update of bug #16644 (project freeciv): Assigned to:None = syntron ___ Follow-up Comment #5: However, I never found a way to reproduce bug #14944. Could someone ensure it doesn't revert the fix for it? I hope you could do this for me? ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Update of bug #16644 (project freeciv): Priority: 1 - Later = 5 - Normal ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Follow-up Comment #1, bug #16644 (project freeciv): Bug added at revision 16822 (bug #14944). It removes the test _is not from a unit only fog of war save file_. Another thing looks strange, the test assuring game.fogofwar really exists has disappear... ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Update of bug #16644 (project freeciv): Status:None = Ready For Test ___ Follow-up Comment #2: Fix attached that reestablish the old behaviour and allow to load the file correctly. However, I never found a way to reproduce bug #14944. Could someone ensure it doesn't revert the fix for it? (file #10199) ___ Additional Item Attachment: File name: trunk_load_private_map.diffSize:1 KB ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #16644] 1: Saved game contains incomplete map data
Follow-up Comment #3, bug #16644 (project freeciv): Real patch, not including the patch for bug #16642 attached. (file #10200) ___ Additional Item Attachment: File name: trunk_load_private_map2.diff Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?16644 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
