[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-12 Thread pepeto 

Update of bug #16655 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-10 Thread Matthias Pfafferodt 

Follow-up Comment #8, bug #16655 (project freeciv):

updated version of the patch with the changes proposed on comment #7

(file #10289)
___

Additional Item Attachment:

File name: 20100910-07-trunk-fix-log_normal-messages.patch Size:6 KB


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-10 Thread pepeto 

Update of bug #16655 (project freeciv):

Category:None = general
  Status:None = Ready For Test 
 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-08 Thread Matthias Pfafferodt 

Follow-up Comment #4, bug #16655 (project freeciv):

 Well, I have checked that too, but I doubt it is a good
 solution. I think some of those messages shouldn't be
 log_normal() but log_verbose(). 

I did check the messages and here are my ideas about possible changes of the
log levels:

mapgen_topology.c: These should be kept as log_normal() as they tell the user
about a change done to a setting he requested (map size).

utilities.c: The information is not that important, so it could be moved to
log_verbose().

savegame2.c: The messages are also only additional output. So they should be
log_verbose (loading /saving in format x) or log_debug (time needed to create
the secfile).

download.c: Keep it as log_normal() as the user wants to know this.

 Also, I noticed a translation with Q_() of the meta message
 that looks very strange, since this string can be set by the
 user. 

There do you find this?

___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-08 Thread pepeto 

Follow-up Comment #5, bug #16655 (project freeciv):

I totally agree with your analysis, I would have done exactly the same.

 Also, I noticed a translation with Q_() of the meta message
 that looks very strange, since this string can be set by the
 user.

 There do you find this?

Using _grep log_normal(\_:
server/sernet.c: log_normal(%s, Q_(get_meta_message_string()));


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-08 Thread Matthias Pfafferodt 

Follow-up Comment #6, bug #16655 (project freeciv):

updated patch including the changes mentioned in comment #5 and comment #3

 savegame2.c: The messages are also only additional output. So
 they should be log_verbose (loading /saving in format x) or
 log_debug (time needed to create the secfile). 

I did use for both log_verbose().

(file #10250)
___

Additional Item Attachment:

File name: 20100908-09-trunk-fix-log_normal-messages.patch Size:7 KB


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-08 Thread pepeto 

Follow-up Comment #7, bug #16655 (project freeciv):

 savegame2.c: The messages are also only additional output. So
 they should be log_verbose (loading /saving in format x) or
 log_debug (time needed to create the secfile).

 I did use for both log_verbose().

I would prefer personally the timing message in log_debug().

I don't think removing Q_() is a good idea. I will raise a new item to handle
the potential translation bug that maybe is spread a bit everywhere in the
server code...


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-07 Thread pepeto 

URL:
  http://gna.org/bugs/?16655

 Summary: Trunk contains not translated log_normal() messages
 Project: Freeciv
Submitted by: pepeto
Submitted on: mardi 07.09.2010 à 10:08
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.0

___

Details:

According to http://freeciv.wikia.com/wiki/Internationalization#LOG_NORMAL ,
they should!





___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-07 Thread Matthias Pfafferodt 

Follow-up Comment #1, bug #16655 (project freeciv):

add _() for all messages found in my local git tree by the following
command:

'git grep log_normal( | grep -v _('

(file #10235)
___

Additional Item Attachment:

File name: 20100907-09-trunk-translate-log_normal-messages.patch Size:6 KB


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-07 Thread pepeto 

Follow-up Comment #2, bug #16655 (project freeciv):

Well, I have checked that too, but I doubt it is a good solution. I think
some of those messages shouldn't be log_normal() but log_verbose().

Also, I noticed a translation with Q_() of the meta message that looks very
strange, since this string can be set by the user.


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16655] Trunk contains not translated log_normal() messages

2010-09-07 Thread Jacob Nevins 

Follow-up Comment #3, bug #16655 (project freeciv):

Attached a version of file #10235 with a couple of (pre-existing) typos
fixed.

(file #10239)
___

Additional Item Attachment:

File name: trunk-translate-log_normal-messages-bis.patch Size:5 KB


___

Reply to this item at:

  http://gna.org/bugs/?16655

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev