[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[pepeto]

Update of bug #16672 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[pepeto]

Update of bug #16672 (project freeciv):

 Assigned to:None => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[pepeto]

Update of bug #16672 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.2.4, 2.3.0   

___

Follow-up Comment #4:

Since civil war nations are more specific than parent nations, I agree it
should pick them first. Fixes attached.


(file #10304, file #10305)
___

Additional Item Attachment:

File name: trunk_city_name_suggestion_order.diff Size:1 KB
File name: S2_2_city_name_suggestion_order.diff Size:1 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[pepeto]

Follow-up Comment #3, bug #16672 (project freeciv):

If "naturalcitynames" is set, then it picks the first city of the list
including 1, 2 and 3 in the other. Else, it does the same except it has a
random factor. So if we are at the end of 1, it can pick a name of 2, etc...


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[J.M. Maalderink]

Follow-up Comment #2, bug #16672 (project freeciv):

Yes.

How does it work? It first exhausts 1, then 2 and then 3? Because I am under
the impression that at the moment it picks cities from both parent and civil
war nations after it has run out of its own cities.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[pepeto]

Follow-up Comment #1, bug #16672 (project freeciv):

Looking at the code. Actually, it chooses the cities in:
0 parent nations;
0 civil war nations;
0 all remaining nations.

I guess what you request is to invert the order of the two first items?


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #16672] civilwar_nations for city names

[J.M. Maalderink]

URL:
  

 Summary: civilwar_nations for city names
 Project: Freeciv
Submitted by: mixcoatl
Submitted on: Friday 09/10/2010 at 05:56
Category: general
Severity: 2 - Minor
Priority: 4
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

Something that has been annoying me for some time: when a nation has run out
if its city list it does not only start getting names from nations that are
listed as civilwar_nations in its ruleset, but also from nations in which it
is listed as civilwar_nation itself. So it does not only start giving names
of cities from subnational or related nations, but also from larger, outside
nations. This is especially annoying for EU members, since all of them are
civilwar_nations of the Europeans, and subsequently all other EU members
suddenly provide them with cities. So instead of just picking cities from the
Walloons or Flemish suddenly the Belgians start naming cities London or
Berlin, and instead of getting cities from Bavaria or Saxony the Germans
found cities called Athens and Stockholm.

There are two possible solutions:
- make it work only one-way. When run out of own cities nations will only
pick cities from civilwar_nations listed in its own ruleset
- preferably, add an extra option ("extra_cities" or "same_language" or so)
to list nations it should start pulling cities from if after it runs out of
its own cities. That has the additional benefir that it prevents linguistic
issues. Catalans should of course be a civilwar_nation for Spain, but the
Spanish shouldn't start naming cities Girona or Lleida when they already have
Gerona and Lérida. So if an extra_cities variable is added all subnational
(or otherwise related) nations independent of language can be added as
civilwar_nations, but only nations that have the same language should be
added as extra_cities.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev