[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Update of bug #17031 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Update of bug #17031 (project freeciv): Status: Confirmed = Ready For Test Assigned to:None = syntron ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Follow-up Comment #6, bug #17031 (project freeciv): I have miss-understood what you said. However, I think the best way would be to allow the savegame to restore the previous settings. PS: I don't understand why xsize * yxisze must be = 1000. ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Follow-up Comment #8, bug #17031 (project freeciv): I thought it was set to avoid maps of size 0. However, there is probably no reason to keep it. ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Follow-up Comment #4, bug #17031 (project freeciv): I don't think that this is the problem for the map size. Starting a new game with the right options will result in a map size lower than the minimum. There is no need to load/save the map: set minp 0 Option: minplayers has been set to 0. set topo WRAPX Option: topology has been set to Wrap East-West (WRAPX). set size 1 Option: size has been set to 1. start Starting game. 2: Woz rules the Hackers. 2: Cerberus rules the Chananeans. 2: Repanse de Schoye rules the Nestorians. 2: Septimius Odaenathus rules the Palmyrenes. 2: Morea rules the Dryads. 2: Creating a map of size 36 x 24 = 864 tiles (1000 requested). ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Follow-up Comment #3, bug #17031 (project freeciv): The reason is that it fails to restore the 'xsize' or 'ysize' because the combination of the both settings fail ('ysize' or 'xsize' was not set yet). It is close to bug #17032. ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Follow-up Comment #2, bug #17031 (project freeciv): I think the reason is that the size of the map is to small, i.e. xsize * ysize MIN_MAP_SIZE * 1000. The attached patch fixes it by increasig i_size by 1 for such cases. (file #11182) ___ Additional Item Attachment: File name: 2010-trunk-fix-map-size.patch Size:1 KB ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
URL: http://gna.org/bugs/?17031 Summary: Small maps corrupt save files Project: Freeciv Submitted by: asplode Submitted on: Sunday 11/07/2010 at 14:15 Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: svn rev.18424 Discussion Lock: Any Operating System: None Planned Release: ___ Details: If the map size is small enough, freeciv creates corrupted saves. To reproduce the problem: 1. Start a server. 2. Set size to 1, set minplayers to 0. 3. Start the game. 4. Save the game. 5. Quit the server. 6. Try to load the saved game. I have attached the errors that I am getting. ___ File Attachments: --- Date: Sunday 11/07/2010 at 14:15 Name: savegame-segfault.log Size: 1kB By: asplode http://gna.org/bugs/download.php?file_id=11135 ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17031] Small maps corrupt save files
Update of bug #17031 (project freeciv): Status:None = Confirmed Planned Release: = 2.3.0 ___ Follow-up Comment #1: It is because it doesn't load xsize and ysize simultaneous... ___ Reply to this item at: http://gna.org/bugs/?17031 ___ Message posté via/par Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev