[Freeciv-Dev] [bug #17958] Auto-Explore command not available for Trireme unit-class
Update of bug #17958 (project freeciv): Status: Ready For Test = Fixed Assigned to:None = cazfi Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?17958 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17958] Auto-Explore command not available for Trireme unit-class
Follow-up Comment #2, bug #17958 (project freeciv): Attached untested patch makes auto explore possible for all units that are not using fuel or losing hp. (file #15460) ___ Additional Item Attachment: File name: AutoExploreFuelCheck.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?17958 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17958] Auto-Explore command not available for Trireme unit-class
Update of bug #17958 (project freeciv): Status:None = Ready For Test Planned Release: = 2.3.3, 2.4.0, 2.5.0 ___ Reply to this item at: http://gna.org/bugs/?17958 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17958] Auto-Explore command not available for Trireme unit-class
Follow-up Comment #1, bug #17958 (project freeciv):
Found the reason why Helicopters, Aircrafts and Triremes cannot autoexplore.
The reason is that move_type is not Sea nor Land but Both, for these
unit classes.
If you look the following code, you can see that AutoExplore is only
available for Land or Sea units.
[client/control.c]
void key_unit_auto_explore(void)
{
unit_list_iterate(get_units_in_focus(), punit) {
if (can_unit_do_activity(punit, ACTIVITY_EXPLORE)) {
request_new_unit_activity(punit, ACTIVITY_EXPLORE);
}
} unit_list_iterate_end;
}
[common/client.c]
bool can_unit_do_activity(const struct unit *punit,
enum unit_activity activity)
{
return can_unit_do_activity_targeted(punit, activity, S_LAST, BASE_NONE);
}
bool can_unit_do_activity_targeted(const struct unit *punit,
enum unit_activity activity,
enum tile_special_type target,
Base_type_id base)
{
return can_unit_do_activity_targeted_at(punit, activity, target,
punit-tile, base);
}
bool can_unit_do_activity_targeted_at(const struct unit *punit,
enum unit_activity activity,
enum tile_special_type target,
const struct tile *ptile,
Base_type_id base)
{
[...]
case ACTIVITY_EXPLORE:
return (is_ground_unit(punit) || is_sailing_unit(punit));
[...]
}
[common/movement.c]
bool is_sailing_unittype(const struct unit_type *punittype)
{
return (utype_move_type(punittype) == SEA_MOVING);
}
bool is_ground_unittype(const struct unit_type *punittype)
{
return (utype_move_type(punittype) == LAND_MOVING);
}
On the other end, in order to be able to enter rivers, Trireme must have
move_type = Both
May a new cannot_explore flag be added in order to manage this?
___
Reply to this item at:
http://gna.org/bugs/?17958
___
Messaggio inviato con/da Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #17958] Auto-Explore command not available for Trireme unit-class
URL: http://gna.org/bugs/?17958 Summary: Auto-Explore command not available for Trireme unit-class Project: Freeciv Submitted by: alocritani Submitted on: lun 28 mar 2011 06:50:52 GMT Category: general Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: 2.3.0 beta3 Discussion Lock: Any Operating System: GNU/Linux Planned Release: ___ Details: Using experimental ruleset, the auto-explore command is not available for the trireme unit. I suppose it's related to the unit-class and not the single unit, because with default ruleset this command works normally. ___ Reply to this item at: http://gna.org/bugs/?17958 ___ Messaggio inviato con/da Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
