[Freeciv-Dev] [bug #18058] trunk: data/nation data/flags/Makefile.am inconsistence
Update of bug #18058 (project freeciv): Category:None = bootstrap Status:None = Fixed Assigned to:None = evyscr Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?18058 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18058] trunk: data/nation data/flags/Makefile.am inconsistence
Follow-up Comment #5, bug #18058 (project freeciv): Obvious fix to check_flags inspired by africa/south_africa. (file #13685) ___ Additional Item Attachment: File name: check_flags-space.diff Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18058 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18058] trunk: data/nation data/flags/Makefile.am inconsistence
Follow-up Comment #3, bug #18058 (project freeciv): I'd rather place this check_flags.sh under scripts/. Attached version has data_dir path adjusted accordingly. If nobody objects in 48h, I'll add this to version control. (file #13204) ___ Additional Item Attachment: File name: check_flags.sh Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18058 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18058] trunk: data/nation data/flags/Makefile.am inconsistence
Follow-up Comment #2, bug #18058 (project freeciv): Starting from #4. [freeciv]$ data/check_flags.sh liguria.svg is missing in data/flags/Makefile.am ..switzerland.png is missing ..switzerland-large.png is missing ..switzerland-shield.png is missing ..switzerland-shield-large.png is missing ..switzerland.svg is missing seljuk.svg is missing in data/flags/Makefile.am Total errors: 7 [freeciv]$ However swiss nation works ok. Because there are swiss*.png flags, I guess. Script is attached. 'let' is bashism so /bin/bash is used. (file #12911) ___ Additional Item Attachment: File name: check_flags.sh Size:0 KB ___ Reply to this item at: http://gna.org/bugs/?18058 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #18058] trunk: data/nation data/flags/Makefile.am inconsistence
URL:
http://gna.org/bugs/?18058
Summary: trunk: data/nation data/flags/Makefile.am
inconsistence
Project: Freeciv
Submitted by: evyscr
Submitted on: Сбт 23 Апр 2011 02:37:13
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: Any
Planned Release:
___
Details:
Good day!
Due to new nations added to data/nation and their flags added to data/flags
but not to data/flags/Makefile.am, gtk2 client becomes unable to connect to
network game. Quick fix is attached.
This makes me thinking about three things.
1. We may need to rewrite (and to move?) data/nation/Makefile.am.sh to
process both data/nation and data/flags makefiles.
2. We may need to do smth. to gtk2 client doesn't quit immediately after
discovery of absence any of nation flags. And '-d 3' looks like bad level to
see this error message to me.
3. We may need smth. like data/flags/unknown{,-large,-shield}.png
4(bonus). We need checks.
PS. Or am I only one who has this gtk2 client problem?
--
Thanks, evyscr
___
File Attachments:
---
Date: Сбт 23 Апр 2011 02:37:13 Name: trunk-flags-makefile.diff Size:
2kB By: evyscr
http://gna.org/bugs/download.php?file_id=12902
___
Reply to this item at:
http://gna.org/bugs/?18058
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
