[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-19 Thread Marko Lindqvist

Update of bug #18221 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?18221

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-16 Thread David Fernandez

Follow-up Comment #8, bug #18221 (project freeciv):

I think the old code that sells both buildings and units at same time was on
purpose, to avoid a situation where a player goes to bankrupt due to huge army
supported by gold.

Example: AI has 100 units supported by 1 gold each, and 10 banks, and it
loses -10 gold per turn (with 100% taxes to gold).
When treasury becomes negative (-10 in the worst case), a building is sold (a
bank gives 80 gold if I'm right), so there is no need to sell units, and next
turn AI will continue with -10 gold per turn or even worse due to the bank
sold.
This will happen again and again until AI has no banks and still 100 units
supported by gold that completely breaks his economy.

Actually, this is the only reason I can see for the existence of 3 different
gold_upkeep_style.
I used gold_upkeep_style = 2 because is the only one that forces to sell at
least one unit supported by gold everytime treasure goes negative.

___

Reply to this item at:

  http://gna.org/bugs/?18221

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-16 Thread Marko Lindqvist

Follow-up Comment #9, bug #18221 (project freeciv):

 I think the old code that sells both buildings and units at same
 time was on purpose

 That functionality should remain in normal situation. The problematic case
was when there was *no* units left to sell and it still tried to sell them in
addition to buildings or vice versa. New code sells only what one owns.

___

Reply to this item at:

  http://gna.org/bugs/?18221

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-15 Thread Marko Lindqvist

Follow-up Comment #7, bug #18221 (project freeciv):

- Fix also the problem that code tried to sell both buildings and units even
when there is only other kind available

(file #13206)
___

Additional Item Attachment:

File name: SellNeededNumberOfUnits_18221-2.diff Size:1 KB


___

Reply to this item at:

  http://gna.org/bugs/?18221

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-14 Thread Marko Lindqvist

Update of bug #18221 (project freeciv):

  Status:   Confirmed = Ready For Test 
 Planned Release: = 2.2.6, 2.3.0, 2.4.0
 Summary: Crash while playing custom Ruleset = Not enough
buildings/units sold to restore positive balance

___

Follow-up Comment #5:

Fix attached.

Don't really know any good workarounds for original reporter until fixed
version of freeciv is released.

(file #13202)
___

Additional Item Attachment:

File name: SellNeededNumberOfUnits_18221.diff Size:0 KB


___

Reply to this item at:

  http://gna.org/bugs/?18221

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #18221] Not enough buildings/units sold to restore positive balance

2011-06-14 Thread David Fernandez

Follow-up Comment #6, bug #18221 (project freeciv):

Ok, thanks, no hurry.
For now, gold upkeep style = 1 seems to avoid the crashes.

___

Reply to this item at:

  http://gna.org/bugs/?18221

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev