[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[anonymous]

URL:
  

 Summary: scrollbars not drawn correctly in gtk-2.0 client
 Project: Freeciv
Submitted by: None
Submitted on: Mon 05 Sep 2011 03:21:51 PM UTC
Category: None
Severity: 2 - Minor
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: galtge...@o2.pl
 Open/Closed: Open
 Release: 2.3.0
 Discussion Lock: Any
Operating System: GNU/Linux
 Planned Release: 

___

Details:

Unrelated to "drawing with cairo" topic.

If freeciv is using its own theme, scrollbars aren't drawn correctly - the
bottom/right stepper is truncated.

Honestly, the more I read about gtk theme engines, more confusing it gets,
but (by trial and error) I found that changing
GtkRange::trough_border=1
to
GtkRange::trough_border=0

fixes the problem.

On that note: it would be nice, if spinbutton's arrows would get similar
shadow (?), so they don't look so flat.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[Matthias Pfafferodt]

Follow-up Comment #1, bug #18607 (project freeciv):

> Honestly, the more I read about gtk theme engines, more
> confusing it gets, but (by trial and error) I found that
> changing 
>  GtkRange::trough_border=1 
>  to 
>  GtkRange::trough_border=0 
> fixes the problem. 
So you propose to change that in the gtkrc files? 


The "trough-border" style property
  "trough-border"gint  : Read
Spacing between thumb/steppers and outer trough bevel.
Allowed values: >= 0
Default value: 1

(see http://developer.gnome.org/gtk/2.24/GtkRange.html)

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[anonymous]

Follow-up Comment #2, bug #18607 (project freeciv):

There's a certain catch about 'Default value: 1'.
Yes, that's the default value for the *default* gtk theme - as in unthemed
gtk.

As you *provide* the theme, among other you provide the steppers and override
several values affecting the scrollbars, it's up to you to ensure the other
values fit.

If the lower/right stepper looks like on the attached screenshot, I'd say
they don't fit.

(file #14282)
___

Additional Item Attachment:

File name: stepper.pngSize:552 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[Jacob Nevins]

Follow-up Comment #3, bug #18607 (project freeciv):

Unh. Finally came to look at this as requested, but I can't reproduce the
problem on my system -- my scrollbars don't look like that.

But then the Freeciv theme hasn't really worked properly on my system for a
while -- see bug #17124. So this might be a further symptom of that.

I could just apply the suggested changes blind, but I fear the potential of
messing with Gtk themes to break our world.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[Jacob Nevins]

Follow-up Comment #4, bug #18607 (project freeciv):

(File #11324 shows the kind of scrollbars I have -- I think they're from my
system theme.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[Jacob Nevins]

Follow-up Comment #5, bug #18607 (project freeciv):

...so the way for me to reproduce it it to change my system theme, durrr.
Sorry for the noise. Repro'd with "Clearlooks" theme.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[anonymous]

Follow-up Comment #6, bug #18607 (project freeciv):

Well, I didn't mentioned it, cause I didn't think it would matter - yes,
default gtk2 theme here *is* Clearlooks.

So, it seems Freeciv theme isn't overriding enough values.

On semi-related note: I'm still trying every now and then to make some
progress with bug #19009, but neither the combos nor the buttons are willing
to cooperate and I'm still unsure if it's something I'm doing wrong or am I
struggling with a gtk3 bug.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[Jacob Nevins]

Update of bug #18607 (project freeciv):

Category:None => client-gtk-2.0 
  Status:None => Ready For Test 
 Assigned to:None => jtn
 Planned Release: => 2.3.2,2.4.0,2.5.0  

___

Follow-up Comment #7:

Tried the suggested fix and it worked as advertised and my world didn't end.

So unless anyone shouts, I intend to commit this soon, even though I don't
fully understand this area. (What's the worst that could possibly happen?)

(Attached patches update the gui-gtk-3.0 theme as well on trunk/S2_4, even
though I can't test it and it seems to be in limbo; seems as well not to have
gratuitous differences while we work out what to do about it.)

(file #14716, file #14717)
___

Additional Item Attachment:

File name: trunk-S2_4-gtk-theme-scrollbar-trunc.diff Size:1 KB
File name: S2_3-gtk-theme-scrollbar-trunc.diff Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #18607] scrollbars not drawn correctly in gtk-2.0 client

[Jacob Nevins]

Update of bug #18607 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev