[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-19 Thread Matthias Pfafferodt

Update of bug #19007 (project freeciv):

 Planned Release:   2.3.1,2.4.0,2.5.0 = 2.3.12,2.4.0,2.5.0 


___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-19 Thread Matthias Pfafferodt

Update of bug #19007 (project freeciv):

 Planned Release:  2.3.12,2.4.0,2.5.0 = 2.3.2,2.4.0,2.5.0  


___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-19 Thread Matthias Pfafferodt

Update of bug #19007 (project freeciv):

  Status:  Ready For Test = In Progress

___

Follow-up Comment #4:

I did not find this ticket yesterday evening. My proposal is to deactivate
the /remove command after a game was started for 2.3.1. Thus, there is time to
do all the checks needed to get the command working. As posted in bug #18776
there are further bugs if a client is connected at the time a player is
removed.

 There's a newer file of the same name attached to bug #18776:
 file #14574. Does that supersede file #14565 attached here? 
Yes.

 From what I understand, if there are a lot of players saving
 their vision is buggy. It seems the /remove problem uncovered a
 number of bugs with saving a game.
See above; the changes due to the removal of a player have to be send to the
connected clients else their state is incorrect.

___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-18 Thread Jacob Nevins

Follow-up Comment #1, bug #19007 (project freeciv):

2.3.1 will be built tomorrow morning...

There's a newer file of the same name attached to bug #18776: file #14574.
Does that supersede file #14565 attached here?

Also, there's ongoing discussion in the other ticket. I'm concerned that this
mightn't be a low-risk change at the last minute.

What's the impact of the bug fixed by this patch specifically? Does it extend
beyond situations where /remove is used?

___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-18 Thread Michal Mazurek

Follow-up Comment #2, bug #19007 (project freeciv):

From what I understand, if there are a lot of players saving their vision is
buggy. It seems the /remove problem uncovered a number of bugs with saving a
game.

___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-18 Thread Marko Lindqvist

Follow-up Comment #3, bug #19007 (project freeciv):

 It seems the /remove problem uncovered a number of bugs with
 saving a game.

Yes, These are serious, but AFAIK they are already in 2.3.0 - we're not
adding new backward compatibility nightmare by releasing 2.3.1 now. Any fix
with all the savegame backward compatibility and handling of earlier broken
savegames sensibly is going to be big and complicated task. I definitely don't
want to postpone release so long (even after fix is in, it should get weeks of
testing before being part of any release)

___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #19007] fix known map in savegame2

2011-11-16 Thread Matthias Pfafferodt

URL:
  http://gna.org/bugs/?19007

 Summary: fix known map in savegame2
 Project: Freeciv
Submitted by: syntron
Submitted on: Mi 16 Nov 2011 21:39:30 CET
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: syntron
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.3.1,2.4.0,2.5.0

___

Details:

do not use the player_count() but the highest used player slot index (see
also bug #18776)

reported and analysed by Michal Mazurek akfaew
patch by me
see gna bug #18776




___

File Attachments:


---
Date: Mi 16 Nov 2011 21:39:30 CET  Name:
0011-fix-known-map-in-savegame2.patch  Size: 3kB   By: syntron

http://gna.org/bugs/download.php?file_id=14565

___

Reply to this item at:

  http://gna.org/bugs/?19007

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev