[Freeciv-Dev] [bug #19888] Gtk widget rearrangement options backward compatibility measures won't work

[Jacob Nevins]

Update of bug #19888 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19888] Gtk widget rearrangement options backward compatibility measures won't work

[Jacob Nevins]

Update of bug #19888 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: trunk-S2_4-gtk2-widget-options-backward-compat-fix.diff Size:1 KB
File name: S2_3-gtk2-widget-options-backward-compat-fix.diff Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19888] Gtk widget rearrangement options backward compatibility measures won't work

[Jacob Nevins]

Follow-up Comment #1, bug #19888 (project freeciv):

Out of interest, it looks like we never provided any migration at all from
2.1-and-prior unadorned option names like "split_bottom_notebook" -- if this
was present in .civclientrc it would be ignored and the default used in
2.2.0+.
The move to "gui_gtk2_split_bottom_notebook" etc happened under bug #14433.
The premise of that bug was that such options were prone to being lost anyway
(you'd lose this Gtk option if you ever ran the SDL client), so I guess it's
defensible for us not to have provided migration.
Anyway, it _is_ too late to do anything about _that_ now...

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #19888] Gtk widget rearrangement options backward compatibility measures won't work

[Jacob Nevins]

URL:
  

 Summary: Gtk widget rearrangement options backward
compatibility measures won't work
 Project: Freeciv
Submitted by: jtn
Submitted on: Mon Jul  2 22:42:37 2012
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 2.3.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 2.3.3,2.4.0,2.5.0

___

Details:

In patch #1889 (which went into 2.3.0), I merged two boolean options into one
enumerated one.
I put in some code which attempted to give a smooth upgrade from 2.2 and prior
by reading the old boolean options and choosing the appropriate enumerated
one.
I don't know what I was thinking, but it looks like I gave the options I read
the wrong names ("gui_gtk_*" rather than "gui_gtk2_*"). So I don't think this
can ever have worked. (I thought I tested it at the time, but...)

Well, it's not yet so late that it's not worth fixing.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev