[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server
Update of bug #19957 (project freeciv): Status: Ready For Test = Fixed Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/bugs/?19957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server
Follow-up Comment #1, bug #19957 (project freeciv): It's easy enough to fix this, but can I first check that the intent wasn't to make this available on the client? Entering something like find.tile(0,0):set_label(Hello) in the client Lua console does actually work at the moment, in that the label appears on the map, but it tends not to show up until you've scrolled the map around about, and of course it doesn't go to other players, and is likely to be obliterated at some point by a server update. Just wanted to check there wasn't some plan for client-side private labels. ___ Reply to this item at: http://gna.org/bugs/?19957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server
Follow-up Comment #2, bug #19957 (project freeciv): Just wanted to check there wasn't some plan for client-side private labels. While per-player labels would make sense, they too, if ever implemented, must go to server side to be added in savegames. ___ Reply to this item at: http://gna.org/bugs/?19957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server
Update of bug #19957 (project freeciv): Status:None = Ready For Test Assigned to:None = jtn ___ Follow-up Comment #3: * Invent edit.tile_set_label(). * Remove bool return value from Tile:set_label() (which indicates whether the tile was changed, not much use to a script) ** This highlights that the script function doesn't push updates to the client. Not completely trivial to fix, so punted to bug #19962. (file #16147) ___ Additional Item Attachment: File name: trunk-lua-tile-set-label-server.patch Size:4 KB ___ Reply to this item at: http://gna.org/bugs/?19957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [bug #19957] Move Lua tile:set_label() from tolua_game to tolua_server
URL: http://gna.org/bugs/?19957 Summary: Move Lua tile:set_label() from tolua_game to tolua_server Project: Freeciv Submitted by: jtn Submitted on: Thu Jul 19 01:41:49 2012 Category: None Severity: 3 - Normal Priority: 5 - Normal Status: None Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.0 ___ Details: Patch #3136 added the tile:set_label() method to tolua_game.pkg. This is used for both server- and client-side scripting. Since this an edit rather than read function, it should probably only be available on the server (tolua_server.pkg) -- while it can be invoked on the client, it doesn't seem very useful to do so. For consistency, it might want to appear in the 'edit' module too. ___ Reply to this item at: http://gna.org/bugs/?19957 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
