[Freeciv-Dev] [bug #20460] One cannot upgrade unit (s)he is not able to build him/herself

[Marko Lindqvist]

URL:
  

 Summary: One cannot upgrade unit (s)he is not able to build
him/herself
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 28 Jan 2013 02:29:33 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

can_upgrade_unittype() begins with test that player can build *current*
unittype. Can anyhbody explain why it's there?
It means that if scenario (or even bribing in special ruleset) provides player
with special unit not available for him/her to build (I wonder if this
prevents upgrdes of UTYF_UNIQUE units altogether, as you would be unable to
build another when you already have the one you want to upgrade) there's no
way to later upgrade such units to somethithing player *can* build.

The case where this came up was when I tried to test upgrading with giving
tech for more advanced unit to player. Upgrade was not possible since I had no
tech for the original unit (can't upgrade Pahalanx to Musketeers when you have
Gunpowder but not Bronze Working)




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20460] One cannot upgrade unit (s)he is not able to build him/herself

[Marko Lindqvist]

Update of bug #20460 (project freeciv):

Category:None => general

___

Follow-up Comment #1:

Attached savegame is an example how this affects even default rules

1) Bribe Phalanx. You now have Phalanx without knowing Bronze Working
2) Capture Rio de Janeiro. You steal Gunpowder without knowing Bronze Working
3) Notice how you can build Musketeers in Rio de Janeiro, but cannot upgrade
th phalanx you have.

(file #17035)
___

Additional Item Attachment:

File name: NoUpradeRepro.sav.bz2  Size:10 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20460] One cannot upgrade unit (s)he is not able to build him/herself

[Marko Lindqvist]

Update of bug #20460 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.3.4, 2.4.0, 2.5.0

___

Follow-up Comment #2:

Attached patch removes the check if player can build current unittype. I've
found no reason to do such a check.

(file #17049)
___

Additional Item Attachment:

File name: UpgradeUnbuildable.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20460] One cannot upgrade unit (s)he is not able to build him/herself

[Marko Lindqvist]

Update of bug #20460 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev