[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Jacob Nevins]

Follow-up Comment #10, bug #20706 (project freeciv):

> Can you check the handling of EFT_MAX_RATES less than 40 (30% + 
> 30% + 30% would not make up to 100%)
Bit hopeless.
Server says "in player_limit_to_max_rates() [plrhand.c::1656]: assertion
'surplus % 10 == 0' failed."
In Gtk3 client, rates dialog starts out at all zeroes but limited to 30.
In Gtk2 client, the same except without the limit.
It's not clear what the right answer would be, but there's at least one new
ticket in this.

> or higher than 100?
Both Gtk2 and Gtk3 seemed to cope fine with this (handling it the same as 100%
as far as I could tell).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Marko Lindqvist]

Follow-up Comment #9, bug #20706 (project freeciv):

Can you check the handling of EFT_MAX_RATES less than 40 (30% + 30% + 30%
would not make up to 100%) or higher than 100? That may lead to another ticket
if you so decide. Implementation is also likely to be identical between gtk2-
and gtk3-clients, so if one is buggy, the other likely is too.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Jacob Nevins]

Follow-up Comment #8, bug #20706 (project freeciv):

So well um. Anyone going to object if I commit this patch as-is?

(I tried briefly to find code where 110% was treated specially, and failed.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Marko Lindqvist]

Follow-up Comment #7, bug #20706 (project freeciv):

btw Noticed that freeciv-web has interface where entire tax rates dialog is
constructed so that max value for the ruler is current maxrate value.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[RafałMużyło]

Follow-up Comment #6, bug #20706 (project freeciv):

> open rates dialog and rates setting icons in left panel are no way linked

They never were AFAIK.
Rates dialog checks the values only upon its creation.
Trying to synchronize them would make the code much more complicated for very
little gain.

Similarly, if i.e. the dialog was open and upon end of turn government
changed, some of the data would have been displayed incorrectly till the
dialog was closed and reopened.

Any communication between those two would be tricky, as rates dialog doesn't
exist all of the time, like the icons do.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Marko Lindqvist]

Follow-up Comment #5, bug #20706 (project freeciv):

I gave Democracy Max_Rates effect of 110 and tested the dialog with that.
Value displayed remained as 100% when I moved between 100 and 110 (and neither
of the two other rates went negative). I noticed no effects, and I think the
value gets cropped to 100% anyway.

While playing around with the dialog: open rates dialog and rates setting
icons in left panel are no way linked - change in one does not cause the other
to refresh.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[RafałMużyło]

Follow-up Comment #4, bug #20706 (project freeciv):

Well, it would be much easier if I could remember where I've seen that special
condition (IIRC, 110% was not a real value, but an indicator of a special
status (civil war ?)), nevertheless 110% was already valid before my patch -
the marks just made it more obvious.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Marko Lindqvist]

Follow-up Comment #3, bug #20706 (project freeciv):

I don't think player should be ever allowed to set rates higher than 100%.

I assume that you're referring to the fact that max rates effect can have any
value coming from the ruleset. The fact that this code appears to have a bug
of not cropping max rate to 0-100 but will use *any* effect value (not just
0-110) direcly also hints to that direction.
For example in alien ruleset total of 110% effect value is possible when
multiple effects stack.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[RafałMużyło]

Follow-up Comment #2, bug #20706 (project freeciv):

Ah, no.
110% is deliberate - not by my design, it's freeciv that reports 110% to
indicate a special condition. I remember stumbling upon this back when I was
writing those patches, but I no longer recall what condition exactly was it.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Jacob Nevins]

Update of bug #20706 (project freeciv):

Operating System:None => Any
 Planned Release:2.4.0, 2.5.0 => 2.4.0-beta2, 2.5.0 

___

Follow-up Comment #1:

(I think the main effect of the existing change is to allow the arrow keys to
work for luxury?)

> Noticed that there's 12 steps marked. 0%, 10% ... 110% ?
> Tested only with Despotism as government, so was unable to get 
> past 60% mark.
(My standard dodge for quickly testing governments is to build a city with an
initial settler then use the editor to put Statue of Liberty there.)

Indeed, testing with Democracy shows that we have an extra superfluous
checkmark. Making the obvious changes to remove it doesn't have any obvious
ill effect.

Attached a patch which incorporates the previous one and adds this change
(which would make this into a general "fix Gtk3 rates dialog" ticket, but it
doesn't seem worth separating).

(Another very minor thing I notice is that with the Freeciv theme, clicking
around the rates dialog, the papery background seems to "crawl" a bit.)

(file #17689)
___

Additional Item Attachment:

File name: trunk-S2_4-gtk3-ratesdlg-scales.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20706] Not setting increment for rates_lux_scale

[Marko Lindqvist]

URL:
  

 Summary: Not setting increment for rates_lux_scale
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 03 Apr 2013 11:50:11 PM EEST
Category: client-gtk-3.0
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0

___

Details:

In patch #3469 Rafał Mużyło  mentions typo:
"In client/gui-gtk-3.0/gamedlgs.c, around line 278, in rates_lux_scale block,
in gtk_range_set_increments call, rates_sci_scale is used by mistake."

Fix attached

Noticed that there's 12 steps marked. 0%, 10% ... 110% ? Tested only with
Despotism as government, so was unable to get past 60% mark.




___

File Attachments:


---
Date: Wed 03 Apr 2013 11:50:11 PM EEST  Name: LuxScale.patch  Size: 645B   By:
cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev