[Freeciv-Dev] [bug #20971] Martial_Law_Max has no effect

[Jacob Nevins]

Update of bug #20971 (project freeciv):

 Release: => 2.4.0-beta1,2.4.0-beta2

___

Follow-up Comment #4:

Introduced in patch #2359, I think (so regression from 2.3, which has been in
all 2.4 betas to date).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20971] Martial_Law_Max has no effect

[Marko Lindqvist]

Update of bug #20971 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #20971] Martial_Law_Max has no effect

[Marko Lindqvist]

URL:
  

 Summary: Martial_Law_Max has no effect
 Project: Freeciv
Submitted by: cazfi
Submitted on: Mon 15 Jul 2013 09:29:04 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: Ready For Test
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 2.4.0, 2.5.0, 2.6.0

___

Details:

All military units increase Martial Law (as long as there's Martial_Law_Each
effect active), Martial_Law_Max effect is ignored.

Reason is that when units are iterated, max is compared to variable that is
not updated yet in that loop (and later has, in fact, value multiplied by
martial_law_each) and thus is always 0 no matter how many units already are
counted toward Martial Law.

Fix attached



___

File Attachments:


---
Date: Mon 15 Jul 2013 09:29:04 PM EEST  Name: MartialLawMax.patch  Size: 588B 
 By: cazfi



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev