[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-06-19 Thread Emmet Hikory 
Update of bug #21420 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-06-17 Thread Emmet Hikory 
Follow-up Comment #5, bug #21420 (project freeciv):

Sorry to have forgotten this for a while.  Updated, and issues addressed.

(file #21072)
___

Additional Item Attachment:

File name: worklist-explanation-improvements+less-spaces.patch Size:52 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-05-09 Thread pepeto 
Follow-up Comment #4, bug #21420 (project freeciv):

I guess this should be the the same after '!' in "reason unknown! 
Postponing..."

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-05-08 Thread Emmet Hikory 
Follow-up Comment #3, bug #21420 (project freeciv):

Good catch.  Updated patch with string spacing reduction attached (this is an
improvement to CodingStyle over the current strings).

(file #20694)
___

Additional Item Attachment:

File name: worklist-explanation-improvements+spacing.patch Size:51 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-05-08 Thread pepeto 
Follow-up Comment #2, bug #21420 (project freeciv):

Just had a look to your patch... I didn't see anything wrong except that
strings containing multiple sentences should be separated by one space only,
according to coding style.


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-05-04 Thread Emmet Hikory 
Update of bug #21420 (project freeciv):

  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: worklist-explanation-improvements.patch Size:51 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-05-03 Thread Emmet Hikory 
Update of bug #21420 (project freeciv):

Category:None => general
  Status:None => In Progress
 Assigned to:None => persia 
 Planned Release: => 2.6.0  

___

Follow-up Comment #1:

In addition to the improvement messages failing to handle present==FALSE
requirements, the unit messages fail to consider anything other than missing
technologies.  Merging these issues for simplicity of patch management.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-04-21 Thread Jacob Nevins 
Update of bug #21420 (project freeciv):

Severity:  3 - Normal => 2 - Minor  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21420] Worklist postponement messages don't consistently support negated requirements

2014-01-02 Thread Jacob Nevins 
URL:
  

 Summary: Worklist postponement messages don't consistently
support negated requirements
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Jan  3 03:42:58 2014
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk r23973
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

worklist_change_build_target() attempts to diagnose why it can't build an
improvement from the worklist ("Kuala Lumpur can't build Airport from the
worklist; tech Radio not yet available!  Postponing...")

However, only for one requirement (VUT_MAXTILEUNITS) does it check
preq->present; for others, it might give misleading answers in the face of
negated (present==FALSE) requirements.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev