[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites

2014-01-03 Thread Jacob Nevins 
URL:
  

 Summary: Ignore negated requirements in client improvement
prerequisites
 Project: Freeciv
Submitted by: jtn
Submitted on: Fri Jan  3 15:20:53 2014
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
  Status: In Progress
 Assigned to: jtn
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

The various client-specific code that decides what "the" prerequisite for a
building is can erroneously pick a negated requirement and present it as a
prerequisite.

There's lots wrong with this area, which can be the subject of another ticket,
but in this one I'll tweak the code to just ignore negated requirements.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites

2014-01-03 Thread Jacob Nevins 
Follow-up Comment #1, bug #21430 (project freeciv):

(This probably doesn't actually bite that often, because generally there will
be a non-negated requirement and it will likely be the first one.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-03 Thread Jacob Nevins 
Update of bug #21430 (project freeciv):

 Summary: Ignore negated requirements in client improvement
prerequisites => Ignore negated requirements in client improvement
prerequisites help


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-03 Thread Jacob Nevins 
Follow-up Comment #2, bug #21430 (project freeciv):

(The first patch for bug #21425 -- file #19630 -- addresses this by adding a
"!" in front, so "!Construction" would be displayed if no-Construction was the
first req -- but I won't be taking that patch forward.)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-03 Thread Jacob Nevins 
Update of bug #21430 (project freeciv):

  Status: In Progress => Ready For Test 
 Planned Release: => 2.4.2,2.5.0,2.6.0  

___

Additional Item Attachment:

File name: trunk-impr-req-negated-help.patch Size:7 KB
File name: S2_5-impr-req-negated-help.patch Size:6 KB
File name: S2_4-impr-req-negated-help.patch Size:6 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21430] Ignore negated requirements in client improvement prerequisites help

2014-01-05 Thread Jacob Nevins 
Update of bug #21430 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev