[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Sveinung Kvilhaugsvik]

Update of bug #21444 (project freeciv):

Category:None => general
  Status:None => Ready For Test 
 Assigned to:None => sveinung   
 Release: => TRUNK, 2.6 
Operating System:None => Any
 Planned Release:   2.6.0 => 3.0.0, 2.6.0   

___

Follow-up Comment #5:

Allow underscore in entity names that ends up in a table.

(file #25132)
___

Additional Item Attachment:

File name: section-files-allow-underscore-in-table-names.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Sveinung Kvilhaugsvik]

Follow-up Comment #6, bug #21444 (project freeciv):

I created bug #23874 for the column in separate table issue

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Marko Lindqvist]

Follow-up Comment #7, bug #21444 (project freeciv):

One of the places where you now use is_legal_table_entry_name() used
fc_isalnum(). is_legal_table_entry_name() uses fc_isalpha().

Is dropping digits as legal characters in that case intentional?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Sveinung Kvilhaugsvik]

Update of bug #21444 (project freeciv):

  Status:  Ready For Test => In Progress

___

Follow-up Comment #8:

_Is dropping digits as legal characters in that case intentional?_
No.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Sveinung Kvilhaugsvik]

Update of bug #21444 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #9:

fixed

(file #25134)
___

Additional Item Attachment:

File name: section-files-allow-underscore-in-table-names-v2.patch Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Sveinung Kvilhaugsvik]

Update of bug #21444 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Marko Lindqvist]

URL:
  

 Summary: Saved action_enabler reqs do not use tabular format
 Project: Freeciv
Submitted by: cazfi
Submitted on: Sun 05 Jan 2014 01:30:17 PM EET
Category: None
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

For some reason action_enablers saved from freeciv-ruledit do not use tabular
format. That's a decision of lower-level secfile saving handling, and should
not be concern, but as this is seemingly arbitrary it's suspicious.

[actionenabler_0]
action="Poison City"
actor_reqs0.type="UnitFlag"
actor_reqs0.name="Spy"
actor_reqs0.range="Local"
actor_reqs1.type="DiplRel"
actor_reqs1.name="War"
actor_reqs1.range="Local"
actor_reqs2.type="UnitFlag"
actor_reqs2.name="Diplomat"
actor_reqs2.range="Local"
target_reqs0.type="MinSize"
target_reqs0.name="2"
target_reqs0.range="City"





___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Marko Lindqvist]

Follow-up Comment #1, bug #21444 (project freeciv):

Another weirdness in secfile saving noticed when updating tileset-demo.sav
scenario on S2_5. Why it wants to have "love" column in separate table:

-ai={"love","spam","countdown","war_reason","patience","warn_space","ask_peace"
,"ask_alliance","ask_ceasefire"
-0,4,-1,5,0,0,0,0,0
-0,0,-1,5,0,0,0,0,0
-0,1,-1,5,0,0,0,0,0
-0,2,-1,5,0,0,0,0,0
-0,3,-1,5,0,0,0,0,0
+ai={"love"
+0
+0
+0
+0
+0
+}
+ai={"spam","countdown","war_reason","patience","warn_space","ask_peace","ask_a
lliance","ask_ceasefire"
+4,-1,5,0,0,0,0,0
+0,-1,5,0,0,0,0,0
+1,-1,5,0,0,0,0,0
+2,-1,5,0,0,0,0,0
+3,-1,5,0,0,0,0,0
 }


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[pepeto]

Follow-up Comment #2, bug #21444 (project freeciv):

I have also noticed in file #22111 things like:

diplstate={"type","max_state","first_contact_turn","turns_left","has_reason_to_cancel","contact_turns_left","embassy","gives_shared_vision"
5,5,0,0,0,0,FALSE,FALSE
1,5,2,0,0,20,FALSE,FALSE
1,5,5,0,0,16,FALSE,FALSE
1,5,12,0,0,0,FALSE,FALSE
1,5,3,0,0,13,FALSE,FALSE
}
diplstate6.type=5
diplstate6.max_state=5
diplstate6.first_contact_turn=0
diplstate6.turns_left=0
diplstate6.has_reason_to_cancel=0
diplstate6.contact_turns_left=0
diplstate6.embassy=FALSE
diplstate6.gives_shared_vision=FALSE



___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[pepeto]

Follow-up Comment #3, bug #21444 (project freeciv):

(I meant file #20862 for bug #22111)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[pepeto]

Follow-up Comment #4, bug #21444 (project freeciv):

> Why it wants to have "love" column in separate table?

Because the entries are not next to the other ai ones in the secfile.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21444] Saved action_enabler reqs do not use tabular format

[Jacob Nevins]

Update of bug #21444 (project freeciv):

 Planned Release: => 2.6.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev