[Freeciv-Dev] [bug #21744] Delegation is case-sensitive for username

[Marko Lindqvist]

Update of bug #21744 (project freeciv):

 Planned Release: => 2.5.1, 2.6.0, 3.0.0


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21744] Delegation is case-sensitive for username

[Marko Lindqvist]

Follow-up Comment #1, bug #21744 (project freeciv):

Confirmed from connecthand.c that usernames are supposed to be
case-insensitive (names differing only by case are considered duplicates).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21744] Delegation is case-sensitive for username

[Marko Lindqvist]

Update of bug #21744 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #2:

Fix

(file #24403)
___

Additional Item Attachment:

File name: CaseInsensitiveDelegate.patch  Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21744] Delegation is case-sensitive for username

[Marko Lindqvist]

Update of bug #21744 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #21744] Delegation is case-sensitive for username

[Davide Baldini]

URL:
  

 Summary: Delegation is case-sensitive for username
 Project: Freeciv
Submitted by: davide_at_debian
Submitted on: Mon 03 Mar 2014 12:51:22 AM UTC
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 2.4.2
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

The current implementation of delegations is case-sensitive with regard to
usernames. That is, if user "A" delegates his nation to user "B", "b" wouldn't
be able to take the delegation from "A".

In Greatturn, games last for months and usernames can be somewhat long and
complicated; sometimes users log-in typing their nicks w/o paying attention to
case, and then they wonder why delegations stop working.

AFAIK, the whole structure of Freeciv is built to be case insensitive for
usernames, so this patch, which comes from Longturn, is somewhat inconsistent.
Moreover, Longturn solves this issue - for its sole benefit - by using the
following custom code to internally handle delegations in interactions with
DB:


SELECT delegation FROM auth_user AS u
JOIN game_joined j ON (u.id = j.user_id)
JOIN player_player p ON p.id = j.user_id
WHERE lower(username) = lower('$USER') AND game_id = '$GAMENAME';


I think this patch should be made consistent with the rest of Freeciv, by
treating usernames case-insensitively.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev