[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-08-04 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Status: In Progress => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-08-02 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Status:   Fixed => In Progress
 Open/Closed:  Closed => Open   
  Depends on: => bugs #22425

___

Follow-up Comment #9:

> transform_unit() drops all veteran levels if on e.g. upgrade if new unit is
NoVeteran.
I seem to have neglected to fix this.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-17 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Status:  Ready For Test => Fixed  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-16 Thread Jacob Nevins 
Follow-up Comment #8, bug #22171 (project freeciv):

I hope it's all moot now that I've deferred fixing bug #22203 to 2.5.0-beta1,
hiding it behind a format change -- to a first approximation, no-one should
see a ruleset reduce the number of veteran levels without also getting a fix
for bug #22172, rendering the reduction harmless. Or have I missed something?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-16 Thread Marko Lindqvist 
Follow-up Comment #7, bug #22171 (project freeciv):

> I know the classic ruleset has had work_raise_chance set in the
> past, but has it ever been the case that it's had that and any
> units that weren't NoVeteran? If not, we won't have any veteran
> workers in savegames via that route.

That needs to be checked (I guess checking HEAD of each branch is sufficient).
I think we used to have veteran settlers/workers that got movement bonus in
supplied rulesets too, but it's possible that it has been the case in custom
rulesets only.
When was "NoVeteran" itself introduced? There might be savegames originally
created when settlers lacked the "NoVeteran" flag simply because the freeciv
engine didn't support it. I also think that in distant past settlers did gain
veterancy by winning combat (as defender) like any other unit.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Status: In Progress => Ready For Test 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Depends on: => bugs #22201


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Depends on: => bugs #22202


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Depends on: => bugs #22199


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Depends on: => bugs #22200


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Depends on: => bugs #22198


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #22171] [metaticket] "NoVeteran" flag misinterpreted in various places

2014-06-15 Thread Jacob Nevins 
Update of bug #22171 (project freeciv):

  Status:None => In Progress
 Planned Release: => 2.4.3, 2.5.0, 2.6.0
 Summary: "NoVeteran" flag: can never be veteran, or can't
gain it through combat? => [metaticket] "NoVeteran" flag misinterpreted in
various places

___

Follow-up Comment #6:

My plan:
* Settle on the "NoVeteran prevents veterancy through experience"
interpretation.
* Fix all noted engine bugs in 2.4 and later, including help.
** Except transform_unit() which is 2.5+ only.
* Only add custom veteran systems to Settlers etc in supplied rulesets from
2.5.
** This means that the help will be a misleading on 2.4 after these fixes,
implying that Settlers can get bonuses which are in fact unreachable. Live
with this.
* Fix up civ1/civ2 rulesets from 2.4.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev