[Freeciv-Dev] [bug #22299] Server allows to move to transport tile even if it cannot load into

2014-07-19 Thread pepeto
Update of bug #22299 (project freeciv):

 Assigned to:None = pepeto 


___

Reply to this item at:

  http://gna.org/bugs/?22299

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22299] Server allows to move to transport tile even if it cannot load into

2014-07-19 Thread pepeto
Update of bug #22299 (project freeciv):

  Status:  Ready For Test = Fixed  
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/bugs/?22299

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22299] Server allows to move to transport tile even if it cannot load into

2014-07-12 Thread pepeto
Update of bug #22299 (project freeciv):

  Status:None = Ready For Test 
 Planned Release: = 2.5.0, 2.6.0   

___

Follow-up Comment #1:

Fix attached for trunk: use transport_from_tile() instead of
unit_class_transporter_capacity().

For S2_5, after applying the patch, only path-finding will be still affected.
But the server will respect the rules.

For S2_4, it seems very more complicate. I strongly think it should stay how
it works now, but we should drop any load/unload restriction.


(file #21368, file #21369)
___

Additional Item Attachment:

File name: trunk_remove_unit_class_transporter_capacity.patch Size:8 KB
File name: S2_5_prefer_transport_from_tile.patch Size:6 KB


___

Reply to this item at:

  http://gna.org/bugs/?22299

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [bug #22299] Server allows to move to transport tile even if it cannot load into

2014-07-09 Thread pepeto
URL:
  http://gna.org/bugs/?22299

 Summary: Server allows to move to transport tile even if it
cannot load into
 Project: Freeciv
Submitted by: pepeto
Submitted on: mer. 09 juil. 2014 15:13:03 CEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: trunk
 Discussion Lock: Any
Operating System: Any
 Planned Release: 

___

Details:

Noticed in bug #22050 and bug #22187, you can move to the tile, without
loading to the transport. Then you can see land units alone in the middle of
the ocean.

I think the main problem is that unit_move_to_tile_test() only check
unit_class_transporter_capacity() instead of calling could_unit_load().

However, I didn't investigate deeper. Maybe they are other related problems. I
suppose S2_4 and S2_5 are also affected, but I haven't check yet.





___

Reply to this item at:

  http://gna.org/bugs/?22299

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev