[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Update of bug #23708 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Follow-up Comment #9, bug #23708 (project freeciv):

Next turn the citydlg shows the correct tradepartner names, and find city
dialog lists and finds them.
Probably irrelevant, but those partner cities seem to be founded to places
that I already 'know' (probably via trading maps), but that are fogged.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Follow-up Comment #8, bug #23708 (project freeciv):

In a running game (TRUNK r29041 + a lot of fixes backported) number of
traderoutes were just established to my cities. gtk3-client citydlg shows them
currently as: "+13: Trade route with (unknown)". The event messages about the
trade routes told the name of the partner city, and those cities are not in
the list of "Find City" dialog (-> presumably I don't about them yet)

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Follow-up Comment #7, bug #23708 (project freeciv):

> Untested patch for S2_5 attached

Surprisingly that same patch applies to all branches despite them trade system
changes between them.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Marko Lindqvist]

Update of bug #23708 (project freeciv):

  Status:None => Ready For Test 
 Planned Release:   3.0.0 => 2.5.4, 2.6.0, 3.0.0

___

Follow-up Comment #6:

First commented to bug #24072, but this ticket is even more involved:
"It could be that the other end of the traderoute has just been destroyed
(removed from the game) but the traderoute has not yet been removed from the
client end. I see nothing sending city info about trade partner cities, only
textual events, before city gets removed."

Untested patch for S2_5 attached.

(file #26908)
___

Additional Item Attachment:

File name: PartnerInfoOnRouteRemoval-S2_5.patch Size:1 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Jacob Nevins]

Follow-up Comment #5, bug #23708 (project freeciv):

This doesn't look like bug #24072, where both city pointers seem valid (here
one is NULL).

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #23708] Segmentation fault in cities_trade_route_type during server_quit()

[Jacob Nevins]

Update of bug #23708 (project freeciv):

 Summary: Segmentation fault in cities_trade_route_type =>
Segmentation fault in cities_trade_route_type during server_quit()

___

Follow-up Comment #4:

I'm going to assume that the report in comment #0 has been resolved by the fix
for bug #23614. It seems consistent on a quick look.

Repurposing ticket for the remaining report, comment #1, of something similar
in server_quit(). Suspect the solution is similar: suspect city refresh during
teardown.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev