[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-18 Thread Marko Lindqvist 
Update of bug #24133 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist 
Follow-up Comment #3, bug #24133 (project freeciv):

> The activity Railroad is removed from every unit in the
> savegame. The activity road is preserved.

Those are not separate activities in 2.5 & up, but generic road building
activities with specified target road.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Jordi Negrevernis i Font 
Follow-up Comment #2, bug #24133 (project freeciv):

I was not accurate. Sorry.

The activity Railroad is removed from every unit in the savegame. The activity
road is preserved.

I attach a savegame.

Thanks


(file #26020)
___

Additional Item Attachment:

File name: cat10civ10.sav.bz2 Size:198 KB


___

Reply to this item at:

  

___
  Missatge enviat a través de/per Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist 
Follow-up Comment #5, bug #24133 (project freeciv):

Player technologies are not loaded when unit activities are sanity checked ->
player is not known to know required techs.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist 
Follow-up Comment #6, bug #24133 (project freeciv):

Another symptom: bug #23971

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist 
Follow-up Comment #4, bug #24133 (project freeciv):

Savegame loading cancels several "Road"/"Railroad" and one "Mine"/"Oil Well"
activities.

Attached is patch to at least improve logging of these. (S2_6 version - TRUNK
will need same to savegame3.c too)

(file #26021)
___

Additional Item Attachment:

File name: IllegalActivityLogging.patch   Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Marko Lindqvist 
Update of bug #24133 (project freeciv):

  Status:None => Ready For Test 

___

Follow-up Comment #7:

Fix

(file #26022, file #26023)
___

Additional Item Attachment:

File name: ResearchBeforePlayers.patchSize:1 KB
File name: ResearchBeforePlayers-S2_6.patch Size:0 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-15 Thread Jacob Nevins 
Update of bug #24133 (project freeciv):

 Release: => S2_6 svn   
 Planned Release: => 2.6.0, 3.0.0   

___

Follow-up Comment #1:

Can't reproduce with current S2_6 (r31005).
Amazonian AI Workers are building roads ([l tgt="unit" id=119 name="Workers"
/] [l tgt="unit" id=120 name="Workers" /]) and there seems to be no trouble
loading this from the attached savegame2-format savegame.

Do you have a savegame that provokes this?

(It's possible that a bug has been fixed in the past fortnight, but none of
the commits looked obviously relevant to this.)

(file #26015)
___

Additional Item Attachment:

File name: un26-T0010-Y-3500-auto.sav.bz2 Size:17 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24133] Loading code removes the activity road or railroad from AI units

2015-12-01 Thread Jordi Negrevernis i Font 
URL:
  

 Summary: Loading code removes the activity road or railroad
from AI units
 Project: Freeciv
Submitted by: jorneg
Submitted on: mié 02 dic 2015 00:23:35 UTC
Category: ai
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 

___

Details:

In HEAD S2_6 ->

1: Unit doing illegal activity in savegame!
2: Backtrace:
2: 0: ./server/freeciv-server(backtrace_print+0x2d) [0x82be5bd]
2: 1: ./server/freeciv-server(vdo_log+0xb0) [0x82c2300]
2: 2: ./server/freeciv-server(do_log+0x40) [0x82c2360]
2: 3: ./server/freeciv-server() [0x81384ac]
2: 4: ./server/freeciv-server() [0x8140050]
2: 5: ./server/freeciv-server(savegame2_load+0x86) [0x8143406]
2: 6: ./server/freeciv-server(load_command+0x3b3) [0x808c203]
2: 7: ./server/freeciv-server() [0x808f280]
2: 8: ./server/freeciv-server() [0x8147b4f]
2: 9: /lib/i386-linux-gnu/libreadline.so.6(rl_callback_read_char+0x92)
[0xb7760fc2]
2:10: ./server/freeciv-server(server_sniff_all_input+0x13c5) [0x8149c45]
2:11: ./server/freeciv-server(srv_main+0x252) [0x807d5c2]
2:12: ./server/freeciv-server(main+0x292) [0x80731e2]
2:13: /lib/i386-linux-gnu/libc.so.6(__libc_start_main+0xf3) [0xb7376a83]
2:14: ./server/freeciv-server() [0x8073ee8]
>

The loading validation code doesn't seem to like the units ( engineers or
workers) that create roads or railroads. It removes the activity of the
unit!!!





___

Reply to this item at:

  

___
  Mensaje enviado vía/por Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev