[Freeciv-Dev] [bug #24663] Speculative homecity not fully respected

[Marko Lindqvist]

Update of bug #24663 (project freeciv):

  Status:  Ready For Test => Fixed  
 Assigned to:None => cazfi  
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24663] Speculative homecity not fully respected

[Marko Lindqvist]

Update of bug #24663 (project freeciv):

  Status:None => Ready For Test 
 Planned Release: => 2.6.0, 3.0.0   

___

Follow-up Comment #1:

Fix

(file #28113, file #28114)
___

Additional Item Attachment:

File name: SpeculativeHomecityForAction.patch Size:12 KB
File name: SpeculativeHomecityForAction-S2_6.patch Size:9 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [bug #24663] Speculative homecity not fully respected

[Marko Lindqvist]

URL:
  

 Summary: Speculative homecity not fully respected
 Project: Freeciv
Submitted by: cazfi
Submitted on: Thu 12 May 2016 04:01:58 PM EEST
Category: general
Severity: 3 - Normal
Priority: 5 - Normal
  Status: None
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Release: 
 Discussion Lock: Any
Operating System: None
 Planned Release: 
 Contains string changes: None

___

Details:

cowt_callback() (and maybe some other AI code) tries to speculate on changing
the caravan homecity before heading for a ACTION_TRADE_ROUTE mission. That is;
it would want to know value of traderoute between parameter->src and
parameter->dest, as given by get_discounted_reward(), and not between current
unit->homecity and parameter->dest.
get_discounted_reward() calls is_action_enabled_unit_on_city() that internally
checks the trade route legality based on units current homecity.

To support also future speculative cases, this would probably be best to
correct by renaming full implementation of is_action_enabled_unit_on_city()
under a new name and to make that function to take unit homecity as a
parameter. The usual is_action_enabled_unit_on_city() could then be just a
wrapper around it, passing unit's current homecity.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev