URL: <http://gna.org/bugs/?24877>
Summary: Tileset suggestion dialog not prepared for extremenly long tileset name Project: Freeciv Submitted by: cazfi Submitted on: Mon 25 Jul 2016 05:26:56 PM EEST Category: client Severity: 3 - Normal Priority: 5 - Normal Status: Ready For Test Assigned to: None Originator Email: Open/Closed: Open Release: Discussion Lock: Any Operating System: None Planned Release: 2.5.5, 2.6.0, 3.0.0 Contains string changes: None _______________________________________________________ Details: Tileset suggestion dialog uses unsafe sprintf() where extremely long tileset name may overflow the buffer. Same for soundset and musicset dialogs. Attached fix does also some other cleanup to client side sprintf() calls. _______________________________________________________ File Attachments: ------------------------------------------------------- Date: Mon 25 Jul 2016 05:26:57 PM EEST Name: SprintfCleanup.patch Size: 15kB By: cazfi <http://gna.org/bugs/download.php?file_id=28005> ------------------------------------------------------- Date: Mon 25 Jul 2016 05:26:57 PM EEST Name: SprintfCleanup-S2_6.patch Size: 14kB By: cazfi <http://gna.org/bugs/download.php?file_id=28006> ------------------------------------------------------- Date: Mon 25 Jul 2016 05:26:57 PM EEST Name: SprintfCleanup-S2_5.patch Size: 10kB By: cazfi <http://gna.org/bugs/download.php?file_id=28007> _______________________________________________________ Reply to this item at: <http://gna.org/bugs/?24877> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev