[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[pepeto]

Update of patch #1656 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[pepeto]

Follow-up Comment #3, patch #1656 (project freeciv):

Patch updated against current trunk.


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[pepeto]

Update of patch #1656 (project freeciv):

Category:None => general
  Status: In Progress => Ready For Test 

___

Additional Item Attachment:

File name: 0001-Export-specenum_gen-enums-in-the-Lua-event-scripting.patch
Size:12 KB


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[pepeto]

Update of patch #1656 (project freeciv):

  Status:  Ready For Test => In Progress
 Assigned to:  englabenny => pepeto 


___

Reply to this item at:

  

___
  Message posté via/par Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[Matthias Pfafferodt]

Follow-up Comment #2, patch #1656 (project freeciv):

I do try to do similar patches for other enums used in savegames/rulesets.
>From your comment #0 and a short look into the patch I thought such a
dependency is needed. Sorry ...

___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[Ulrik Sverdrup]

Follow-up Comment #1, patch #1656 (project freeciv):

This patch does not depend on patch #1646  and not the other way around
either. However, we could surely convert the API to use enums for effects
instead of effect names (after this patch + patch #1646 both have gone in).
Since the effects API is not yet in any released version, it should be no
problem to change it (right?).

___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[Matthias Pfafferodt]

Update of patch #1656 (project freeciv):

  Depends on: => patch #1646


___

Reply to this item at:

  

___
  Nachricht geschickt von/durch Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #1656] Export specenum_gen enums in the Lua event scripting API

[Ulrik Sverdrup]

URL:
  

 Summary: Export specenum_gen enums in the Lua event
scripting API
 Project: Freeciv
Submitted by: englabenny
Submitted on: fredag 2010-04-30 den 17:37
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: englabenny
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.3.0

___

Details:

With specenum we can easily export enums to lua using runtime name to
value lookup.

(Given progress with Matthias' patches on specenums, this looks like a very
good direction of development. The following patch only exports the events.h
specenum, the only one used in the API right now).

The looked-up value is written back to the lua table and thus every
lookup after the first will be looked up in the lua-side table
(remember, the __index metamethod in Lua is only a fallback).

api_specenum is exported by writing functions against the Lua C API
directly, without using tolua. This because the enum lookup is written
as template only once and can be instantiated for each specenum type.


Scripting API incompatibilities:
  Typos are not preserved (E.E_LOG_ERROR was exported, should have been and
is now E.LOG_ERROR)
  The 'E' table/module is no longer iterable (=introspectable) since it is
dynamically looked up.

I consider these incompatibilities trivial and nothing to worry about.



___

File Attachments:


---
Date: fredag 2010-04-30 den 17:37  Name:
2010043002-Export-specenum_gen-enums-in-the-Lua-event-scr.patch  Size: 13 kB 
 By: englabenny



___

Reply to this item at:

  

___
  Meddelandet skickades via/av Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev