[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Update of patch #1801 (project freeciv): Status: Ready For Test = Wont Do Assigned to:None = cazfi Open/Closed:Open = Closed ___ Follow-up Comment #5: ai_data is actually used by advisors also, so it's handling should not be in AI interface in the first place. See patch #1816. ___ Reply to this item at: http://gna.org/patch/?1801 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Follow-up Comment #4, patch #1801 (project freeciv): * Renamed analyze_rulesets as plr_analyze_rulesets to make room for future function that is called only once for each ai_type. (file #9695) ___ Additional Item Attachment: File name: AnalyzeRulesets2AiInterface_1801-3.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?1801 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Follow-up Comment #2, patch #1801 (project freeciv): have a look at patch #1785 (for this one see patch #1789) I know we are doing duplicate work. But our patches have very different dependencies (your patches depend on lower parts of your own patch stack and my patches depend on my patch stack). Instead of waiting very long time that your patches get committed - which probably takes weeks (at least I refrain from committing patch that depends on patch committed less than ~24h ago. This gives people time to check new patch against already committed stuff) - I decided that it is actually better to do same work in my own series so I can go forward myself. ___ Reply to this item at: http://gna.org/patch/?1801 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Quoting Marko Lindqvist no-reply.invalid-addr...@gna.org: have a look at patch #1785 (for this one see patch #1789) I know we are doing duplicate work. But our patches have very different dependencies (your patches depend on lower parts of your own patch stack and my patches depend on my patch stack). Instead of waiting very long time that your patches get committed - which probably takes weeks (at least I refrain from committing patch that depends on patch committed less than ~24h ago. This gives people time to check new patch against already committed stuff) - I decided that it is actually better to do same work in my own series so I can go forward myself. The 'remove *' patches (see patch #1780 to #1790) are as independent as possible. Perhaps you have to move the definition of the new function pointers but else they only try to remove dependencies of the server code on code in ./ai by moving some functions or by defining new function pointers (for saving/loading ai data from savegames). Sometimes they only remove the header file as no real dependency exists. This message was sent using IMP, the Internet Messaging Program. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
Re: [Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
On 3 August 2010 12:37, Matthias Pfafferodt free...@mapfa.de wrote: The 'remove *' patches (see patch #1780 to #1790) are as independent as possible. Perhaps you have to move the definition of the new function pointers but else they only try to remove dependencies of the server code on code in ./ai by moving some functions or by defining new function pointers (for saving/loading ai data from savegames). Sometimes they only remove the header file as no real dependency exists. Most of them add interface.h include and use stuff from there. Interface stuff is not yet committed. They also use your macros - and fail to use my macros where appropriate. Maybe I should post my versions of the patches in your tickets that most closely resembles the patch in question, but there really is not much actual code in your patches I could use (short of those patches I already committed). - ML ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Follow-up Comment #3, patch #1801 (project freeciv): * Updated against changes in patch stack (file #9678) ___ Additional Item Attachment: File name: AnalyzeRulesets2AiInterface_1801-2.diff Size:1 KB ___ Reply to this item at: http://gna.org/patch/?1801 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
URL: http://gna.org/patch/?1801 Summary: Call ai_data_analyze_rulesets through AI function pointer interface Project: Freeciv Submitted by: cazfi Submitted on: Monday 08/02/2010 at 18:22 Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.3.0 ___ Details: ___ File Attachments: --- Date: Monday 08/02/2010 at 18:22 Name: AnalyzeRulesets2AiInterface.diff Size: 1kB By: cazfi http://gna.org/patch/download.php?file_id=9669 ___ Reply to this item at: http://gna.org/patch/?1801 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Update of patch #1801 (project freeciv): Depends on: = patch #1794 ___ Reply to this item at: http://gna.org/patch/?1801 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #1801] Call ai_data_analyze_rulesets through AI function pointer interface
Follow-up Comment #1, patch #1801 (project freeciv): have a look at patch #1785 (for this one see patch #1789) ___ Reply to this item at: http://gna.org/patch/?1801 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
