[Freeciv-Dev] [patch #2960] additional compile checks
Update of patch #2960 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Update of patch #2960 (project freeciv): Assigned to:None = syntron ___ Follow-up Comment #5: the attached patch on top of file #14159 fixes the problems with the debugging settings: --enable-debug=yes: as much checks as possible --enable-debug=checks: adds -Wstrict-prototypes (problematic for gtk2) see also bug #18217 I will commit both patches if there are no comments. (file #14307) ___ Additional Item Attachment: File name: 0016-fix-debug-checks.patchSize:3 KB ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Follow-up Comment #4, patch #2960 (project freeciv): remove options not supported by cpp in CXX_CFLAGS (file #14159) ___ Additional Item Attachment: File name: 0018-add-additional-compiling-time-checks-if-enable-debug.patch Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Follow-up Comment #3, patch #2960 (project freeciv): ... to avoid splitting the line of compiler flags?! Fixed patch attached! (file #14091) ___ Additional Item Attachment: File name: 0019-add-additional-compiling-time-checks-if-enable-debug.patch Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
URL: http://gna.org/patch/?2960 Summary: additional compile checks Project: Freeciv Submitted by: syntron Submitted on: Do 15 Sep 2011 20:12:43 CEST Category: general Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: None Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.4.0 ___ Details: add additional compiling time checks if --enable-debug=checks is set - Force '-Wformat -Wformat-security' to be active (see also gna bug #18081) - fix flags for c++ ___ File Attachments: --- Date: Do 15 Sep 2011 20:12:43 CEST Name: 0019-add-additional-compiling-time-checks-if-enable-debug.patch Size: 1kB By: syntron http://gna.org/patch/download.php?file_id=14089 ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Follow-up Comment #1, patch #2960 (project freeciv): updated patch; it now includes a cleanup of the debug settings: - move debug flags into debug.m4 - remove duplicated flags - Add/force '-Wformat -Wformat-security' to be active (see also gna bug #18081) - Fix flags for c++ (file #14090) ___ Additional Item Attachment: File name: 0019-add-additional-compiling-time-checks-if-enable-debug.patch Size:6 KB ___ Reply to this item at: http://gna.org/patch/?2960 ___ Nachricht geschickt von/durch Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #2960] additional compile checks
Follow-up Comment #2, patch #2960 (project freeciv): Why you have in several places two calls to FC_C_FLAGS for setting flags to same variable after each other? It would be more efficient to combine these to one call. ___ Reply to this item at: http://gna.org/patch/?2960 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev