[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-05-01 Thread RafałMużyło
Follow-up Comment #3, patch #3889 (project freeciv):

One other thing regarding patch #3560:
 while there is gtk_button_set_always_show_image, it's only since 3.6 and IMHO
title of the button is descriptive enough in the context anyway if one has a
theme that turns off images on buttons.

As for gtk_rc_get_theme_dir, my description was not quite precise - see
"Default files" section of GtkCssProvider docs.

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread RafałMużyło
Follow-up Comment #2, patch #3889 (project freeciv):

In random order:

- gtk_rc_get_theme_dir is an annoyance: it was a concept change in gtk3, css
themes are read from by default from paths hardcoded on (gtk+) build time
(i.e. ${prefix}/share/themes),  so there's no real equivalent for it
- create_cma_dialog got stuck in patch #3560 (again, IMHO, that *upstream*
setting is not much different than freeciv  small display settings)
- citydlg.c:2799:3 and cityrep.c:1437:3 go back to what I've wrote in i.e. bug
#20097 - silencing those warnings would be easy, writing a proper fix - not
so
- mapctrl.c set is patch #3550 and this one should be a proper fix

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread Marko Lindqvist
Follow-up Comment #1, patch #3889 (project freeciv):

Attached is deprecation warnings from current TRUNK when built against
gtk+-3.4.0.

(file #17867)
___

Additional Item Attachment:

File name: stderr.log Size:2 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev


[Freeciv-Dev] [patch #3889] [Metaticket] Fix things deprecated in gtk+-3.4 (oldest supported) already

2013-04-30 Thread Marko Lindqvist
URL:
  

 Summary: [Metaticket] Fix things deprecated in gtk+-3.4
(oldest supported) already
 Project: Freeciv
Submitted by: cazfi
Submitted on: Wed 01 May 2013 02:07:05 AM EEST
Category: client-gtk-3.0
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

gtk3-client uses number of constructs that are deprecated in the oldest
supported version, 3.4, already. Those should be replaced with more modern
constructs.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev