[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-04-26 Thread Jacob Nevins 
Follow-up Comment #5, patch #4388 (project freeciv):

> I noticed that REQ_RANGE_WORLD is still handled separately from 
> REQ_RANGE_ALLIANCE, REQ_RANGE_TEAM in some is_xxx_in_range() 
> functions despite being supported by players_in_same_range(). 
> Is that intentional?
On a quick look, I think most of the places where REQ_RANGE_WORLD is handled
separately takes advantage of quicker ways of getting information at world
range (num_world_buildings() etc). The only exception I noticed where the code
could be simplified without losing this was is_techflag_in_range().

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-04-25 Thread Marko Lindqvist 
Follow-up Comment #4, patch #4388 (project freeciv):

Building on top of this patch, I noticed that REQ_RANGE_WORLD is still handled
separately from REQ_RANGE_ALLIANCE, REQ_RANGE_TEAM in some is_xxx_in_range()
functions despite being supported by players_in_same_range(). Is that
intentional?

___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-04-25 Thread Jacob Nevins 
Update of patch #4388 (project freeciv):

  Status:  Ready For Test => Done   
 Open/Closed:Open => Closed 


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-04-23 Thread Jacob Nevins 
Update of patch #4388 (project freeciv):

  Status: In Progress => Ready For Test 

___

Follow-up Comment #2:

New version, ready for commit.

> * Untested
Now lightly tested.

> * Not written help yet because patch #4400 still WIP 
Fixed (new help is in the style of patch #4400).

> * Not updated README.effects because patch #4401 still WIP 
Not blocking this on that; but I've minimally updated README.effects in this
version.

(file #20568)
___

Additional Item Attachment:

File name: trunk-req-range-team.patch Size:23 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-01-04 Thread Jacob Nevins 
Follow-up Comment #1, patch #4388 (project freeciv):

Very early WIP. Not a commit candidate because:
* Untested
* Not written help yet because patch #4400 still WIP
* Not updated README.effects because patch #4401 still WIP

One notable decision: wrt bug #21415, I have decided to have the AI consider
team-ranged effects, because it will always be on teammates' side so does not
need to worry about benefiting them (its evaluation will still be entirely
selfish, though, I think).

(file #19668)
___

Additional Item Attachment:

File name: trunk-req-range-team-wip1.patch Size:15 KB


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-01-04 Thread Jacob Nevins 
Update of patch #4388 (project freeciv):

  Status:None => In Progress
 Assigned to:None => jtn
 Planned Release: => 2.6.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-01-04 Thread Jacob Nevins 
Update of patch #4388 (project freeciv):

  Depends on: => patch #4406


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4388] Requirement range "Team"

2014-01-02 Thread Jacob Nevins 
URL:
  

 Summary: Requirement range "Team"
 Project: Freeciv
Submitted by: jtn
Submitted on: Thu Jan  2 12:04:56 2014
Category: None
Priority: 5 - Normal
  Status: None
 Privacy: Public
 Assigned to: None
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 

___

Details:

Similar to "Alliance" (patch #4231), it seems straightforward and potentially
useful to have a range which matches any player on the same team.




___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev