[Freeciv-Dev] [patch #4681] Consolidate AI Ferry tests
Update of patch #4681 (project freeciv): Status: Ready For Test = Done Open/Closed:Open = Closed ___ Reply to this item at: http://gna.org/patch/?4681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4681] Consolidate AI Ferry tests
Update of patch #4681 (project freeciv): Status: In Progress = Ready For Test ___ Follow-up Comment #3: My apologies: I completely missed the point of your comment. Attached is an updated patch that ensures that the ferry is capable of oceanic movement (as is indeed required by the ferry code), with narrower nativity restrictions on cargo. Handling the case of an oceanic unit seeking transport overland is deferred for now. (file #20624) ___ Additional Item Attachment: File name: consolidate-ai-ferry-tests+land-guard.patch Size:3 KB ___ Reply to this item at: http://gna.org/patch/?4681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4681] Consolidate AI Ferry tests
Follow-up Comment #1, patch #4681 (project freeciv): ferry in dai_is_ferry_type() refers to ferry system code. I'm more than slightly worried about the removal of the check against land-only moving units? I don't think aiferry code is ready to that. ___ Reply to this item at: http://gna.org/patch/?4681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4681] Consolidate AI Ferry tests
Follow-up Comment #2, patch #4681 (project freeciv):
Is it safe to assume that is_ferry_type() is running in a server context, so
that the code can be something like the following?
unit_type_iterate(putype) {
puclass = utype_class(putype);
if (can_unit_type_transport(pferry, utype_class(putype))
!uclass_has_flag(puclass, UCF_MISSILE)
(puclass-adv.sea_move == MOVE_NONE
|| 0 != utype_fuel(putype))) {
return TRUE;
}
} unit_type_iterate_end;
If so, do you think it safe to use sea_move != MOVE_FULL rather than
sea_move == MOVE_NONE to handle the case of units with limited amphibious
capabilities needing transport? I'm not that worried about removing the
restriction on UMT_LAND, simply because the code currently theoretically also
supports UMT_BOTH. Where I suspect problems may occur is in handling UMT_SEA
units seeking transport (and preventing this may continue to have value).
___
Reply to this item at:
http://gna.org/patch/?4681
___
Message sent via/by Gna!
http://gna.org/
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4681] Consolidate AI Ferry tests
Update of patch #4681 (project freeciv): Status: Ready For Test = In Progress ___ Reply to this item at: http://gna.org/patch/?4681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
[Freeciv-Dev] [patch #4681] Consolidate AI Ferry tests
URL: http://gna.org/patch/?4681 Summary: Consolidate AI Ferry tests Project: Freeciv Submitted by: persia Submitted on: Thu 01 May 2014 02:36:08 PM JST Category: ai Priority: 5 - Normal Status: Ready For Test Privacy: Public Assigned to: persia Originator Email: Open/Closed: Open Discussion Lock: Any Planned Release: 2.6.0 ___ Details: The AI tests to see if a unit is a ferry in two different ways in two different places. Cause the test in aihunt.c to call the test in aiferry.c, and adjust the test in aiferry.c to fix the FIXME in the previous aihunt.c code. ___ File Attachments: --- Date: Thu 01 May 2014 02:36:08 PM JST Name: consolidate-ai-ferry-tests.patch Size: 3kB By: persia http://gna.org/patch/download.php?file_id=20619 ___ Reply to this item at: http://gna.org/patch/?4681 ___ Message sent via/by Gna! http://gna.org/ ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev
