[Freeciv-Dev] [patch #4683] Make the "Marines" and "AttFromNonNative" flags action neutral

[Marko Lindqvist]

Update of patch #4683 (project freeciv):

Category:None => general
 Planned Release:   2.6.0 => 3.0.0  


___

Reply to this item at:

  

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4683] Make the Marines and AttFromNonNative flags action neutral

[Sveinung Kvilhaugsvik]

Update of patch #4683 (project freeciv):

  Status: In Progress = None   
 Assigned to:sveinung = None   


___

Reply to this item at:

  http://gna.org/patch/?4683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4683] Make the Marines and AttFromNonNative flags action neutral

[Sveinung Kvilhaugsvik]

Update of patch #4683 (project freeciv):

  Status: Wont Do = In Progress
 Open/Closed:  Closed = Open   

___

Follow-up Comment #3:

_It seems a logical accompaniment to patch #4894 to allow ruleset authors to
express that a specific action can be performed by a transport-dependent unit
only if they have one of the Marines or AttFromNonNative flags set_
Good point.

___

Reply to this item at:

  http://gna.org/patch/?4683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4683] Make the Marines and AttFromNonNative flags action neutral

[Sveinung Kvilhaugsvik]

Update of patch #4683 (project freeciv):

  Status: In Progress = Wont Do
 Open/Closed:Open = Closed 


___

Reply to this item at:

  http://gna.org/patch/?4683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4683] Make the Marines and AttFromNonNative flags action neutral

[Emmet Hikory]

Follow-up Comment #2, patch #4683 (project freeciv):

Why not do this?  It seems a logical accompaniment to patch #4894 to allow
ruleset authors to express that a specific action can be performed by a
transport-dependent unit only if they have one of the Marines or
AttFromNonNative flags set .

___

Reply to this item at:

  http://gna.org/patch/?4683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4683] Make the Marines and AttFromNonNative flags action neutral

[Sveinung Kvilhaugsvik]

URL:
  http://gna.org/patch/?4683

 Summary: Make the Marines and AttFromNonNative flags
action neutral
 Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 02 May 2014 04:03:49 PM UTC
Category: None
Priority: 5 - Normal
  Status: Ready For Test
 Privacy: Public
 Assigned to: sveinung
Originator Email: 
 Open/Closed: Open
 Discussion Lock: Any
 Planned Release: 2.6.0

___

Details:

The Marines unit flag and the AttFromNonNative unit class flag has good
support when it comes to path finding etc. Make it possible to use them for
other actions than traditional attack.

Read the comment in patch #4671 for why this is a good idea.



___

File Attachments:


---
Date: Fri 02 May 2014 04:03:49 PM UTC  Name:
0002-Make-the-Marines-and-AttFromNonNative-flags-action-n.patch  Size: 10kB  
By: sveinung

http://gna.org/patch/download.php?file_id=20628

___

Reply to this item at:

  http://gna.org/patch/?4683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] [patch #4683] Make the Marines and AttFromNonNative flags action neutral

[Emmet Hikory]

Follow-up Comment #1, patch #4683 (project freeciv):

The ruleset comments include a parenthetical comment (against native one),
which I would not expect to apply for units that have AttackNonNative 
!Only_Native_Attack.  Since whether this specific combination of flags is set
is independent of whether AttFromNonNative is set, this comment implies a
restriction that may not be enforced (or at least differs from the current
behaviour).

Note that this isn't new with this patch, but it may be worth fixing as long
as the lines in question are being changed by this patch (especially as it is
just a comment, so normally not a sensible patch target).

___

Reply to this item at:

  http://gna.org/patch/?4683

___
  Message sent via/by Gna!
  http://gna.org/


___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev